From 02228e5a967fa16495248ee9f0bfb6e56f030f82 Mon Sep 17 00:00:00 2001 From: D065023 Date: Wed, 29 Jan 2020 14:16:34 +0100 Subject: [PATCH] easier --- packages/bookshop/srv/cat-service.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/bookshop/srv/cat-service.js b/packages/bookshop/srv/cat-service.js index 57a99618..70e14663 100644 --- a/packages/bookshop/srv/cat-service.js +++ b/packages/bookshop/srv/cat-service.js @@ -12,12 +12,10 @@ module.exports = cds.service.impl(async function () { console.log('>> Received', msg.data) const BUSINESSPARTNER = msg.data.KEY[0].BUSINESSPARTNER const orders = await cds.tx(msg).run(SELECT('ID').from(Orders).where({ createdBy: BUSINESSPARTNER })) - if (orders.length) { - const businessPartner = await bupaSrv.tx(msg).run(SELECT.one(BusinessPartners).where({ ID: BUSINESSPARTNER })) - if (businessPartner && businessPartner.BusinessPartnerIsBlocked) { - orders.forEach(order => this.emit('OrderBlocked', order) && console.log('>> Emitted', order)) - } - } + if (!orders.length) return + const businessPartner = await bupaSrv.tx(msg).run(SELECT.one(BusinessPartners).where({ ID: BUSINESSPARTNER })) + if (!businessPartner || !businessPartner.BusinessPartnerIsBlocked) return + orders.forEach(order => this.emit('OrderBlocked', order) && console.log('>> Emitted', order)) }) /** Add some discount for overstocked books */