b.santos/cloud-cap-samples
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cleaner

Browse Source
This commit is contained in:
D065023
2019-12-13 14:20:04 +01:00
parent 4bfd4430e1
commit 4a21b9edc3
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/bookshop/srv/admin-service.js
View File

@@ -48,9 +48,7 @@ bupaSrv.on('sap/S4HANAOD/c532/BO/BusinessPartner/Changed', async msg => {
ownAddresses, ownAddresses,
remoteAddresses remoteAddresses
) )
if (qlsToUpdateDifferences.length) { await tx.run(qlsToUpdateDifferences)
await Promise.all(qlsToUpdateDifferences.map(ql => tx.run(ql)))
}
} catch (e) { } catch (e) {
console.error(e) console.error(e)
} }
@@ -94,7 +92,7 @@ async function _fillAddress (req) {
async function _reduceStock (req) { async function _reduceStock (req) {
const { Items: OrderItems } = req.data const { Items: OrderItems } = req.data
if (OrderItems && OrderItems.length > 0) { if (OrderItems && OrderItems.length > 0) {
const all = await cds.transaction(req).run(() => const all = await cds.transaction(req).run(
OrderItems.map(order => OrderItems.map(order =>
UPDATE(Books) UPDATE(Books)
.set('stock -=', order.amount) .set('stock -=', order.amount)
@@ -114,8 +112,13 @@ async function _reduceStock (req) {
} }
} }
function _checkMandatoryParams(req) {
return !req.data.shippingAddress_AddressID && req.error('Please enter a valid shpping address.', 'shippingAddess_AddressID')
}
module.exports = cds.service.impl(function () { module.exports = cds.service.impl(function () {
this.before('CREATE', 'Orders', _reduceStock) this.before('CREATE', 'Orders', _reduceStock)
this.before('CREATE', 'Orders', _checkMandatoryParams)
this.before('PATCH', 'Orders', _fillAddress) this.before('PATCH', 'Orders', _fillAddress)
this.on('READ', 'Addresses', _readAddresses) this.on('READ', 'Addresses', _readAddresses)
}) })