diff --git a/packages/bookshop/package.json b/packages/bookshop/package.json index d6330cd5..44d69925 100644 --- a/packages/bookshop/package.json +++ b/packages/bookshop/package.json @@ -18,14 +18,7 @@ "requires": { "API_BUSINESS_PARTNER": { "kind": "odata", - "model": "srv/external/API_BUSINESS_PARTNER", - "--credentials": { - "prefix": "sap/S4HANAOD/c098/BO", - "destination": "cap-api098" - } - }, - "--messaging": { - "kind": "enterprise-messaging" + "model": "srv/external/API_BUSINESS_PARTNER" } } } diff --git a/packages/bookshop/srv/cat-service.cds b/packages/bookshop/srv/cat-service.cds index 98b7a27e..efe7b5d9 100644 --- a/packages/bookshop/srv/cat-service.cds +++ b/packages/bookshop/srv/cat-service.cds @@ -1,5 +1,4 @@ using { sap.capire.bookshop as my } from '../db/schema'; -using { API_BUSINESS_PARTNER as external } from './external/API_BUSINESS_PARTNER.csn'; @path:'/browse' service CatalogService { @@ -8,14 +7,6 @@ service CatalogService { author.name as author } excluding { createdBy, modifiedBy }; - @readonly entity BusinessPartners as projection on external.A_BusinessPartner { - key BusinessPartner as ID, - FirstName, - MiddleName, - LastName, - BusinessPartnerIsBlocked - }; - @requires_: 'authenticated-user' @insertonly entity Orders as projection on my.Orders; diff --git a/packages/bookshop/srv/cat-service.js b/packages/bookshop/srv/cat-service.js index 507ca0f6..2a940534 100644 --- a/packages/bookshop/srv/cat-service.js +++ b/packages/bookshop/srv/cat-service.js @@ -1,12 +1,10 @@ const cds = require('@sap/cds') /** Service implementation for CatalogService */ -module.exports = cds.service.impl(async function () { - const { Books, Orders, BusinessPartners } = this.entities - const bupaSrv = await cds.connect.to('API_BUSINESS_PARTNER') +module.exports = cds.service.impl(function () { + const { Books, Orders } = this.entities this.after('READ', Books, each => each.stock > 111 && _addDiscount2(each, 11)) this.before('CREATE', Orders, _reduceStock) - this.on('READ', BusinessPartners, req => bupaSrv.tx(req).run(req.query)) /** Add some discount for overstocked books */ function _addDiscount2(each, discount) { diff --git a/packages/bookshop/srv/external/data/API_BUSINESS_PARTNER-A_BusinessPartner.csv b/packages/bookshop/srv/external/data/API_BUSINESS_PARTNER-A_BusinessPartner.csv deleted file mode 100644 index dc6127e7..00000000 --- a/packages/bookshop/srv/external/data/API_BUSINESS_PARTNER-A_BusinessPartner.csv +++ /dev/null @@ -1,4 +0,0 @@ -BusinessPartner;FirstName;MiddleName;LastName;BusinessPartnerIsBlocked -ALICE;Alice;In;Wonderland;false -BOB;Bob;The;Builder;false -JABBA;Jabba;The;Hutt;true \ No newline at end of file