From b7c2eee961db0160f8890522859a93d597d49619 Mon Sep 17 00:00:00 2001
From: Christian Georgi <chgeo@users.noreply.github.com>
Date: Fri, 13 Dec 2019 11:55:52 +0100
Subject: [PATCH 1/8] Fix broken link to VS Code plugin

Fixes #13
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 923f43d9..86aea7e2 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,7 @@ The samples provided can be run in a local setup on SQLite Database.
 
 #### Optional (if you want to import the code into an editor)
 * [VS Code](https://code.visualstudio.com)
-* [Add CDS extension to VS](https://help.sap.com/viewer/65de2977205c403bbc107264b8eccf4b/Cloud/en-US/be944d6d51f343f6b3f53c29c44ff00a.html)
+* [Add CDS extension to VS](https://cap.cloud.sap/docs/get-started/in-vscode#add-cds-editor)
 
 ## Download and Installation
 

From ad05e2b9db383a938685db659c74ce5e9ae79f43 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Fri, 13 Dec 2019 20:08:41 +0100
Subject: [PATCH 2/8] using sap_fiori_3 theme

---
 packages/bookshop/app/fiori.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/bookshop/app/fiori.html b/packages/bookshop/app/fiori.html
index 09db455d..2fc2a0d4 100644
--- a/packages/bookshop/app/fiori.html
+++ b/packages/bookshop/app/fiori.html
@@ -43,7 +43,7 @@
 	<script src="https://sapui5.hana.ondemand.com/resources/sap-ui-core.js"
     	data-sap-ui-libs="sap.m, sap.ushell, sap.collaboration, sap.ui.layout"
     	data-sap-ui-compatVersion="edge"
-    	data-sap-ui-theme="sap_belize"
+    	data-sap-ui-theme="sap_fiori_3"
     	data-sap-ui-frameOptions="allow"
 	></script>
 	<script>

From eb7431afed27b8e6806e1faf10a0df91f09165f1 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Mon, 30 Dec 2019 13:32:02 +0100
Subject: [PATCH 3/8] fixed: dev dependency to sqlite3

---
 package.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 08b90658..6937a5ac 100644
--- a/package.json
+++ b/package.json
@@ -19,9 +19,11 @@
     "@sap/cds": "latest",
     "express": "*"
   },
+  "devDependencies": {
+    "sqlite3": "*"
+  },
   "--add-these-to-devDependencies-for-tests": {
     "@types/jest": "*",
-    "sqlite3": "*",
     "jest": "*"
   },
   "license": "SAP SAMPLE CODE LICENSE"

From 583c97a4949d47779b41f094010e91866b93f5e9 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Fri, 3 Jan 2020 02:59:27 +0100
Subject: [PATCH 4/8] cleaned up start scripts

---
 .vscode/launch.json                     | 29 +++++++++++--------------
 .vscode/tasks.json                      | 21 +++++-------------
 package.json                            | 12 +++++-----
 packages/bookshop-enhanced/package.json |  4 +++-
 packages/bookshop/package.json          |  3 ++-
 packages/bookstore/package.json         |  3 ++-
 packages/reviews-service/package.json   |  4 ++++
 7 files changed, 35 insertions(+), 41 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index bd2108f4..554bf57c 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -5,19 +5,19 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "cds run",
-      "request": "launch",
-      "type": "node",
-      "runtimeExecutable": "npx",
-      "runtimeArgs": ["-n"],
-      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"], // the leading "--" arg ensures it works with as well as without debugging
+      "name": "bookshop", "request": "launch",
+      "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n", "--" ],
+      "args": [ "cds", "run", "--in-memory" ],
+      "cwd": "${workspaceFolder}/packages/bookshop",
+      "console": "integratedTerminal",
+      "skipFiles": ["<node_internals>/**"]
+    },
+    {
+      "name": "cds run ...", "request": "launch",
+      "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n", "--" ],
+      "args": [ "cds", "run", "--with-mocks", "--in-memory?" ],
       "cwd": "${workspaceFolder}/packages/${input:service}",
       "console": "integratedTerminal",
-      "serverReadyAction": {
-        "pattern": "server listening on (https?://\\S+|[0-9]+)",
-        "uriFormat": "http://localhost:%s",
-        "action": "openExternally"
-      },
       "skipFiles": ["<node_internals>/**"]
     }
   ],
@@ -31,12 +31,9 @@
         "bookstore",
         "media-server",
         "office-supplies",
-        "orders-service",
-        "products-service",
-        "reviews-service",
-        "user-service"
+        "reviews-service"
       ],
-      "default": "bookstore"
+      "default": "bookshop"
     }
   ]
 }
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
index 47e028a5..c507ca84 100644
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -4,23 +4,14 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "type": "shell", "label": "cds run bookshop",
-            "command": "npx", "args": [ "cds", "watch", "packages/bookshop" ],
-            "presentation": { "group": "A" },
-            "problemMatcher": []
+            "type": "npm", "script": "watch", "path": "packages/bookshop/",
+            "options": { "env": { "PORT": "4004" }},
+            "presentation": { "group": "A" }
         },
         {
-            "type": "shell", "label": "cds run bookshop-enhanced",
-            "command": "npx", "args": [ "cds", "watch", "packages/bookshop-enhanced" ],
-            "presentation": { "group": "A" },
-            "problemMatcher": []
-        },
-        {
-            "type": "shell", "label": "cds run reviews-service",
-            "command": "npx", "args": [ "cds", "watch", "packages/reviews-service" ],
-            "options": {"env": { "PORT":"5005" }},
-            "presentation": { "group": "A" },
-            "problemMatcher": []
+            "type": "npm", "script": "watch", "path": "packages/reviews-service/",
+            "options": { "env": { "PORT": "5005" }},
+            "presentation": { "group": "A" }
         }
     ]
 }
\ No newline at end of file
diff --git a/package.json b/package.json
index 6937a5ac..017d41aa 100644
--- a/package.json
+++ b/package.json
@@ -5,15 +5,13 @@
   "author": "daniel.hutzel@sap.com",
   "private": true,
   "scripts": {
-    "cleanup": "lerna clean -y && rm -fr node_modules",
-    "install": "(npm -s run lerna) && lerna bootstrap --hoist",
     "lerna": "npx --no-install lerna -v > /dev/null || npm i lerna --no-save",
-    "test": "jest",
-    "bookshop-enhanced": "cds watch packages/bookshop-enhanced",
+    "install": "(npm -s run lerna) && lerna bootstrap --hoist",
+    "cleanup": "lerna clean -y && rm -fr node_modules",
     "bookshop": "cds watch packages/bookshop",
-    "bookstore": "cds watch packages/bookstore",
-    "products-service": "cds watch packages/products-service",
-    "reviews-service": "cds watch packages/reviews-service"
+    "bookshop-enhanced": "cds watch packages/bookshop-enhanced",
+    "reviews-service": "cds watch packages/reviews-service",
+    "bookstore": "cds watch packages/bookstore"
   },
   "dependencies": {
     "@sap/cds": "latest",
diff --git a/packages/bookshop-enhanced/package.json b/packages/bookshop-enhanced/package.json
index 008da347..94c0ae7e 100644
--- a/packages/bookshop-enhanced/package.json
+++ b/packages/bookshop-enhanced/package.json
@@ -11,7 +11,9 @@
     "express": "*"
   },
   "scripts": {
-    "start": "npx cds run"
+    "reviews-service": "PORT=5005 cds run ../reviews-service --bind --in-memory?",
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   },
   "cds": {
     "requires": {
diff --git a/packages/bookshop/package.json b/packages/bookshop/package.json
index ce5cddf2..4a9d52e9 100644
--- a/packages/bookshop/package.json
+++ b/packages/bookshop/package.json
@@ -8,6 +8,7 @@
     "express": "*"
   },
   "scripts": {
-    "start": "npx cds run"
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   }
 }
diff --git a/packages/bookstore/package.json b/packages/bookstore/package.json
index e36dc529..0f18561b 100644
--- a/packages/bookstore/package.json
+++ b/packages/bookstore/package.json
@@ -28,7 +28,8 @@
     "app", "srv", "db"
   ],
   "scripts": {
-    "start": "cds run"
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   },
   "cds": {
     "requires": {
diff --git a/packages/reviews-service/package.json b/packages/reviews-service/package.json
index 45f3194d..990f4e35 100644
--- a/packages/reviews-service/package.json
+++ b/packages/reviews-service/package.json
@@ -8,6 +8,10 @@
     "@sap/cds": "latest",
     "express": "*"
   },
+  "scripts": {
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
+  },
   "files": [
     "db",
     "srv",

From b1270bc0eb7379d575fc7db32e4df8c13be6a032 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Sat, 4 Jan 2020 07:16:05 +0100
Subject: [PATCH 5/8] fixed launch scripts

---
 .vscode/launch.json | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 554bf57c..c810af37 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -5,17 +5,15 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "bookshop", "request": "launch",
-      "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n", "--" ],
-      "args": [ "cds", "run", "--in-memory" ],
+      "name": "bookshop", "request": "launch", "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n" ],
+      "args": [ "--", "cds", "run", "--in-memory" ],
       "cwd": "${workspaceFolder}/packages/bookshop",
       "console": "integratedTerminal",
       "skipFiles": ["<node_internals>/**"]
     },
     {
-      "name": "cds run ...", "request": "launch",
-      "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n", "--" ],
-      "args": [ "cds", "run", "--with-mocks", "--in-memory?" ],
+      "name": "cds run ...", "request": "launch", "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n" ],
+      "args": [ "--", "cds", "run", "--with-mocks", "--in-memory?" ],
       "cwd": "${workspaceFolder}/packages/${input:service}",
       "console": "integratedTerminal",
       "skipFiles": ["<node_internals>/**"]

From a0847e603f9c6b1f4d93c006b5c0d74df01c1ee3 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Sat, 4 Jan 2020 07:24:11 +0100
Subject: [PATCH 6/8] settings.json restored

---
 .vscode/settings.json | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 10800472..72bc8cb5 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,7 +1,6 @@
 {
   "files.exclude": {
-    "**/.gitignore": false,
-    "**/.git": false,
-    "**/.vscode": false
+    "**/.gitignore": true,
+    "**/.vscode": true
   }
 }

From 6a9a1bc4d67ac5e47503fba2101c0488b3cd8ca2 Mon Sep 17 00:00:00 2001
From: Daniel <daniel.hutzel@sap.com>
Date: Sat, 4 Jan 2020 07:27:19 +0100
Subject: [PATCH 7/8] cleaned up dot files

---
 .eslintrc | 2 +-
 .npmrc    | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
 delete mode 100644 .npmrc

diff --git a/.eslintrc b/.eslintrc
index 79cf25fe..7e6f79e2 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -6,7 +6,7 @@
         "jest": true
     },
     "parserOptions": {
-        "ecmaVersion": 2017
+        "ecmaVersion": 2018
     },
     "globals": {
         "SELECT": true,
diff --git a/.npmrc b/.npmrc
deleted file mode 100644
index 43c97e71..00000000
--- a/.npmrc
+++ /dev/null
@@ -1 +0,0 @@
-package-lock=false

From a04755efedc4adce3757b002de65ac7f5f78c0b5 Mon Sep 17 00:00:00 2001
From: Volker Buzek <volker.buzek@js-soft.com>
Date: Tue, 14 Jan 2020 14:38:14 +0100
Subject: [PATCH 8/8] feat(npm): add .npmrc for @sap-scope

- `npm set @sap...` is unnecessary
- update README.md accordingly
---
 .npmrc    | 1 +
 README.md | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)
 create mode 100644 .npmrc

diff --git a/.npmrc b/.npmrc
new file mode 100644
index 00000000..6041b7e8
--- /dev/null
+++ b/.npmrc
@@ -0,0 +1 @@
+@sap:registry=https://npm.sap.com
\ No newline at end of file
diff --git a/README.md b/README.md
index 86aea7e2..035f076c 100644
--- a/README.md
+++ b/README.md
@@ -23,9 +23,7 @@ The samples provided can be run in a local setup on SQLite Database.
 
 #### Install `cds` development kit
 ```sh
-# sets the registry for `@sap` packages
-npm set @sap:registry=https://npm.sap.com
-
+# `@sap`-scoped packages are set via .npmrc
 npm install -g @sap/cds-dk
 cds  #> test-run it
 ```