From db16577235434eec8eb1a06aa8a096abda31509f Mon Sep 17 00:00:00 2001 From: D065023 Date: Mon, 16 Dec 2019 21:55:33 +0100 Subject: [PATCH 1/5] no more bla --- packages/bookshop/req.http | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bookshop/req.http b/packages/bookshop/req.http index 872eb741..941fe3cb 100644 --- a/packages/bookshop/req.http +++ b/packages/bookshop/req.http @@ -4,5 +4,5 @@ Authorization: Basic QUxJQ0Utc2VjcmV0 { "PostalCode": "123456", - "CityName": "BlaTown" + "CityName": "AlteredTown" } From 74c155ca62adb811bbdc8ceb4981256f92ac86c1 Mon Sep 17 00:00:00 2001 From: D065023 Date: Mon, 16 Dec 2019 21:56:32 +0100 Subject: [PATCH 2/5] better --- .../srv/external/API_BUSINESS_PARTNER.js | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/packages/bookshop/srv/external/API_BUSINESS_PARTNER.js b/packages/bookshop/srv/external/API_BUSINESS_PARTNER.js index 9f7f6c87..ac67937a 100644 --- a/packages/bookshop/srv/external/API_BUSINESS_PARTNER.js +++ b/packages/bookshop/srv/external/API_BUSINESS_PARTNER.js @@ -1,13 +1,11 @@ module.exports = srv => { - - srv.on('UPDATE', req => { - - const payload = { - KEY: [{ BUSINESSPARTNER: req.data.BusinessPartner }] - } - console.log('<< Message:', payload) - srv.emit('sap/S4HANAOD/c532/BO/BusinessPartner/Changed', payload) - + srv.on('UPDATE', req => { + const payload = { + KEY: [{ BUSINESSPARTNER: req.data.BusinessPartner }] + } + console.log('<< Message:', payload) + req.on('succeeded', () => { + srv.emit('sap/S4HANAOD/c532/BO/BusinessPartner/Changed', payload) }) - -} \ No newline at end of file + }) +} From 0b0a22d126aadfb575fc07e2ca5ee96f6dc3d3cb Mon Sep 17 00:00:00 2001 From: David-Kunz Date: Tue, 17 Dec 2019 09:40:17 +0100 Subject: [PATCH 3/5] Update schema.cds --- packages/bookshop/db/schema.cds | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bookshop/db/schema.cds b/packages/bookshop/db/schema.cds index 6afa0a07..9d9440bf 100644 --- a/packages/bookshop/db/schema.cds +++ b/packages/bookshop/db/schema.cds @@ -1,6 +1,6 @@ namespace sap.capire.bookshop; using { Currency, managed, cuid } from '@sap/cds/common'; -using { API_BUSINESS_PARTNER as external } from '../srv/external/API_BUSINESS_PARTNER'; +using { API_BUSINESS_PARTNER as external } from '../srv/external/API_BUSINESS_PARTNER.csn'; entity Books : managed { key ID : Integer; @@ -45,4 +45,4 @@ entity ShippingAddresses as projection on external.A_BusinessPartnerAddress { PostalCode as postalCode, StreetName as streetName, HouseNumber as houseNumber -} \ No newline at end of file +} From 8eaf34f5d3dc9b5c1eac9bb3ff1bf2e4844734d1 Mon Sep 17 00:00:00 2001 From: David-Kunz Date: Tue, 17 Dec 2019 09:59:11 +0100 Subject: [PATCH 4/5] Update package.json --- packages/bookshop/package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/bookshop/package.json b/packages/bookshop/package.json index ae840e3b..b8c4aa97 100644 --- a/packages/bookshop/package.json +++ b/packages/bookshop/package.json @@ -19,8 +19,7 @@ "kind": "odata", "model": "srv/external/API_BUSINESS_PARTNER", "--credentials": { - "destination": "cap-api532", - "prefix": "sap/S4HANAOD/c532/BO" + "destination": "cap-api532" } }, "messaging": { From 3027a7a1e5b6fd2c2fcdcaaece5848649196ca65 Mon Sep 17 00:00:00 2001 From: D065023 Date: Tue, 17 Dec 2019 10:03:17 +0100 Subject: [PATCH 5/5] hack for app studio --- packages/bookshop/srv/admin-service.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/bookshop/srv/admin-service.js b/packages/bookshop/srv/admin-service.js index ae2bb333..e5028779 100644 --- a/packages/bookshop/srv/admin-service.js +++ b/packages/bookshop/srv/admin-service.js @@ -1,3 +1,8 @@ +process.env["http_proxy"] = "" +process.env["https_proxy"] = "" +process.env["HTTP_PROXY"] = "" +process.env["HTTPS_PROXY"] = "" + const cds = require('@sap/cds') const { queriesToUpdateDifferences } = require('./utils') const { Books, ShippingAddresses } = cds.entities @@ -28,7 +33,7 @@ bupaSrv.on('sap/S4HANAOD/c532/BO/BusinessPartner/Changed', async msg => { } }) -async function _readAddresses (req) { +async function _readAddresses(req) { console.log('Addresses', ShippingAddresses) const BusinessPartner = req.user.id const txExt = bupaSrv.transaction(req) @@ -43,7 +48,7 @@ async function _readAddresses (req) { } } -async function _fillAddress (req) { +async function _fillAddress(req) { if (req.data.shippingAddress_AddressID) { const BusinessPartner = req.user.id const txExt = bupaSrv.transaction(req) @@ -59,11 +64,11 @@ async function _fillAddress (req) { const insertQuery = INSERT.into(ShippingAddresses).entries(response) await tx.run(insertQuery) } - } catch (e) {} + } catch (e) { } } } -async function _reduceStock (req) { +async function _reduceStock(req) { const { Items: OrderItems } = req.data if (OrderItems && OrderItems.length > 0) { const all = await cds.transaction(req).run( @@ -79,14 +84,14 @@ async function _reduceStock (req) { req.error( 409, `${OrderItems[i].amount} exceeds stock for book #${ - OrderItems[i].book_ID + OrderItems[i].book_ID }` ) }) } } -function _checkMandatoryParams (req) { +function _checkMandatoryParams(req) { if (!req.data.Items || !req.data.Items.length) { return req.reject('Please order at least one item.') }