Merge branch 'master' into preview

.deploy/app-router/package.json

@@ -1,9 +0,0 @@
-{
-  "name": "approuter",
-  "dependencies": {
-    "@sap/approuter": "^20.0.0"
-  },
-  "scripts": {
-    "start": "node node_modules/@sap/approuter/approuter.js"
-  }
-}

.deploy/app-router/resources/bookshop

@@ -1 +0,0 @@
-../../../bookshop/app/vue

.deploy/app-router/resources/orders

@@ -1 +0,0 @@
-../../../orders/app/orders

.deploy/app-router/resources/reviews

@@ -1 +0,0 @@
-../../../reviews/app/vue

.deploy/app-router/xs-app.json

@@ -1,46 +0,0 @@
-{
-  "welcomeFile": "app/bookshop/index.html",
-  "routes": [
-    {
-      "source": "^/-/cds/.*",
-      "destination": "mtx-api",
-      "authenticationType": "none"
-    },
-    {
-      "source": "^/app/(.*)$",
-      "target": "$1",
-      "localDir": "resources",
-      "cacheControl": "no-cache, no-store, must-revalidate"
-    },
-    {
-      "source": "^/admin/(.*)$",
-      "target": "/admin/$1",
-      "destination": "bookstore-api",
-      "csrfProtection": true
-    },
-    {
-      "source": "^/browse/(.*)$",
-      "target": "/browse/$1",
-      "destination": "bookstore-api",
-      "csrfProtection": true
-    },
-    {
-      "source": "^/user/(.*)$",
-      "target": "/user/$1",
-      "destination": "bookstore-api",
-      "csrfProtection": true
-    },
-    {
-      "source": "^/odata/v4/orders/(.*)$",
-      "target": "/odata/v4/orders/$1",
-      "destination": "orders-api",
-      "csrfProtection": true
-    },
-    {
-      "source": "^/reviews/(.*)$",
-      "target": "/reviews/$1",
-      "destination": "reviews-api",
-      "csrfProtection": true
-    }
-  ]
-}

.env

@@ -0,0 +1,2 @@
+cds.features.snapi = y
+cds.cdsc.beta.aspectCompositions = true

.eslintrc

@@ -0,0 +1,26 @@
+{
+    "extends": "eslint:recommended",
+    "env": {
+        "browser": true,
+        "node": true,
+        "es6": true,
+        "jest": true,
+        "mocha": true
+    },
+    "parserOptions": {
+        "ecmaVersion": 2018
+    },
+    "globals": {
+        "SELECT": true,
+        "INSERT": true,
+        "UPDATE": true,
+        "DELETE": true,
+        "CREATE": true,
+        "DROP": true,
+        "cds": true
+    },
+    "rules": {
+        "no-console": "off",
+        "require-atomic-updates": "off"
+    }
+}

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: This channel is CLOSED. 
-    about: Use SAP community instead
-    url: https://answers.sap.com/tags/9f13aee1-834c-4105-8e43-ee442775e5ce

.github/dependabot.yml

@@ -1,20 +0,0 @@
-version: 2
-
-updates:
-- package-ecosystem: npm
-  directory: /
-  versioning-strategy: increase-if-necessary
-  schedule:
-    interval: weekly
-  groups:
-    production-dependencies:
-      dependency-type: "production"
-    development-dependencies:
-      dependency-type: "development"
-  ignore:
-    - dependency-name: "chai"
-        # chai 5 doesn't work atm w/ cds.test, TODO fix that in cds.test
-      versions: ["5.x"]
-    - dependency-name: "chai-as-promised"
-        # chai-as-promised 8 doesn't work atm w/ cds.test, TODO fix that in cds.test
-      versions: ["8.x"]

.github/workflows/node.js.yml

@@ -1,38 +0,0 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
-
-name: CI
-
-on:
-  push:
-    branches: [ main ]
-  pull_request:
-    branches: [ main ]
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        node-version: [22.x, 20.x, 18.x]
-
-    steps:
-    - uses: actions/checkout@v4
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
-      with:
-        node-version: ${{ matrix.node-version }}
-    - run: npm ci
-    - run: npm test
-
-  lint:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-node@v4
-      with:
-        node-version: 22.x
-    - run: npm ci
-    - run: npm run lint

.gitignore

@@ -12,14 +12,6 @@ target/
 *.mtar
 connection.properties
 default-env.json
-.cdsrc-private.json
 packages/messageBox
 reviews/msg-box
 reviews/db/test.db
-
-*.openapi3.json
-*.sqlite
-*.db
-
-@types/
-@cds-models/

.npmrc

@@ -0,0 +1 @@
+@sap:registry=https://npm.sap.com

.reuse/dep5

@@ -1,29 +0,0 @@
-Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: cloud-cap-samples
-Upstream-Contact: <Christian Georgi (christian.georgi@sap.com)>
-Source: https://github.com/SAP-samples/cloud-cap-samples
-Disclaimer: The code in this project may include calls to APIs (“API Calls”) of
- SAP or third-party products or services developed outside of this project
- (“External Products”).
- “APIs” means application programming interfaces, as well as their respective
- specifications and implementing code that allows software to communicate with
- other software.
- API Calls to External Products are not licensed under the open source license
- that governs this project. The use of such API Calls and related External
- Products are subject to applicable additional agreements with the relevant
- provider of the External Products. In no event shall the open source license
- that governs this project grant any rights in or to any External Products,or
- alter, expand or supersede any terms of the applicable additional agreements.
- If you have a valid license agreement with SAP for the use of a particular SAP
- External Product, then you may make use of any API Calls included in this
- project’s code for that SAP External Product, subject to the terms of such
- license agreement. If you do not have a valid license agreement for the use of
- a particular SAP External Product, then you may only make use of any API Calls
- in this project for that SAP External Product for your internal, non-productive
- and non-commercial test and evaluation of such API Calls. Nothing herein grants
- you any rights to use or access any SAP External Product, or provide any third
- parties the right to use of access any SAP External Product, through API Calls.
-
-Files: *.*
-Copyright: 2019-2025 SAP SE or an SAP affiliate company and cap-cloud-samples
-License: Apache-2.0

.vscode/extensions.json

@@ -4,11 +4,14 @@
 
 	// List of extensions which should be recommended for users of this workspace.
 	"recommendations": [
-		"qwtel.sqlite-viewer",
+		// "CDS Editor !",
-		"sapse.vscode-cds",
 		"dbaeumer.vscode-eslint",
+		"esbenp.prettier-vscode",
 		"mechatroner.rainbow-csv",
 		"humao.rest-client",
+		"alexcvzz.vscode-sqlite",
+		"hbenl.vscode-mocha-test-adapter",
+		"sdras.night-owl"
 	],
 	// List of extensions recommended by VS Code that should not be recommended for users of this workspace.
 	"unwantedRecommendations": [

.vscode/launch.json

@@ -6,51 +6,33 @@
   "configurations": [
     {
       "name": "bookshop",
-      "command": "npx cds watch bookshop",
+      "cwd": "${workspaceFolder}/bookshop",
-      "type": "node-terminal",
       "request": "launch",
-      "skipFiles": [
+      "type": "node",
-        "<node_internals>/**",
+      "runtimeExecutable": "npx",
-        "**/node_modules/**",
+      "runtimeArgs": ["-n"],
-        "**/cds/lib/lazy.js",
+      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"],
-        "**/cds/lib/req/cds-context.js",
+      "console": "integratedTerminal",
-        "**/odata-v4/okra/**"
+      "skipFiles": ["<node_internals>/**"]
-      ]
     },
     {
       "name": "Fiori App",
-      "command": "npx cds watch fiori",
+      "cwd": "${workspaceFolder}/fiori",
-      "type": "node-terminal",
       "request": "launch",
-      "skipFiles": [
-        "<node_internals>/**",
-        "**/node_modules/**",
-        "**/cds/lib/lazy.js",
-        "**/cds/lib/req/cds-context.js",
-        "**/odata-v4/okra/**"
-      ]
-    },
-    {
-      "name": "Debug Mocha Tests",
       "type": "node",
-      "request": "attach",
+      "runtimeExecutable": "npx",
-      "port": 9229,
+      "runtimeArgs": ["-n"],
-      "continueOnAttach": true,
+      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"],
-      "skipFiles": [
+      "console": "integratedTerminal",
-        "<node_internals>/**",
+      "skipFiles": ["<node_internals>/**"]
-        "**/node_modules/**",
+    }
-        "**/cds/lib/lazy.js",
-        "**/cds/lib/req/cds-context.js",
-        "**/odata-v4/okra/**",
-      ]
-    },
   ],
   "inputs": [
     {
       "type": "pickString",
       "id": "sample",
       "description": "Which sample do you want to start?",
-      "options": [ "bookshop", "fiori", "reviews", "reviews" ],
+      "options": ["bookshop", "fiori", "reviews", "reviews/test/bookshop"],
       "default": "bookshop"
     }
   ]

.vscode/settings.json

@@ -1,17 +1,6 @@
 {
   "files.exclude": {
-    "**/node_modules": true,
+    "**/.gitignore": true,
-    "LICENSES": true,
+    "**/.vscode": true
-    ".reuse": true
+  }
-  },
-  "debug.javascript.terminalOptions": {
-    "skipFiles": [
-      "<node_internals>/**",
-      "**/node_modules/**",
-      "**/cds/lib/lazy.js",
-      "**/cds/lib/req/cds-context.js",
-      "**/odata-v4/okra/**"
-    ]
-  },
-  "jest.jestCommandLine": "npx jest"
 }

LICENSE

@@ -199,3 +199,19 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+--------------------------------------------------------------------------------------------------------------------------
+APIs
+
+This project may include APIs to SAP or third-party products or services.
+The use of these APIs, products and services may be subject to additional
+agreements. In no event shall the application of the Apache Software
+License, v.2 to this project grant any rights in or to these APIs,
+products or services that would alter, expand, be inconsistent with,
+or supersede any terms of these additional agreements. “API” means
+application programming interfaces, as well as their respective
+specifications and implementing code that allows other software
+products to communicate with or call on SAP or third party products
+or services (for example, SAP Enterprise Services, BAPIs, Idocs, RFCs
+and ABAP calls or other user exits) and may be made available through
+SAP or third party products, SDKs, documentation or other media.

README.md

@@ -0,0 +1,57 @@
+# Welcome to cap/samples
+
+Find here a collection of samples for the [SAP Cloud Application Programming Model](https://cap.cloud.sap) organized in a simplistic [monorepo setup](samples.md#all-in-one-monorepo). → See [**Overview** of contained samples](samples.md)
+
+
+### Preliminaries
+
+1. [Install @sap/cds-dk](https://cap.cloud.sap/docs/get-started/) as documented in [capire](https://cap.cloud.sap)
+2. _Optional:_ [Use Visual Studio Code](https://cap.cloud.sap/docs/get-started/in-vscode)
+
+
+### Download
+
+Clone this repo as shown below, if you have [git](https://git-scm.com/downloads) installed,
+otherwise [download as zip file](archive/master.zip).
+
+```sh
+git clone https://github.com/sap-samples/cloud-cap-samples samples
+cd samples
+```
+
+### Setup
+
+In the samples folder run:
+
+```sh
+npm install
+```
+
+### Run
+
+With that you're ready to run the samples, for example:
+
+```sh
+cds watch bookshop
+```
+
+After that open this link in your browser: [http://localhost:4004](http://localhost:4004)
+
+### Testing
+
+Run the provided tests with [_jest_](http://jestjs.io) or [_mocha_](http://mochajs.org), e.g.:
+```sh
+npx jest
+```
+> While mocha is a bit smaller and faster, jest runs tests in parallel and isolation which allows to run all tests.
+
+
+## Get Support
+
+Check out the cap docs at [https://cap.cloud.sap](https://cap.cloud.sap). <br>
+In case you find a bug or need support, please [open an issue in here](https://github.com/SAP-samples/cloud-cap-samples/issues/new).
+
+
+## License
+
+Copyright (c) 2019 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, version 2.0 except as noted otherwise in the [LICENSE](/LICENSE) file.

bookshop/.env

@@ -0,0 +1 @@
+cds.features.snapi = y

bookshop/app/index.cds

@@ -0,0 +1,2 @@
+// Incorporate pre-build extensions from...
+using from '@capire/common';

bookshop/app/vue/app.js

@@ -3,87 +3,43 @@ const $ = sel => document.querySelector(sel)
 const GET = (url) => axios.get('/browse'+url)
 const POST = (cmd,data) => axios.post('/browse'+cmd,data)
 
-const books = Vue.createApp ({
+const books = new Vue ({
 
-    data() {
+    el:'#app',
-      return {
+
+    data: {
         list: [],
-        book: undefined,
+        book: { descr:'( click on a row to see details... )' },
-        order: { quantity:1, succeeded:'', failed:'' },
+        order: { amount:1, succeeded:'', failed:'' }
-        user: undefined
-      }
     },
 
     methods: {
 
-        search: ({target:{value:v}}) => books.fetch(v && '&$search='+v),
+        search: ({target:{value:v}}) => books.fetch (v && '$search='+v),
 
-        async fetch (etc='') {
+        async fetch (_filter='') {
-            const {data} = await GET(`/ListOfBooks?$expand=genre($select=name),currency($select=symbol)${etc}`)
+            const columns = 'ID,title,author,price,stock', details = 'genre,currency'
+            const {data} = await GET(`/Books?$select=${columns}&$expand=${details}&${_filter}`)
             books.list = data.value
         },
 
-        async inspect (eve) {
+        async inspect () {
-            const book = books.book = books.list [eve.currentTarget.rowIndex-1]
+            const book = books.book = books.list [event.currentTarget.rowIndex-1]
-            const res = await GET(`/Books/${book.ID}?$select=descr,stock,image`)
+            book.descr || await GET(`/Books/${book.ID}/descr/$value`) .then (({data}) => book.descr = data)
-            Object.assign (book, res.data)
+            books.order = { amount:1 }
-            books.order = { quantity:1 }
             setTimeout (()=> $('form > input').focus(), 111)
         },
 
-        async submitOrder () {
+        submitOrder () { event.preventDefault()
-            const {book,order} = books, quantity = parseInt (order.quantity) || 1 // REVISIT: Okra should be less strict
+            const {book,order} = books, amount = parseInt (order.amount) || 1
-            try {
+            POST(`/submitOrder`, { amount, book: book.ID })
-                const res = await POST(`/submitOrder`, { quantity, book: book.ID })
+            .then (()=> books.order = { amount, succeeded: `Successfully orderd ${amount} item(s).` })
-                book.stock = res.data.stock
+            .catch (e=> books.order = { amount, failed: e.response.data.error.message })
-                books.order = { quantity, succeeded: `Successfully ordered ${quantity} item(s).` }
+            GET(`/Books/${book.ID}/stock/$value`).then (res => book.stock = res.data)
-            } catch (e) {
-                books.order = { quantity, failed: e.response.data.error ? e.response.data.error.message : e.response.data }
         }
-        },
 
-        async login() {
-            try {
-                const { data:user } = await axios.post('/user/login',{})
-                if (user.id !== 'anonymous') books.user = user
-            } catch (err) { books.user = { id: err.message } }
-        },
-
-        async getUserInfo() {
-            try {
-                const { data:user } = await axios.get('/user/me')
-                if (user.id !== 'anonymous') books.user = user
-            } catch (err) { books.user = { id: err.message } }
-        },
     }
-}).mount('#app')
-
-books.getUserInfo()
-books.fetch() // initially fill list of books
-
-document.addEventListener('keydown', (event) => {
-    // hide user info on request
-    if (event.key === 'u')  books.user = undefined
 })
 
-axios.interceptors.request.use(csrfToken)
+// initially fill list of books
-function csrfToken (request) {
+books.fetch()
-    if (request.method === 'head' || request.method === 'get') return request
-    if ('csrfToken' in document) {
-        request.headers['x-csrf-token'] = document.csrfToken
-        return request
-    }
-    return fetchToken().then(token => {
-        document.csrfToken = token
-        request.headers['x-csrf-token'] = document.csrfToken
-        return request
-    }).catch(() => {
-        document.csrfToken = null // set mark to not try again
-        return request
-    })
-
-    function fetchToken() {
-        return axios.get('/', { headers: { 'x-csrf-token': 'fetch' } })
-        .then(res => res.headers['x-csrf-token'])
-    }
-}

bookshop/app/vue/index.html

@@ -3,73 +3,54 @@
 
 <head>
     <title> Capire Books </title>
-    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/primitive-ui/dist/css/main.css">
+    <link rel="stylesheet" href="https://unpkg.com/primitive-ui/dist/css/main.css">
     <script src="https://cdn.jsdelivr.net/npm/axios/dist/axios.min.js"></script>
-    <script src="https://cdn.jsdelivr.net/npm/vue@3/dist/vue.global.prod.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/vue"></script>
     <style>
-        .hovering tr:hover td { color:cyan; background: #123; cursor: pointer; }
+        #books tr:hover { background: #f2f2f2; cursor: pointer; }
-        .rating-stars { color:teal }
+        form { float:right; display:flex; flex-direction: row-reverse }
-        .succeeded { color:teal }
+        form #amount { width: 5em }
-        .failed { color:red }
+        .is-success { color: #0d920d }
-        .user {text-align: end; color: grey;}
+        .has-error { color: #df1010 }
     </style>
 </head>
 
 <body class="small-container", style="margin-top: 70px;">
 <div id='app'>
 
-    <form class="user" @submit.prevent="login">
-        <div v-if="user">
-            <div v-if="user.tenant">Tenant: {{ user.tenant }}</div>
-            <div> User: {{ user.id }}</div>
-            <div>Locale: {{ user.locale }}</div>
-        </div>
-        <div v-else>
-            <input type="submit" value="Login" class="muted-button">
-            <!-- <a href="/user/login()">Login</a> -->
-        </div>
-    </form>
-
     <h1> Capire Books </h1>
 
     <input type="text" placeholder="Search..." @input="search">
 
-    <table id='books' class="hovering">
+    <table id='books'>
         <thead>
             <th> Book </th>
             <th> Author </th>
             <th> Genre </th>
-            <th> Rating </th>
             <th> Price </th>
         </thead>
         <tr v-for="book in list" v-bind:id="book.ID" v-on:click="inspect">
             <td>{{ book.title }}</td>
             <td>{{ book.author }}</td>
             <td>{{ book.genre.name }}</td>
-            <td class="rating-stars">
+            <td>{{ book.currency.symbol }} {{ book.price }}</td>
-                {{ ('★'.repeat(Math.round(book.rating))+'☆☆☆☆☆').slice(0,5) }} ({{ book.numberOfReviews }})
-            </td>
-            <td>{{ book.currency && book.currency.symbol }} {{ book.price }}</td>
         </tr>
     </table>
 
-    <div v-if="book">
+    <div v-if="book.title">
-        <img v-bind:src="book.image" alt=""/>
         <label style="text-align:right">
-            <span class="succeeded"> {{ order.succeeded }} </span>
+            <span class="is-success"> {{ order.succeeded }} </span>
-            <span class="failed"> {{ order.failed }} </span>
+            <span class="has-error"> {{ order.failed }} </span>
             &nbsp;&nbsp; {{ book.stock }} in stock
         </label>
-        <form @submit.prevent="submitOrder" style="float:right; display:flex; flex-direction:row-reverse">
+        <form @submit="submitOrder">
-            <input type="number" v-model="order.quantity" v-bind:class="{ failed: order.failed }" style="width:5em">
+            <input type="number" id="amount" v-model="order.amount" v-bind:class="{ 'has-error': order.failed }">
             <input type="submit" value="Order:" class="muted-button">
         </form>
+    </div>
+
     <h4> {{ book.title }} </h4>
     <p> {{ book.descr }} </p>
-    </div>
-    <div v-else>
-        ( click on a row to see details... )
-    </div>
 
 </div>
 </body>

bookshop/db/data/sap.capire.bookshop-Authors.csv

@@ -1,5 +1,5 @@
-ID,name,dateOfBirth,placeOfBirth,dateOfDeath,placeOfDeath
+ID;name;dateOfBirth;placeOfBirth;dateOfDeath;placeOfDeath
-101,Emily Brontë,1818-07-30,"Thornton, Yorkshire",1848-12-19,"Haworth, Yorkshire"
+101;Emily Brontë;1818-07-30;Thornton, Yorkshire;1848-12-19;Haworth, Yorkshire
-107,Charlotte Brontë,1818-04-21,"Thornton, Yorkshire",1855-03-31,"Haworth, Yorkshire"
+107;Charlotte Brontë;1818-04-21;Thornton, Yorkshire;1855-03-31;Haworth, Yorkshire
-150,Edgar Allen Poe,1809-01-19,"Boston, Massachusetts",1849-10-07,"Baltimore, Maryland"
+150;Edgar Allen Poe;1809-01-19;Boston, Massachusetts;1849-10-07;Baltimore, Maryland
-170,Richard Carpenter,1929-08-14,"King’s Lynn, Norfolk",2012-02-26,"Hertfordshire, England"
+170;Richard Carpenter;1929-08-14;King’s Lynn, Norfolk;2012-02-26;Hertfordshire, England