Remove workaround for authorization glitch

* Enable authorizations w/ dummy-auth

* fixed: some tests run in privileged mode

* Fixed tests to skip auth

* npm test --silent

* Added dependency to passport

.env

@@ -1,8 +0,0 @@
-cds.features.snapi = true
-cds.odata.version = v4
-cds.odata.containment = true
-cds.odata.proxies = true
-cds.odata.format = structured
-cds.cdsc.beta.uniqueconstraints = true
-cds.cdsc.beta.aspectCompositions = true
-cds.cdsc.severities.unexpected-key = info

.github/ISSUE_TEMPLATE/question--feedback-or-bug-.md

@@ -0,0 +1,10 @@
+---
+name: This channel is CLOSED. 
+about: Use our community at  https://answers.sap.com/tags/9f13aee1-834c-4105-8e43-ee442775e5ce
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+Please use our community on https://answers.sap.com/tags/9f13aee1-834c-4105-8e43-ee442775e5ce

.github/workflows/node.js.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [10.x, 12.16.2]
+        node-version: [10.x, 12.x, 14.x]
 
     steps:
     - uses: actions/checkout@v2

.npmrc

@@ -1 +0,0 @@
-@sap:registry=https://npm.sap.com

.registry/server.js

@@ -0,0 +1,71 @@
+const { exec } = require ('child_process')
+const express = require ('express')
+const fs = require ('fs')
+const app = express()
+
+const { PORT=4444 } = process.env
+const [,,port=PORT] = process.argv
+
+app.use('/-/:tarball', (req,res,next) => {
+  const url = decodeURIComponent(req.url)
+  console.debug ('GET', req.params)
+  try {
+    const { tarball } = req.params
+    const [, pkg ] = /^capire-(\w+)/.exec(tarball)
+    fs.lstat(tarball,(err => {
+      if (err) exec(`npm pack ../${pkg}`,next)
+      else next()
+    }))
+  } catch (e) {
+    console.error(e)
+    res.sendStatus(500)
+  }
+})
+
+app.use('/-', express.static(__dirname))
+
+app.get('/*', (req,res)=>{
+  const url = decodeURIComponent(req.url)
+  console.debug ('GET',url)
+  try {
+    const [, capire, pkg ] = /^\/(@capire)\/(\w+)/.exec(url)
+    const package = require (`${capire}/${pkg}/package.json`)
+    const tarball = `capire-${pkg}-${package.version}.tgz`
+    // https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md
+    res.json({
+      "name": package.name,
+      "dist-tags": {
+        "latest": package.version
+      },
+      "versions": {
+        [package.version]: {
+          "name": package.name,
+          "version": package.version,
+          "dist": {
+            "tarball": `http://localhost:${port}/-/${tarball}`
+          },
+        }
+      },
+    })
+  } catch (e) {
+    console.error(e)
+    res.sendStatus(404)
+  }
+})
+
+app.listen(port, ()=>{
+  console.log (`npm set @capire:registry=http://localhost:${port}`)
+  console.log (`@capire registry listening on http://localhost:${port}`)
+  exec(`npm set @capire:registry=http://localhost:${port}`)
+})
+
+const _exit = ()=>{
+  console.log ('\nnpm conf rm @capire:registry')
+  exec('npm conf rm @capire:registry')
+  exec('rm *.tgz')
+  process.exit()
+}
+process.on ('SIGTERM',_exit)
+process.on ('SIGHUP',_exit)
+process.on ('SIGINT',_exit)
+process.on ('SIGUSR2',_exit)

.reuse/dep5

@@ -0,0 +1,29 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: cloud-cap-samples
+Upstream-Contact: <Christian Georgi (christian.georgi@sap.com)>
+Source: https://github.com/SAP-samples/cloud-cap-samples
+Disclaimer: The code in this project may include calls to APIs (“API Calls”) of
+ SAP or third-party products or services developed outside of this project
+ (“External Products”).
+ “APIs” means application programming interfaces, as well as their respective
+ specifications and implementing code that allows software to communicate with
+ other software.
+ API Calls to External Products are not licensed under the open source license
+ that governs this project. The use of such API Calls and related External
+ Products are subject to applicable additional agreements with the relevant
+ provider of the External Products. In no event shall the open source license
+ that governs this project grant any rights in or to any External Products,or
+ alter, expand or supersede any terms of the applicable additional agreements.
+ If you have a valid license agreement with SAP for the use of a particular SAP
+ External Product, then you may make use of any API Calls included in this
+ project’s code for that SAP External Product, subject to the terms of such
+ license agreement. If you do not have a valid license agreement for the use of
+ a particular SAP External Product, then you may only make use of any API Calls
+ in this project for that SAP External Product for your internal, non-productive
+ and non-commercial test and evaluation of such API Calls. Nothing herein grants
+ you any rights to use or access any SAP External Product, or provide any third
+ parties the right to use of access any SAP External Product, through API Calls.
+
+Files: *
+Copyright: 2019-2020 SAP SE or an SAP affiliate company and cap-cloud-samples
+License: Apache-2.0

.vscode/extensions.json

@@ -4,7 +4,7 @@
 
 	// List of extensions which should be recommended for users of this workspace.
 	"recommendations": [
-		// "CDS Editor !",
+		"SAPSE.vscode-cds",
 		"dbaeumer.vscode-eslint",
 		"esbenp.prettier-vscode",
 		"mechatroner.rainbow-csv",

.vscode/launch.json

@@ -4,26 +4,27 @@
   // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
   "version": "0.2.0",
   "configurations": [
+  {
+    "name": "Attach by Process ID",
+    "processId": "${command:PickProcess}",
+    "request": "attach",
+    "skipFiles": [
+      "<node_internals>/**"
+    ],
+    "type": "pwa-node"
+  },
     {
       "name": "bookshop",
-      "cwd": "${workspaceFolder}/bookshop",
+      "command": "cds watch bookshop",
       "request": "launch",
-      "type": "node",
+      "type": "node-terminal",
-      "runtimeExecutable": "npx",
-      "runtimeArgs": ["-n"],
-      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"],
-      "console": "integratedTerminal",
       "skipFiles": ["<node_internals>/**"]
     },
     {
-      "name": "Fiori App",
+      "name": "Fiori app",
-      "cwd": "${workspaceFolder}/fiori",
+      "command": "cds watch fiori",
       "request": "launch",
-      "type": "node",
+      "type": "node-terminal",
-      "runtimeExecutable": "npx",
-      "runtimeArgs": ["-n"],
-      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"],
-      "console": "integratedTerminal",
       "skipFiles": ["<node_internals>/**"]
     }
   ],

LICENSE

@@ -1,217 +1,208 @@
-                                  Apache License
+Apache License
-                           Version 2.0, January 2004
+
-                        http://www.apache.org/licenses/
+Version 2.0, January 2004
-
+
-   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+http://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION,
-
+AND DISTRIBUTION
-   1. Definitions.
+
-
+   1. Definitions.
-      "License" shall mean the terms and conditions for use, reproduction,
+
-      and distribution as defined by Sections 1 through 9 of this document.
+      
-
+
-      "Licensor" shall mean the copyright owner or entity authorized by
+"License" shall mean the terms and conditions for use, reproduction, and distribution
-      the copyright owner that is granting the License.
+as defined by Sections 1 through 9 of this document.
-
+
-      "Legal Entity" shall mean the union of the acting entity and all
+      
-      other entities that control, are controlled by, or are under common
+
-      control with that entity. For the purposes of this definition,
+"Licensor" shall mean the copyright owner or entity authorized by the copyright
-      "control" means (i) the power, direct or indirect, to cause the
+owner that is granting the License.
-      direction or management of such entity, whether by contract or
+
-      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      
-      outstanding shares, or (iii) beneficial ownership of such entity.
+
-
+"Legal Entity" shall mean the union of the acting entity and all other entities
-      "You" (or "Your") shall mean an individual or Legal Entity
+that control, are controlled by, or are under common control with that entity.
-      exercising permissions granted by this License.
+For the purposes of this definition, "control" means (i) the power, direct
-
+or indirect, to cause the direction or management of such entity, whether
-      "Source" form shall mean the preferred form for making modifications,
+by contract or otherwise, or (ii) ownership of fifty percent (50%) or more
-      including but not limited to software source code, documentation
+of the outstanding shares, or (iii) beneficial ownership of such entity.
-      source, and configuration files.
+
-
+      
-      "Object" form shall mean any form resulting from mechanical
+
-      transformation or translation of a Source form, including but
+"You" (or "Your") shall mean an individual or Legal Entity exercising permissions
-      not limited to compiled object code, generated documentation,
+granted by this License.
-      and conversions to other media types.
+
-
+      
-      "Work" shall mean the work of authorship, whether in Source or
+
-      Object form, made available under the License, as indicated by a
+"Source" form shall mean the preferred form for making modifications, including
-      copyright notice that is included in or attached to the work
+but not limited to software source code, documentation source, and configuration
-      (an example is provided in the Appendix below).
+files.
-
+
-      "Derivative Works" shall mean any work, whether in Source or Object
+      
-      form, that is based on (or derived from) the Work and for which the
+
-      editorial revisions, annotations, elaborations, or other modifications
+"Object" form shall mean any form resulting from mechanical transformation
-      represent, as a whole, an original work of authorship. For the purposes
+or translation of a Source form, including but not limited to compiled object
-      of this License, Derivative Works shall not include works that remain
+code, generated documentation, and conversions to other media types.
-      separable from, or merely link (or bind by name) to the interfaces of,
+
-      the Work and Derivative Works thereof.
+      
-
+
-      "Contribution" shall mean any work of authorship, including
+"Work" shall mean the work of authorship, whether in Source or Object form,
-      the original version of the Work and any modifications or additions
+made available under the License, as indicated by a copyright notice that
-      to that Work or Derivative Works thereof, that is intentionally
+is included in or attached to the work (an example is provided in the Appendix
-      submitted to Licensor for inclusion in the Work by the copyright owner
+below).
-      or by an individual or Legal Entity authorized to submit on behalf of
+
-      the copyright owner. For the purposes of this definition, "submitted"
+      
-      means any form of electronic, verbal, or written communication sent
+
-      to the Licensor or its representatives, including but not limited to
+"Derivative Works" shall mean any work, whether in Source or Object form,
-      communication on electronic mailing lists, source code control systems,
+that is based on (or derived from) the Work and for which the editorial revisions,
-      and issue tracking systems that are managed by, or on behalf of, the
+annotations, elaborations, or other modifications represent, as a whole, an
-      Licensor for the purpose of discussing and improving the Work, but
+original work of authorship. For the purposes of this License, Derivative
-      excluding communication that is conspicuously marked or otherwise
+Works shall not include works that remain separable from, or merely link (or
-      designated in writing by the copyright owner as "Not a Contribution."
+bind by name) to the interfaces of, the Work and Derivative Works thereof.
-
+
-      "Contributor" shall mean Licensor and any individual or Legal Entity
+      
-      on behalf of whom a Contribution has been received by Licensor and
+
-      subsequently incorporated within the Work.
+"Contribution" shall mean any work of authorship, including the original version
-
+of the Work and any modifications or additions to that Work or Derivative
-   2. Grant of Copyright License. Subject to the terms and conditions of
+Works thereof, that is intentionally submitted to Licensor for inclusion in
-      this License, each Contributor hereby grants to You a perpetual,
+the Work by the copyright owner or by an individual or Legal Entity authorized
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+to submit on behalf of the copyright owner. For the purposes of this definition,
-      copyright license to reproduce, prepare Derivative Works of,
+"submitted" means any form of electronic, verbal, or written communication
-      publicly display, publicly perform, sublicense, and distribute the
+sent to the Licensor or its representatives, including but not limited to
-      Work and such Derivative Works in Source or Object form.
+communication on electronic mailing lists, source code control systems, and
-
+issue tracking systems that are managed by, or on behalf of, the Licensor
-   3. Grant of Patent License. Subject to the terms and conditions of
+for the purpose of discussing and improving the Work, but excluding communication
-      this License, each Contributor hereby grants to You a perpetual,
+that is conspicuously marked or otherwise designated in writing by the copyright
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+owner as "Not a Contribution."
-      (except as stated in this section) patent license to make, have made,
+
-      use, offer to sell, sell, import, and otherwise transfer the Work,
+      
-      where such license applies only to those patent claims licensable
+
-      by such Contributor that are necessarily infringed by their
+"Contributor" shall mean Licensor and any individual or Legal Entity on behalf
-      Contribution(s) alone or by combination of their Contribution(s)
+of whom a Contribution has been received by Licensor and subsequently incorporated
-      with the Work to which such Contribution(s) was submitted. If You
+within the Work.
-      institute patent litigation against any entity (including a
+
-      cross-claim or counterclaim in a lawsuit) alleging that the Work
+2. Grant of Copyright License. Subject to the terms and conditions of this
-      or a Contribution incorporated within the Work constitutes direct
+License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive,
-      or contributory patent infringement, then any patent licenses
+no-charge, royalty-free, irrevocable copyright license to reproduce, prepare
-      granted to You under this License for that Work shall terminate
+Derivative Works of, publicly display, publicly perform, sublicense, and distribute
-      as of the date such litigation is filed.
+the Work and such Derivative Works in Source or Object form.
-
+
-   4. Redistribution. You may reproduce and distribute copies of the
+3. Grant of Patent License. Subject to the terms and conditions of this License,
-      Work or Derivative Works thereof in any medium, with or without
+each Contributor hereby grants to You a perpetual, worldwide, non-exclusive,
-      modifications, and in Source or Object form, provided that You
+no-charge, royalty-free, irrevocable (except as stated in this section) patent
-      meet the following conditions:
+license to make, have made, use, offer to sell, sell, import, and otherwise
-
+transfer the Work, where such license applies only to those patent claims
-      (a) You must give any other recipients of the Work or
+licensable by such Contributor that are necessarily infringed by their Contribution(s)
-          Derivative Works a copy of this License; and
+alone or by combination of their Contribution(s) with the Work to which such
-
+Contribution(s) was submitted. If You institute patent litigation against
-      (b) You must cause any modified files to carry prominent notices
+any entity (including a cross-claim or counterclaim in a lawsuit) alleging
-          stating that You changed the files; and
+that the Work or a Contribution incorporated within the Work constitutes direct
-
+or contributory patent infringement, then any patent licenses granted to You
-      (c) You must retain, in the Source form of any Derivative Works
+under this License for that Work shall terminate as of the date such litigation
-          that You distribute, all copyright, patent, trademark, and
+is filed.
-          attribution notices from the Source form of the Work,
+
-          excluding those notices that do not pertain to any part of
+4. Redistribution. You may reproduce and distribute copies of the Work or
-          the Derivative Works; and
+Derivative Works thereof in any medium, with or without modifications, and
-
+in Source or Object form, provided that You meet the following conditions:
-      (d) If the Work includes a "NOTICE" text file as part of its
+
-          distribution, then any Derivative Works that You distribute must
+(a) You must give any other recipients of the Work or Derivative Works a copy
-          include a readable copy of the attribution notices contained
+of this License; and
-          within such NOTICE file, excluding those notices that do not
+
-          pertain to any part of the Derivative Works, in at least one
+(b) You must cause any modified files to carry prominent notices stating that
-          of the following places: within a NOTICE text file distributed
+You changed the files; and
-          as part of the Derivative Works; within the Source form or
+
-          documentation, if provided along with the Derivative Works; or,
+(c) You must retain, in the Source form of any Derivative Works that You distribute,
-          within a display generated by the Derivative Works, if and
+all copyright, patent, trademark, and attribution notices from the Source
-          wherever such third-party notices normally appear. The contents
+form of the Work, excluding those notices that do not pertain to any part
-          of the NOTICE file are for informational purposes only and
+of the Derivative Works; and
-          do not modify the License. You may add Your own attribution
+
-          notices within Derivative Works that You distribute, alongside
+(d) If the Work includes a "NOTICE" text file as part of its distribution,
-          or as an addendum to the NOTICE text from the Work, provided
+then any Derivative Works that You distribute must include a readable copy
-          that such additional attribution notices cannot be construed
+of the attribution notices contained within such NOTICE file, excluding those
-          as modifying the License.
+notices that do not pertain to any part of the Derivative Works, in at least
-
+one of the following places: within a NOTICE text file distributed as part
-      You may add Your own copyright statement to Your modifications and
+of the Derivative Works; within the Source form or documentation, if provided
-      may provide additional or different license terms and conditions
+along with the Derivative Works; or, within a display generated by the Derivative
-      for use, reproduction, or distribution of Your modifications, or
+Works, if and wherever such third-party notices normally appear. The contents
-      for any such Derivative Works as a whole, provided Your use,
+of the NOTICE file are for informational purposes only and do not modify the
-      reproduction, and distribution of the Work otherwise complies with
+License. You may add Your own attribution notices within Derivative Works
-      the conditions stated in this License.
+that You distribute, alongside or as an addendum to the NOTICE text from the
-
+Work, provided that such additional attribution notices cannot be construed
-   5. Submission of Contributions. Unless You explicitly state otherwise,
+as modifying the License.
-      any Contribution intentionally submitted for inclusion in the Work
+
-      by You to the Licensor shall be under the terms and conditions of
+You may add Your own copyright statement to Your modifications and may provide
-      this License, without any additional terms or conditions.
+additional or different license terms and conditions for use, reproduction,
-      Notwithstanding the above, nothing herein shall supersede or modify
+or distribution of Your modifications, or for any such Derivative Works as
-      the terms of any separate license agreement you may have executed
+a whole, provided Your use, reproduction, and distribution of the Work otherwise
-      with Licensor regarding such Contributions.
+complies with the conditions stated in this License.
-
+
-   6. Trademarks. This License does not grant permission to use the trade
+5. Submission of Contributions. Unless You explicitly state otherwise, any
-      names, trademarks, service marks, or product names of the Licensor,
+Contribution intentionally submitted for inclusion in the Work by You to the
-      except as required for reasonable and customary use in describing the
+Licensor shall be under the terms and conditions of this License, without
-      origin of the Work and reproducing the content of the NOTICE file.
+any additional terms or conditions. Notwithstanding the above, nothing herein
-
+shall supersede or modify the terms of any separate license agreement you
-   7. Disclaimer of Warranty. Unless required by applicable law or
+may have executed with Licensor regarding such Contributions.
-      agreed to in writing, Licensor provides the Work (and each
+
-      Contributor provides its Contributions) on an "AS IS" BASIS,
+6. Trademarks. This License does not grant permission to use the trade names,
-      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+trademarks, service marks, or product names of the Licensor, except as required
-      implied, including, without limitation, any warranties or conditions
+for reasonable and customary use in describing the origin of the Work and
-      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+reproducing the content of the NOTICE file.
-      PARTICULAR PURPOSE. You are solely responsible for determining the
+
-      appropriateness of using or redistributing the Work and assume any
+7. Disclaimer of Warranty. Unless required by applicable law or agreed to
-      risks associated with Your exercise of permissions under this License.
+in writing, Licensor provides the Work (and each Contributor provides its
-
+Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-   8. Limitation of Liability. In no event and under no legal theory,
+KIND, either express or implied, including, without limitation, any warranties
-      whether in tort (including negligence), contract, or otherwise,
+or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR
-      unless required by applicable law (such as deliberate and grossly
+A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness
-      negligent acts) or agreed to in writing, shall any Contributor be
+of using or redistributing the Work and assume any risks associated with Your
-      liable to You for damages, including any direct, indirect, special,
+exercise of permissions under this License.
-      incidental, or consequential damages of any character arising as a
+
-      result of this License or out of the use or inability to use the
+8. Limitation of Liability. In no event and under no legal theory, whether
-      Work (including but not limited to damages for loss of goodwill,
+in tort (including negligence), contract, or otherwise, unless required by
-      work stoppage, computer failure or malfunction, or any and all
+applicable law (such as deliberate and grossly negligent acts) or agreed to
-      other commercial damages or losses), even if such Contributor
+in writing, shall any Contributor be liable to You for damages, including
-      has been advised of the possibility of such damages.
+any direct, indirect, special, incidental, or consequential damages of any
-
+character arising as a result of this License or out of the use or inability
-   9. Accepting Warranty or Additional Liability. While redistributing
+to use the Work (including but not limited to damages for loss of goodwill,
-      the Work or Derivative Works thereof, You may choose to offer,
+work stoppage, computer failure or malfunction, or any and all other commercial
-      and charge a fee for, acceptance of support, warranty, indemnity,
+damages or losses), even if such Contributor has been advised of the possibility
-      or other liability obligations and/or rights consistent with this
+of such damages.
-      License. However, in accepting such obligations, You may act only
+
-      on Your own behalf and on Your sole responsibility, not on behalf
+9. Accepting Warranty or Additional Liability. While redistributing the Work
-      of any other Contributor, and only if You agree to indemnify,
+or Derivative Works thereof, You may choose to offer, and charge a fee for,
-      defend, and hold each Contributor harmless for any liability
+acceptance of support, warranty, indemnity, or other liability obligations
-      incurred by, or claims asserted against, such Contributor by reason
+and/or rights consistent with this License. However, in accepting such obligations,
-      of your accepting any such warranty or additional liability.
+You may act only on Your own behalf and on Your sole responsibility, not on
-
+behalf of any other Contributor, and only if You agree to indemnify, defend,
-   END OF TERMS AND CONDITIONS
+and hold each Contributor harmless for any liability incurred by, or claims
-
+asserted against, such Contributor by reason of your accepting any such warranty
-   APPENDIX: How to apply the Apache License to your work.
+or additional liability. END OF TERMS AND CONDITIONS
-
+
-      To apply the Apache License to your work, attach the following
+APPENDIX: How to apply the Apache License to your work.
-      boilerplate notice, with the fields enclosed by brackets "[]"
+
-      replaced with your own identifying information. (Don't include
+To apply the Apache License to your work, attach the following boilerplate
-      the brackets!)  The text should be enclosed in the appropriate
+notice, with the fields enclosed by brackets "[]" replaced with your own identifying
-      comment syntax for the file format. We also recommend that a
+information. (Don't include the brackets!) The text should be enclosed in
-      file or class name and description of purpose be included on the
+the appropriate comment syntax for the file format. We also recommend that
-      same "printed page" as the copyright notice for easier
+a file or class name and description of purpose be included on the same "printed
-      identification within third-party archives.
+page" as the copyright notice for easier identification within third-party
-
+archives.
-   Copyright [yyyy] [name of copyright owner]
+
-
+Copyright [yyyy] [name of copyright owner]
-   Licensed under the Apache License, Version 2.0 (the "License");
+
-   you may not use this file except in compliance with the License.
+Licensed under the Apache License, Version 2.0 (the "License");
-   You may obtain a copy of the License at
+
-
+you may not use this file except in compliance with the License.
-       http://www.apache.org/licenses/LICENSE-2.0
+
-
+You may obtain a copy of the License at
-   Unless required by applicable law or agreed to in writing, software
+
-   distributed under the License is distributed on an "AS IS" BASIS,
+http://www.apache.org/licenses/LICENSE-2.0
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+
-   See the License for the specific language governing permissions and
+Unless required by applicable law or agreed to in writing, software
-   limitations under the License.
+
-
+distributed under the License is distributed on an "AS IS" BASIS,
---------------------------------------------------------------------------------------------------------------------------
+
-APIs
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-
+
-This project may include APIs to SAP or third-party products or services.
+See the License for the specific language governing permissions and
-The use of these APIs, products and services may be subject to additional
+
-agreements. In no event shall the application of the Apache Software
+limitations under the License.
-License, v.2 to this project grant any rights in or to these APIs,
-products or services that would alter, expand, be inconsistent with,
-or supersede any terms of these additional agreements. “API” means
-application programming interfaces, as well as their respective
-specifications and implementing code that allows other software
-products to communicate with or call on SAP or third party products
-or services (for example, SAP Enterprise Services, BAPIs, Idocs, RFCs
-and ABAP calls or other user exits) and may be made available through
-SAP or third party products, SDKs, documentation or other media.

README.md

@@ -3,6 +3,7 @@
 Find here a collection of samples for the [SAP Cloud Application Programming Model](https://cap.cloud.sap) organized in a simplistic [monorepo setup](samples.md#all-in-one-monorepo). → See [**Overview** of contained samples](samples.md)
 
 ![](https://github.com/SAP-samples/cloud-cap-samples/workflows/CI/badge.svg)
+[![REUSE status](https://api.reuse.software/badge/github.com/SAP-samples/cloud-cap-samples)](https://api.reuse.software/info/github.com/SAP-samples/cloud-cap-samples)
 
 ### Preliminaries
 
@@ -47,12 +48,28 @@ npx jest
 > While mocha is a bit smaller and faster, jest runs tests in parallel and isolation, which allows to run all tests.
 
 
+### Serve `npm` 
+
+We've simple npm registry mock included which allows you to do an `npm install @capire/<package>` anywhere locally. Use it as follows:
+
+1. Start the @capire registry:
+```sh
+npm run registry
+```
+> While running this will have `@capire:registry=http://localhost:4444` set with npmrc. 
+
+2. Install one of the @capire packages wherever you like, e.g.:
+```sh
+npm add @capire/common @capire/bookshop
+```
+
+
 ## Get Support
 
 Check out the documentation at [https://cap.cloud.sap](https://cap.cloud.sap). <br>
-In case you find a bug or need support, please [open an issue in here](https://github.com/SAP-samples/cloud-cap-samples/issues/new).
+In case you have a question, find a bug, or otherwise need support, please use our [community](https://answers.sap.com/tags/9f13aee1-834c-4105-8e43-ee442775e5ce).
 
 
 ## License
 
-Copyright (c) 2020 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, version 2.0 except as noted otherwise in the [LICENSE](/LICENSE) file.
+Copyright (c) 2020 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, version 2.0 except as noted otherwise in the [LICENSE](LICENSES/Apache-2.0.txt) file.

bookshop/.env

@@ -1 +0,0 @@
-cds.features.snapi = y

bookshop/app/vue/app.js

@@ -9,33 +9,36 @@ const books = new Vue ({
 
     data: {
         list: [],
-        book: { descr:'( click on a row to see details... )' },
+        book: undefined,
         order: { amount:1, succeeded:'', failed:'' }
     },
 
     methods: {
 
-        search: ({target:{value:v}}) => books.fetch (v && '$search='+v),
+        search: ({target:{value:v}}) => books.fetch(v && '&$search='+v),
 
-        async fetch (_filter='') {
+        async fetch (etc='') {
-            const columns = 'ID,title,author,price,stock', details = 'genre,currency'
+            const {data} = await GET(`/ListOfBooks?$expand=genre,currency${etc}`)
-            const {data} = await GET(`/Books?$select=${columns}&$expand=${details}&${_filter}`)
             books.list = data.value
         },
 
-        async inspect () {
+        async inspect (eve) {
-            const book = books.book = books.list [event.currentTarget.rowIndex-1]
+            const book = books.book = books.list [eve.currentTarget.rowIndex-1]
-            book.descr || await GET(`/Books/${book.ID}/descr/$value`) .then (({data}) => book.descr = data)
+            const res = await GET(`/Books/${book.ID}?$select=descr,stock,image`)
+            Object.assign (book, res.data)
             books.order = { amount:1 }
             setTimeout (()=> $('form > input').focus(), 111)
         },
 
-        submitOrder () { event.preventDefault()
+        async submitOrder () {
-            const {book,order} = books, amount = parseInt (order.amount) || 1
+            const {book,order} = books, amount = parseInt (order.amount) || 1 // REVISIT: Okra should be less strict
-            POST(`/submitOrder`, { amount, book: book.ID })
+            try {
-            .then (()=> books.order = { amount, succeeded: `Successfully orderd ${amount} item(s).` })
+                const res = await POST(`/submitOrder`, { amount, book: book.ID })
-            .catch (e=> books.order = { amount, failed: e.response.data.error.message })
+                book.stock = res.data.stock
-            GET(`/Books/${book.ID}/stock/$value`).then (res => book.stock = res.data)
+                books.order = { amount, succeeded: `Successfully orderd ${amount} item(s).` }
+            } catch (e) {
+                books.order = { amount, failed: e.response.data.error.message }
+            }
         }
 
     }

bookshop/app/vue/index.html

@@ -7,50 +7,56 @@
     <script src="https://cdn.jsdelivr.net/npm/axios/dist/axios.min.js"></script>
     <script src="https://cdn.jsdelivr.net/npm/vue"></script>
     <style>
-        #books tr:hover { background: #f2f2f2; cursor: pointer; }
+        .hovering tr:hover td { color:cyan; background: #123; cursor: pointer; }
-        form { float:right; display:flex; flex-direction: row-reverse }
+        .rating-stars { color:teal }
-        form #amount { width: 5em }
+        .succeeded { color:teal }
-        .is-success { color: #0d920d }
+        .failed { color:red }
-        .has-error { color: #df1010 }
     </style>
 </head>
 
 <body class="small-container", style="margin-top: 70px;">
 <div id='app'>
 
-    <h1> Capire Books </h1>
+    <h1> {{ document.title }} </h1>
 
     <input type="text" placeholder="Search..." @input="search">
 
-    <table id='books'>
+    <table id='books' class="hovering">
         <thead>
             <th> Book </th>
             <th> Author </th>
             <th> Genre </th>
+            <th> Rating </th>
             <th> Price </th>
         </thead>
         <tr v-for="book in list" v-bind:id="book.ID" v-on:click="inspect">
             <td>{{ book.title }}</td>
             <td>{{ book.author }}</td>
             <td>{{ book.genre.name }}</td>
+            <td class="rating-stars">
+                {{ ('★'.repeat(Math.round(book.rating))+'☆☆☆☆☆').slice(0,5) }}
+            </td>
             <td>{{ book.currency.symbol }} {{ book.price }}</td>
         </tr>
     </table>
 
-    <div v-if="book.title">
+    <div v-if="book">
+        <img v-bind:src="book.image" alt=""/>
         <label style="text-align:right">
-            <span class="is-success"> {{ order.succeeded }} </span>
+            <span class="succeeded"> {{ order.succeeded }} </span>
-            <span class="has-error"> {{ order.failed }} </span>
+            <span class="failed"> {{ order.failed }} </span>
             &nbsp;&nbsp; {{ book.stock }} in stock
         </label>
-        <form @submit="submitOrder">
+        <form @submit.prevent="submitOrder" style="float:right; display:flex; flex-direction:row-reverse">
-            <input type="number" id="amount" v-model="order.amount" v-bind:class="{ 'has-error': order.failed }">
+            <input type="number" v-model="order.amount" v-bind:class="{ failed: order.failed }" style="width:5em">
             <input type="submit" value="Order:" class="muted-button">
         </form>
+        <h4> {{ book.title }} </h4>
+        <p> {{ book.descr }} </p>
+    </div>
+    <div v-else>
+        ( click on a row to see details... )
     </div>
-
-    <h4> {{ book.title }} </h4>
-    <p> {{ book.descr }} </p>
 
 </div>
 </body>

bookshop/db/data/sap.capire.bookshop-Genres.csv

@@ -11,6 +11,6 @@ ID;parent_ID;name
 19;10;Fairy Tale
 20;;Non-Fiction
 21;20;Biography
-22;20;Autobiography
+22;21;Autobiography
 23;20;Essay
 24;20;Speech

bookshop/db/schema.cds

@@ -8,8 +8,9 @@ entity Books : managed {
   author : Association to Authors;
   genre  : Association to Genres;
   stock  : Integer;
-  price  : Decimal(9,2);
+  price  : Decimal;
   currency : Currency;
+  image : LargeBinary @Core.MediaType : 'image/png';
 }
 
 entity Authors : managed {

bookshop/package.json

@@ -3,9 +3,10 @@
   "version": "1.0.0",
   "description": "A simple self-contained bookshop service.",
   "dependencies": {
-    "@capire/common": "../common",
+    "@capire/common": "*",
-    "@sap/cds": ">=3.33.1",
+    "@sap/cds": "^4",
-    "express": "^4.17.1"
+    "express": "^4.17.1",
+    "passport": "0.4.1"
   },
   "scripts": {
     "genres": "cds serve test/genres.cds",

bookshop/srv/admin-service.cds

@@ -1,5 +1,5 @@
 using { sap.capire.bookshop as my } from '../db/schema';
-service AdminService @(requires_:'admin') {
+service AdminService @(requires:'admin') {
   entity Books as projection on my.Books;
   entity Authors as projection on my.Authors;
 }

bookshop/srv/admin-service.js

@@ -0,0 +1,12 @@
+const cds = require('@sap/cds')
+
+module.exports = cds.service.impl (function(){
+  this.before ('NEW','Authors', genid)
+  this.before ('NEW','Books', genid)
+})
+
+/** Generate primary keys for target entity in request */
+async function genid (req) {
+  const {ID} = await cds.tx(req).run (SELECT.one.from(req.target).columns('max(ID) as ID'))
+  req.data.ID = ID - ID % 100 + 100 + 1
+}

bookshop/srv/cat-service.cds

@@ -5,6 +5,10 @@ service CatalogService @(path:'/browse') {
     author.name as author
   } excluding { createdBy, modifiedBy };
 
-  @requires_: 'authenticated-user'
+  @readonly entity ListOfBooks as SELECT from Books
-  action submitOrder (book : Books.ID, amount: Integer);
+  excluding { descr, stock };
+
+  @requires: 'authenticated-user'
+  action submitOrder ( book: Books:ID, amount: Integer ) returns { stock: Integer };
+  event OrderedBook : { book: Books:ID; amount: Integer; buyer: String };
 }

bookshop/srv/cat-service.js

@@ -1,20 +1,28 @@
 const cds = require('@sap/cds')
-module.exports = async function (){
+const { Books } = cds.entities ('sap.capire.bookshop')
 
-  const db = await cds.connect.to('db') // connect to database service
+class CatalogService extends cds.ApplicationService { async init(){
-  const { Books } = db.entities         // get reflected definitions
 
   // Reduce stock of ordered books if available stock suffices
   this.on ('submitOrder', async req => {
-    const {book,amount} = req.data
+    const {book,amount} = req.data, tx = cds.tx(req)
-    const n = await UPDATE (Books, book)
+    let {stock} = await tx.read('stock').from(Books,book)
-      .with ({ stock: {'-=': amount }})
+    if (stock >= amount) {
-      .where ({ stock: {'>=': amount }})
+      await tx.update (Books,book).with ({ stock: stock -= amount })
-    n > 0 || req.error (409,`${amount} exceeds stock for book #${book}`)
+      this.emit ('OrderedBook', { book, amount, buyer:req.user.id })
+      return { stock }
+    }
+    else return req.error (409,`${amount} exceeds stock for book #${book}`)
   })
 
   // Add some discount for overstocked books
   this.after ('READ','Books', each => {
-    if (each.stock > 111)  each.title += ` -- 11% discount!`
+    if (each.stock > 111) {
+      each.title += ` -- 11% discount!`
+    }
   })
-}
+
+  return super.init()
+}}
+
+module.exports = { CatalogService }

bookshop/test/requests.http

@@ -32,6 +32,37 @@ GET {{server}}/admin/Authors?
   # &sap-language=de
 Authorization: Basic alice:
 
+### ------------------------------------------------------------------------
+# Create book
+POST {{server}}/admin/Books
+Content-Type: application/json;IEEE754Compatible=true
+Authorization: Basic alice:
+
+{
+  "ID": 2,
+  "title": "Poems : Pocket Poets",
+  "descr": "The Everyman's Library Pocket Poets hardcover series is popular for its compact size and reasonable price which does not compromise content. Poems: Bronte contains poems that demonstrate a sensibility elemental in its force with an imaginative discipline and flexibility of the highest order. Also included are an Editor's Note and an index of first lines.",
+  "author": { "ID": 101 },
+  "genre": { "ID": 12 },
+  "stock": 5,
+  "price": "12.05",
+  "currency": { "code": "USD" }
+}
+
+
+### ------------------------------------------------------------------------
+# Put image to books
+PUT {{server}}/admin/Books(2)/image
+Content-Type: image/png
+Authorization: Basic alice:
+
+data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAANwAAADcCAYAAAAbWs+BAAAGwElEQVR4Ae3cwZFbNxBFUY5rkrDTmKAUk5QT03Aa44U22KC7NHptw+DRikVAXf8fzC3u8Hj4R4AAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAgZzAW26USQT+e4HPx+Mz+RRvj0e0kT+SD2cWAQK1gOBqH6sEogKCi3IaRqAWEFztY5VAVEBwUU7DCNQCgqt9rBKICgguymkYgVpAcLWPVQJRAcFFOQ0jUAsIrvaxSiAqILgop2EEagHB1T5WCUQFBBflNIxALSC42scqgaiA4KKchhGoBQRX+1glEBUQXJTTMAK1gOBqH6sEogKCi3IaRqAWeK+Xb1z9iN558fHxcSPS9p2ezx/ROz4e4TtIHt+3j/61hW9f+2+7/+UXbifjewIDAoIbQDWSwE5AcDsZ3xMYEBDcAKqRBHYCgtvJ+J7AgIDgBlCNJLATENxOxvcEBgQEN4BqJIGdgOB2Mr4nMCAguAFUIwnsBAS3k/E9gQEBwQ2gGklgJyC4nYzvCQwICG4A1UgCOwHB7WR8T2BAQHADqEYS2AkIbifjewIDAoIbQDWSwE5AcDsZ3xMYEEjfTzHwiK91B8npd6Q8n8/oGQ/ckRJ9vvQwv3BpUfMIFAKCK3AsEUgLCC4tah6BQkBwBY4lAmkBwaVFzSNQCAiuwLFEIC0guLSoeQQKAcEVOJYIpAUElxY1j0AhILgCxxKBtIDg0qLmESgEBFfgWCKQFhBcWtQ8AoWA4AocSwTSAoJLi5pHoBAQXIFjiUBaQHBpUfMIFAKCK3AsEUgLCC4tah6BQmDgTpPsHSTFs39p6fQ7Q770UsV/Ov19X+2OFL9wxR+rJQJpAcGlRc0jUAgIrsCxRCAtILi0qHkECgHBFTiWCKQFBJcWNY9AISC4AscSgbSA4NKi5hEoBARX4FgikBYQXFrUPAKFgOAKHEsE0gKCS4uaR6AQEFyBY4lAWkBwaVHzCBQCgitwLBFICwguLWoegUJAcAWOJQJpAcGlRc0jUAgIrsCxRCAt8J4eePq89B0ar3ZnyOnve/rfn1+400/I810lILirjtPLnC4guNNPyPNdJSC4q47Ty5wuILjTT8jzXSUguKuO08ucLiC400/I810lILirjtPLnC4guNNPyPNdJSC4q47Ty5wuILjTT8jzXSUguKuO08ucLiC400/I810lILirjtPLnC4guNNPyPNdJSC4q47Ty5wuILjTT8jzXSUguKuO08ucLiC400/I810l8JZ/m78+szP/zI47fJo7Q37vgJ7PHwN/07/3TOv/9gu3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhAcMPAxhNYBQS3avhMYFhg4P6H9J0maYHXuiMlrXf+vOfA33Turf3C5SxNItAKCK4lsoFATkBwOUuTCLQCgmuJbCCQExBcztIkAq2A4FoiGwjkBASXszSJQCsguJbIBgI5AcHlLE0i0AoIriWygUBOQHA5S5MItAKCa4lsIJATEFzO0iQCrYDgWiIbCOQEBJezNIlAKyC4lsgGAjkBweUsTSLQCgiuJbKBQE5AcDlLkwi0Akff//Dz6U+/I6U1/sUNr3bnytl3kPzi4bXb/cK1RDYQyAkILmdpEoFWQHAtkQ0EcgKCy1maRKAVEFxLZAOBnIDgcpYmEWgFBNcS2UAgJyC4nKVJBFoBwbVENhDICQguZ2kSgVZAcC2RDQRyAoLLWZpEoBUQXEtkA4GcgOByliYRaAUE1xLZQCAnILicpUkEWgHBtUQ2EMgJCC5naRKBVkBwLZENBHIC/4M7TXIv+3PS22d24qvdQfL3C/7N5P5i/MLlLE0i0AoIriWygUBOQHA5S5MItAKCa4lsIJATEFzO0iQCrYDgWiIbCOQEBJezNIlAKyC4lsgGAjkBweUsTSLQCgiuJbKBQE5AcDlLkwi0AoJriWwgkBMQXM7SJAKtgOBaIhsI5AQEl7M0iUArILiWyAYCOQHB5SxNItAKCK4lsoFATkBwOUuTCBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIAAAQIECBAgQIDAvyrwDySEJ2VQgUSoAAAAAElFTkSuQmCC
+
+
+### ------------------------------------------------------------------------
+# Reading image from from the server directly
+GET {{server}}/browse/Books(2)/image
+
 
 ### ------------------------------------------------------------------------
 # Submit Order as authenticated user

common/data/sap.common-Currencies.csv

@@ -2,7 +2,7 @@ code;symbol;name;descr;numcode;minor;exponent
 EUR;€;Euro;European Euro;978;Cent;2
 USD;$;US Dollar;United States Dollar;840;Cent;2
 CAD;$;Canadian Dollar;Canadian Dollar;124;Cent;2
-AUD;$;Australian Dollar;Canadian Dollar;036;Cent;2
+AUD;$;Australian Dollar;Australian Dollar;036;Cent;2
 GBP;£;British Pound;Great Britain Pound;826;Penny;2
 ILS;₪;Shekel;Israeli New Shekel;376;Agorat;2
 INR;₹;Rupee;Indian Rupee;356;Paise;2

fiori/.env

@@ -1 +1,2 @@
-cds.features.snapi = y
+# cds.requires.messaging.kind = file-based-messaging
+PORT = 4004

fiori/app/_i18n/i18n.properties

@@ -7,7 +7,19 @@ AuthorID = Author ID
 Stock = Stock
 Name = Name
 AuthorName = Author's Name
+DateOfBirth = Date of Birth
+DateOfDeath = Date of Death
+PlaceOfBirth = Place of Birth
+PlaceOfDeath = Place of Death
 Authors = Authors
 Order = Order
 Orders = Orders
 Price = Price
+
+Genre = Genre
+Genres = Genres
+SubGenres = Sub Genres
+
+NumCode = Numeric Code
+MinorUnit = Minor Unit
+Exponent = Exponent

fiori/app/admin-fiori.html

@@ -28,7 +28,7 @@
 					navigationMode: "embedded"
 				},
 				"manage-orders": {
-					title: "Order Books",
+					title: "Manage Orders",
 					description: "... testing FE v42",
 					additionalInformation: "SAPUI5.Component=orders",
 					applicationType : "URL",
@@ -39,8 +39,9 @@
 		};
 	</script>
 
-	<script src="https://sapui5.hana.ondemand.com/test-resources/sap/ushell/bootstrap/sandbox.js"></script>
+	<script id="sap-ushell-bootstrap" src="https://sapui5.hana.ondemand.com/test-resources/sap/ushell/bootstrap/sandbox.js"></script>
-	<script src="https://sapui5.hana.ondemand.com/resources/sap-ui-core.js"
+	<!-- <script id="sap-ui-bootstrap" src="https://sapui5.hana.ondemand.com/resources/sap-ui-core.js" -->
+	<script id="sap-ui-bootstrap" src="https://sapui5.hana.ondemand.com/1.78.6/resources/sap-ui-core.js"
     	data-sap-ui-libs="sap.m, sap.ushell, sap.collaboration, sap.ui.layout"
     	data-sap-ui-compatVersion="edge"
     	data-sap-ui-theme="sap_fiori_3"

fiori/app/admin/webapp/Component.js

@@ -1,5 +1,8 @@
-sap.ui.define(["sap/fe/core/AppComponent"], ac => ac.extend("admin.Component", {
+sap.ui.define(["sap/fe/core/AppComponent"], function(AppComponent) {
-    metadata:{ manifest:'json' }
+	"use strict";
-}))
+	return AppComponent.extend("admin.Component", {
+		metadata: { manifest: "json" }
+	});
+});
 
 /* eslint no-undef:0 */

fiori/app/admin/webapp/manifest.json

@@ -24,7 +24,7 @@
     "sap.ui5": {
         "dependencies": {
             "libs": {
-                "sap.fe": {}
+                "sap.fe.templates": {}
             }
         },
         "models": {

fiori/app/bookshop.html

@@ -0,0 +1,3 @@
+<head>
+  <meta http-equiv="refresh" content="0;url=vue/bookshop/index.html">
+</head>

fiori/app/browse/fiori-service.cds

@@ -7,6 +7,8 @@ using CatalogService from '@capire/bookshop';
 annotate CatalogService.Books with @(
 	UI: {
   	HeaderInfo: {
+			TypeName: 'Book',
+			TypeNamePlural: 'Books',
   		Description: {Value: author}
   	},
 		HeaderFacets: [

fiori/app/browse/webapp/Component.js

@@ -1,5 +1,7 @@
-sap.ui.define(["sap/fe/core/AppComponent"], ac => ac.extend("bookshop.Component", {
+sap.ui.define(["sap/fe/core/AppComponent"], function(AppComponent) {
-    metadata:{ manifest:'json' }
+	"use strict";
-}))
+	return AppComponent.extend("bookshop.Component", {
-
+		metadata: { manifest: "json" }
+	});
+});
 /* eslint no-undef:0 */

fiori/app/browse/webapp/manifest.json

@@ -24,7 +24,7 @@
   "sap.ui5": {
     "dependencies": {
       "libs": {
-        "sap.fe": {}
+        "sap.fe.templates": {}
       }
     },
     "models": {

fiori/app/common.cds

@@ -1,9 +1,9 @@
 /*
-  Common Annotations shared by all apps
+	Common Annotations shared by all apps
 */
 
 using { sap.capire.bookshop as my } from '@capire/bookshop';
-
+using { sap.common } from '@capire/common';
 
 ////////////////////////////////////////////////////////////////////////////
 //
@@ -13,7 +13,7 @@ annotate my.Books with @(
 	Common.SemanticKey: [title],
 	UI: {
 		Identification: [{Value:title}],
-	  SelectionFields: [ ID, author_ID, price, currency_code ],
+		SelectionFields: [ ID, author_ID, price, currency_code ],
 		LineItem: [
 			{Value: ID},
 			{Value: title},
@@ -28,25 +28,18 @@ annotate my.Books with @(
 	author @ValueList.entity:'Authors';
 };
 
-annotate my.Authors with @(
-	UI: {
-		Identification: [{Value:name}],
-	}
-);
-
-
 ////////////////////////////////////////////////////////////////////////////
 //
 //	Books Details
 //
 annotate my.Books with @(
 	UI: {
-  	HeaderInfo: {
+		HeaderInfo: {
-  		TypeName: '{i18n>Book}',
+			TypeName: '{i18n>Book}',
-  		TypeNamePlural: '{i18n>Books}',
+			TypeNamePlural: '{i18n>Books}',
-  		Title: {Value: title},
+			Title: {Value: title},
-  		Description: {Value: author.name}
+			Description: {Value: author.name}
-  	},
+		},
 	}
 );
 
@@ -66,15 +59,199 @@ annotate my.Books with {
 	descr @UI.MultiLineText;
 }
 
+////////////////////////////////////////////////////////////////////////////
+//
+//	Genres List
+//
+annotate my.Genres with @(
+	Common.SemanticKey: [name],
+	UI: {
+		SelectionFields: [ name ],
+		LineItem:[
+			{Value: name},
+			{Value: parent.name, Label: 'Main Genre'},
+		],
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Genre Details
+//
+annotate my.Genres with @(
+	UI: {
+		Identification: [{Value:name}],
+		HeaderInfo: {
+			TypeName: '{i18n>Genre}',
+			TypeNamePlural: '{i18n>Genres}',
+			Title: {Value: name},
+			Description: {Value: ID}
+		},
+		Facets: [
+			{$Type: 'UI.ReferenceFacet', Label: '{i18n>SubGenres}', Target: 'children/@UI.LineItem'},
+		],
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Genres Elements
+//
 annotate my.Genres with {
-  name  @title: '{i18n>Genre}';
+	ID  @title: '{i18n>ID}';
+	name  @title: '{i18n>Genre}';
 }
 
+////////////////////////////////////////////////////////////////////////////
+//
+//	Authors List
+//
+annotate my.Authors with @(
+	Common.SemanticKey: [name],
+	UI: {
+		Identification: [{Value:name}],
+		SelectionFields: [ name ],
+		LineItem:[
+			{Value: ID},
+			{Value: name},
+			{Value: dateOfBirth},
+			{Value: dateOfDeath},
+			{Value: placeOfBirth},
+			{Value: placeOfDeath},
+		],
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Author Details
+//
+annotate my.Authors with @(
+	UI: {
+		HeaderInfo: {
+			TypeName: '{i18n>Author}',
+			TypeNamePlural: '{i18n>Authors}',
+			Title: {Value: name},
+			Description: {Value: dateOfBirth}
+		},
+		Facets: [
+			{$Type: 'UI.ReferenceFacet', Target: 'books/@UI.LineItem'},
+		],
+	}
+);
+
+
 ////////////////////////////////////////////////////////////////////////////
 //
 //	Authors Elements
 //
 annotate my.Authors with {
 	ID @title:'{i18n>ID}' @UI.HiddenFilter;
-	name @title:'{i18n>AuthorName}';
+	name @title:'{i18n>Name}';
+	dateOfBirth @title:'{i18n>DateOfBirth}';
+	dateOfDeath @title:'{i18n>DateOfDeath}';
+	placeOfBirth @title:'{i18n>PlaceOfBirth}';
+	placeOfDeath @title:'{i18n>PlaceOfDeath}';
+}
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Languages List
+//
+annotate common.Languages with @(
+	Common.SemanticKey: [code],
+	Identification: [{Value:code}],
+	UI: {
+		SelectionFields: [ name, descr ],
+		LineItem:[
+			{Value: code},
+			{Value: name},
+		],
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Language Details
+//
+annotate common.Languages with @(
+	UI: {
+		HeaderInfo: {
+			TypeName: '{i18n>Language}',
+			TypeNamePlural: '{i18n>Languages}',
+			Title: {Value: name},
+			Description: {Value: descr}
+		},
+		Facets: [
+			{$Type: 'UI.ReferenceFacet', Label: '{i18n>Details}', Target: '@UI.FieldGroup#Details'},
+		],
+		FieldGroup#Details: {
+			Data: [
+				{Value: code},
+				{Value: name},
+				{Value: descr}
+			]
+		},
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Currencies List
+//
+annotate common.Currencies with @(
+	Common.SemanticKey: [code],
+	Identification: [{Value:code}],
+	UI: {
+		SelectionFields: [ name, descr ],
+		LineItem:[
+			{Value: descr},
+			{Value: symbol},
+			{Value: code},
+		],
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Currency Details
+//
+annotate common.Currencies with @(
+	UI: {
+		HeaderInfo: {
+			TypeName: '{i18n>Currency}',
+			TypeNamePlural: '{i18n>Currencies}',
+			Title: {Value: descr},
+			Description: {Value: code}
+		},
+		Facets: [
+			{$Type: 'UI.ReferenceFacet', Label: '{i18n>Details}', Target: '@UI.FieldGroup#Details'},
+			{$Type: 'UI.ReferenceFacet', Label: '{i18n>Extended}', Target: '@UI.FieldGroup#Extended'},
+		],
+		FieldGroup#Details: {
+			Data: [
+				{Value: name},
+				{Value: symbol},
+				{Value: code},
+				{Value: descr}
+			]
+		},
+		FieldGroup#Extended: {
+			Data: [
+				{Value: numcode},
+				{Value: minor},
+				{Value: exponent}
+			]
+		},
+	}
+);
+
+////////////////////////////////////////////////////////////////////////////
+//
+//	Currencies Elements
+//
+annotate common.Currencies with {
+	numcode @title:'{i18n>NumCode}';
+	minor @title:'{i18n>MinorUnit}';
+	exponent @title:'{i18n>Exponent}';
 }

fiori/app/index.cds

@@ -4,7 +4,9 @@
 
 using from './admin/fiori-service';
 using from './browse/fiori-service';
-using from './orders/fiori-service';
 using from './common';
 
 using from '@capire/common';
+
+// only works in case of embedded orders service
+using from '@capire/orders/app/orders/fiori-service';

fiori/app/orders/webapp/Component.js

@@ -1,5 +0,0 @@
-sap.ui.define(["sap/fe/core/AppComponent"], ac => ac.extend("orders.Component", {
-    metadata:{ manifest:'json' }
-}))
-
-/* eslint no-undef:0 */

fiori/app/reviews.html

@@ -0,0 +1,3 @@
+<head>
+  <meta http-equiv="refresh" content="0;url=vue/reviews/index.html">
+</head>

fiori/db/schema.cds

@@ -1,3 +0,0 @@
-// Proxy for importing schema from bookshop sample
-using from '@capire/bookshop';
-namespace sap.capire.bookshop;

fiori/package.json

@@ -2,11 +2,13 @@
   "name": "@capire/fiori",
   "version": "1.0.0",
   "dependencies": {
-    "@capire/bookshop": "../bookshop",
+    "@capire/bookshop": "*",
-    "@capire/orders": "../orders",
+    "@capire/reviews": "*",
-    "@capire/common": "../common",
+    "@capire/orders": "*",
-    "@sap/cds": ">=3.33.1",
+    "@capire/common": "*",
-    "express": "^4.17.1"
+    "@sap/cds": "^4",
+    "express": "^4.17.1",
+    "passport": "0.4.1"
   },
   "scripts": {
     "start": "cds run --in-memory?",
@@ -14,6 +16,12 @@
   },
   "cds": {
     "requires": {
+      "ReviewsService": {
+        "kind": "odata", "model": "@capire/reviews"
+      },
+      "OrdersService": {
+        "kind": "odata", "model": "@capire/orders"
+      },
       "db": {
         "kind": "sql"
       }

fiori/server.js

@@ -0,0 +1,19 @@
+const express = require ('express')
+const cds = require ('@sap/cds')
+
+cds.once('bootstrap',(app)=>{
+  const {dirname} = require ('path')
+  // serving the orders app imported from @capire/orders
+  const orders_app = dirname (require.resolve('@capire/orders/app/orders/webapp/manifest.json'))
+  app.use ('/orders/webapp', express.static(orders_app))
+  // serving the vue.js app imported from @capire/bookshop
+  const bookshop_app = dirname (require.resolve('@capire/bookshop/app/vue/index.html'))
+  app.use ('/vue/bookshop', express.static(bookshop_app))
+  // serving the vue.js app imported from @capire/reviews
+  const reviews_app = dirname (require.resolve('@capire/reviews/app/vue/index.html'))
+  app.use ('/vue/reviews', express.static(reviews_app))
+})
+
+cds.once('served', require('./srv/mashup'))
+
+module.exports = cds.server

fiori/srv/admin-service.cds

@@ -1,3 +0,0 @@
-// Proxy for importing services from bookshop sample
-using from '@capire/bookshop';
-annotate AdminService with @impl:'srv/admin-service.js';

fiori/srv/admin-service.js

@@ -1,8 +0,0 @@
-const cds = require('@sap/cds')
-
-module.exports = cds.service.impl (async function() {
-  const {Books} = cds.entities
-  const {ID} = await SELECT.one.from(Books).columns('max(ID) as ID')
-  let newID = ID - ID % 100 + 100
-  this.before ('NEW','Books', req => req.data.ID = ++newID)
-})

fiori/srv/mashup.cds

@@ -0,0 +1,25 @@
+////////////////////////////////////////////////////////////////////////////
+//
+//    Mashing up imported models...
+//
+
+using { sap.capire.bookshop.Books } from '@capire/bookshop';
+
+//
+//  Extend Books with access to Reviews and average ratings
+//
+
+using { ReviewsService.Reviews } from '@capire/reviews';
+extend Books with {
+  reviews : Composition of many Reviews on reviews.subject = $self.ID;
+  rating  : Decimal;
+}
+
+//
+//  Extend Orders with Books as Products
+//
+
+using { sap.capire.orders.Orders_Items } from '@capire/orders';
+extend Orders_Items with {
+  book : Association to Books on product.ID = book.ID
+}

fiori/srv/mashup.js

@@ -0,0 +1,59 @@
+////////////////////////////////////////////////////////////////////////////
+//
+//    Mashing up provided and required services...
+//
+module.exports = async()=>{ // called by server.js
+
+  const cds = require('@sap/cds')
+  const CatalogService = await cds.connect.to ('CatalogService')
+  const ReviewsService = await cds.connect.to ('ReviewsService')
+  const OrdersService = await cds.connect.to ('OrdersService')
+  const db = await cds.connect.to ('db')
+
+  // reflect entity definitions used below...
+  const { Books } = db.entities ('sap.capire.bookshop')
+
+  //
+  // Delegate requests to read reviews to the ReviewsService
+  // Note: prepend is neccessary to intercept generic default handler
+  //
+  CatalogService.prepend (srv => srv.on ('READ', 'Books/reviews', (req) => {
+    console.debug ('> delegating request to ReviewsService')
+    const [id] = req.params, { columns, limit } = req.query.SELECT
+    return ReviewsService.tx(req).read ('Reviews',columns).limit(limit).where({subject:String(id)})
+  }))
+
+  //
+  // Create an order with the OrdersService when CatalogService signals a new order
+  //
+  CatalogService.on ('OrderedBook', async (msg) => {
+    const { book, amount, buyer } = msg.data
+    const { title, price } = await db.tx(msg).read (Books, book, b => { b.title, b.price })
+    return OrdersService.tx(msg).create ('Orders').entries({
+      OrderNo: 'Order at '+ (new Date).toLocaleString(),
+      Items: [{ product:{ID:`${book}`}, title, price, amount }],
+      buyer, createdBy: buyer
+    })
+  })
+
+  //
+  // Update Books' average ratings when ReviewsService signals updatd reviews
+  //
+  ReviewsService.on ('reviewed', (msg) => {
+    console.debug ('> received:', msg.event, msg.data)
+    const { subject, rating } = msg.data
+    return UPDATE(Books,subject).with({rating})
+    // ^ Note: the framework will execute this and take care for db.tx
+  })
+
+  //
+  // Reduce stock of ordered books for orders are created from Orders admin UI
+  //
+  OrdersService.on ('OrderChanged', async (msg) => {
+    console.debug ('> received:', msg.event, msg.data)
+    const { product, deltaAmount } = msg.data
+    return UPDATE (Books) .where ('ID =', product)
+    .and ('stock >=', deltaAmount)
+    .set ('stock -=', deltaAmount)
+  })
+}

fiori/test/requests.http

@@ -0,0 +1,48 @@
+
+@bookshop = http://localhost:4004
+@reviews-service = {{bookshop}}/reviews
+# Uncomment this when running a separate reviews service
+@reviews-service = http://localhost:4005/reviews
+
+
+
+#################################################
+#
+#   Reviews Service
+#
+
+GET {{reviews-service}}/Reviews
+
+###
+
+POST {{reviews-service}}/Reviews
+Authorization: Basic {{$processEnv USER}}:
+Content-Type: application/json
+
+{"subject":"201", "title":"boo", "rating":3 }
+
+
+
+#################################################
+#
+#   Bookshop Services
+#
+
+GET {{bookshop}}/browse/Books/201/reviews?
+&$select=rating,date,title
+&$top=3
+
+###
+
+GET {{bookshop}}/browse/Books(201)?
+&$select=ID,title,rating
+&$expand=reviews
+
+
+
+#################################################
+#
+#   Orders Service
+#
+
+GET {{bookshop}}/orders/Orders

media/test/media.http

@@ -0,0 +1,35 @@
+### Requires REST Client for VS Code
+### https://marketplace.visualstudio.com/items?itemName=humao.rest-client
+###
+@protocol = http
+@host = localhost
+@port = 4004
+### Read Pictures
+GET {{protocol}}://{{host}}:{{port}}/media-server/Media
+Authorization: Basic admin:
+
+### Create Picture with mediatype
+POST {{protocol}}://{{host}}:{{port}}/media-server/Media
+Authorization: Basic admin:
+Accept: application/json
+Content-Type: application/json
+
+{ 
+  "id": 1,
+  "mediaType": "image/png" 
+}
+
+### Upload Binary PNG
+PUT {{protocol}}://{{host}}:{{port}}/media-server/Media(1)/content
+Authorization: Basic admin:
+Content-Type: image/png
+
+< ./Test.png
+
+### Read Binary
+GET {{protocol}}://{{host}}:{{port}}/media-server/Media(1)/content
+Authorization: Basic admin:
+
+### Delete Image
+DELETE {{protocol}}://{{host}}:{{port}}/media-server/Media(1)
+Authorization: Basic admin:

orders/.env

@@ -1,8 +1,2 @@
-cds.features.snapi = true
+cds.requires.messaging.kind = file-based-messaging
-cds.odata.version = v4
+PORT = 4006
-cds.odata.containment = true
-cds.odata.proxies = true
-cds.odata.format = structured
-cds.cdsc.beta.uniqueconstraints = true
-cds.cdsc.beta.aspectCompositions = true
-cds.cdsc.severities.unexpected-key = info

orders/app/fiori-app.html

@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<head>
+
+	<meta http-equiv="X-UA-Compatible" content="IE=edge" />
+	<meta http-equiv="Content-Type" content="text/html;charset=UTF-8" />
+	<meta name="viewport" content="width=device-width, initial-scale=1.0" />
+	<title>Bookshop</title>
+
+	<script>
+		window["sap-ushell-config"] = {
+			defaultRenderer: "fiori2",
+			applications: {
+				"manage-orders": {
+					title: "Manage Orders",
+					description: "... testing FE v42",
+					additionalInformation: "SAPUI5.Component=orders",
+					applicationType : "URL",
+					url: "/orders/webapp",
+					navigationMode: "embedded"
+				}
+			}
+		};
+	</script>
+
+	<script id="sap-ushell-bootstrap" src="https://sapui5.hana.ondemand.com/test-resources/sap/ushell/bootstrap/sandbox.js"></script>
+	<script id="sap-ui-bootstrap" src="https://sapui5.hana.ondemand.com/resources/sap-ui-core.js"
+    	data-sap-ui-libs="sap.m, sap.ushell, sap.collaboration, sap.ui.layout"
+    	data-sap-ui-compatVersion="edge"
+    	data-sap-ui-theme="sap_fiori_3"
+    	data-sap-ui-frameOptions="allow"
+	></script>
+	<script>
+		sap.ui.getCore().attachInit(()=> sap.ushell.Container.createRenderer().placeAt("content"))
+	</script>
+
+</head>
+<body class="sapUiBody" id="content"></body>
+</html>

orders/app/index.cds

@@ -0,0 +1,5 @@
+/*
+  This model controls what gets served to Fiori frontends...
+*/
+
+using from './orders/fiori-service';

orders/app/orders/fiori-service.cds

@@ -1,44 +1,27 @@
-using OrdersService from '@capire/orders/srv/orders-service';
-
-annotate OrdersService.Books with {
-	price @Common.FieldControl: #ReadOnly;
-}
 
 
 ////////////////////////////////////////////////////////////////////////////
 //
-//	Common
+//	Note: this is designed for the OrdersService being co-located with
+//	bookshop. It does not work if OrdersService is run as a separate
+// 	process, and is not intended to do so.
 //
-annotate OrdersService.OrderItems with {
+////////////////////////////////////////////////////////////////////////////
-	book @(
+
-		Common: {
+
-			Text: book.title,
+
-			FieldControl: #Mandatory
+using { OrdersService } from '../../srv/orders-service';
-		},
-		ValueList.entity:'Books',
-	);
-	amount @(
-		Common.FieldControl: #Mandatory
-	);
-}
 
 
 @odata.draft.enabled
 annotate OrdersService.Orders with @(
 	UI: {
-		////////////////////////////////////////////////////////////////////////////
-		//
-		//	Lists of Orders
-		//
 		SelectionFields: [ createdAt, createdBy ],
 		LineItem: [
-			{Value: createdBy, Label:'Customer'},
+			{Value: OrderNo, Label:'OrderNo'},
+			{Value: buyer, Label:'Customer'},
 			{Value: createdAt, Label:'Date'}
 		],
-		////////////////////////////////////////////////////////////////////////////
-		//
-		//	Order Details
-		//
 		HeaderInfo: {
 			TypeName: 'Order', TypeNamePlural: 'Orders',
 			Title: {
@@ -62,7 +45,7 @@ annotate OrdersService.Orders with @(
 		],
 		FieldGroup#Details: {
 			Data: [
-				{Value: currency_code, Label:'Currency'}
+				{Value: currency.code, Label:'Currency'}
 			]
 		},
 		FieldGroup#Created: {
@@ -85,36 +68,25 @@ annotate OrdersService.Orders with @(
 
 
 
-//The enity types name is OrdersService.my_bookshop_OrderItems
+annotate OrdersService.Orders_Items with @(
-//The annotations below are not generated in edmx WHY?
-annotate OrdersService.OrderItems with @(
 	UI: {
-		HeaderInfo: {
-			TypeName: 'Order Item', TypeNamePlural: '	',
-			Title: {
-				Value: book.title
-			},
-			Description: {Value: book.descr}
-		},
-		// There is no filterbar for items so the selctionfileds is not needed
-		SelectionFields: [ book_ID ],
-		////////////////////////////////////////////////////////////////////////////
-		//
-		//	Lists of OrderItems
-		//
 		LineItem: [
-			{Value: book_ID, Label:'Book'},
+			{Value: product_ID, Label:'Product ID'},
-			//The following entry is only used to have the assoication followed in the read event
+			{Value: title, Label:'Product Title'},
-			{Value: book.price, Label:'Book Price'},
+			{Value: price, Label:'Unit Price'},
 			{Value: amount, Label:'Quantity'},
 		],
 		Identification: [ //Is the main field group
-			//{Value: ID, Label:'ID'}, //A guid shouldn't be on the UI
-			{Value: book_ID, Label:'Book'},
 			{Value: amount, Label:'Amount'},
+			{Value: title, Label:'Product'},
+			{Value: price, Label:'Unit Price'},
 		],
 		Facets: [
 			{$Type: 'UI.ReferenceFacet', Label: '{i18n>OrderItems}', Target: '@UI.Identification'},
 		],
 	},
-);
+) {
+	amount @(
+		Common.FieldControl: #Mandatory
+	);
+};

orders/app/orders/webapp/Component.js

@@ -0,0 +1,8 @@
+sap.ui.define(["sap/fe/core/AppComponent"], function(AppComponent) {
+	"use strict";
+	return AppComponent.extend("orders.Component", {
+		metadata: { manifest: "json" }
+	});
+});
+
+/* eslint no-undef:0 */

orders/app/orders/webapp/manifest.json

@@ -24,7 +24,7 @@
 	"sap.ui5": {
         "dependencies": {
             "libs": {
-                "sap.fe": {}
+                "sap.fe.templates": {}
             }
         },
 		"models": {
@@ -121,7 +121,7 @@
                     "name": "sap.fe.templates.ObjectPage",
                     "options": {
                         "settings" : {
-                            "entitySet": "OrderItems"
+                            "entitySet": "Orders_Items"
                         }
                     }
                 },

orders/db/data/sap.capire.bookshop-OrderItems.csv

@@ -1,4 +0,0 @@
-ID;amount;parent_ID;book_ID;netAmount
-58040e66-1dcd-4ffb-ab10-fdce32028b79;1;7e2f2640-6866-4dcf-8f4d-3027aa831cad;201;11.11
-64e718c9-ff99-47f1-8ca3-950c850777d4;1;7e2f2640-6866-4dcf-8f4d-3027aa831cad;271;15
-e9641166-e050-4261-bfee-d1e797e6cb7f;2;64e718c9-ff99-47f1-8ca3-950c850777d4;252;28