Merge branch 'master' into master

.eslintrc

@@ -6,7 +6,7 @@
         "jest": true
     },
     "parserOptions": {
-        "ecmaVersion": 2017
+        "ecmaVersion": 2018
     },
     "globals": {
         "SELECT": true,

.npmrc

@@ -1 +1 @@
-package-lock=false
+@sap:registry=https://npm.sap.com

.vscode/launch.json

@@ -5,19 +5,17 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "cds run",
+      "name": "bookshop", "request": "launch", "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n" ],
-      "request": "launch",
+      "args": [ "--", "cds", "run", "--in-memory" ],
-      "type": "node",
+      "cwd": "${workspaceFolder}/packages/bookshop",
-      "runtimeExecutable": "npx",
+      "console": "integratedTerminal",
-      "runtimeArgs": ["-n"],
+      "skipFiles": ["<node_internals>/**"]
-      "args": ["--", "cds", "run", "--with-mocks", "--in-memory?"], // the leading "--" arg ensures it works with as well as without debugging
+    },
+    {
+      "name": "cds run ...", "request": "launch", "type": "node", "runtimeExecutable": "npx", "runtimeArgs": [ "-n" ],
+      "args": [ "--", "cds", "run", "--with-mocks", "--in-memory?" ],
       "cwd": "${workspaceFolder}/packages/${input:service}",
       "console": "integratedTerminal",
-      "serverReadyAction": {
-        "pattern": "server listening on (https?://\\S+|[0-9]+)",
-        "uriFormat": "http://localhost:%s",
-        "action": "openExternally"
-      },
       "skipFiles": ["<node_internals>/**"]
     }
   ],
@@ -31,12 +29,9 @@
         "bookstore",
         "media-server",
         "office-supplies",
-        "orders-service",
+        "reviews-service"
-        "products-service",
-        "reviews-service",
-        "user-service"
       ],
-      "default": "bookstore"
+      "default": "bookshop"
     }
   ]
 }

.vscode/settings.json

@@ -1,7 +1,6 @@
 {
   "files.exclude": {
-    "**/.gitignore": false,
+    "**/.gitignore": true,
-    "**/.git": false,
+    "**/.vscode": true
-    "**/.vscode": false
   }
 }

.vscode/tasks.json

@@ -4,23 +4,14 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "type": "shell", "label": "cds run bookshop",
+            "type": "npm", "script": "watch", "path": "packages/bookshop/",
-            "command": "npx", "args": [ "cds", "watch", "packages/bookshop" ],
+            "options": { "env": { "PORT": "4004" }},
-            "presentation": { "group": "A" },
+            "presentation": { "group": "A" }
-            "problemMatcher": []
         },
         {
-            "type": "shell", "label": "cds run bookshop-enhanced",
+            "type": "npm", "script": "watch", "path": "packages/reviews-service/",
-            "command": "npx", "args": [ "cds", "watch", "packages/bookshop-enhanced" ],
+            "options": { "env": { "PORT": "5005" }},
-            "presentation": { "group": "A" },
+            "presentation": { "group": "A" }
-            "problemMatcher": []
-        },
-        {
-            "type": "shell", "label": "cds run reviews-service",
-            "command": "npx", "args": [ "cds", "watch", "packages/reviews-service" ],
-            "options": {"env": { "PORT":"5005" }},
-            "presentation": { "group": "A" },
-            "problemMatcher": []
         }
     ]
 }

README.md

@@ -17,15 +17,13 @@ The samples provided can be run in a local setup on SQLite Database.
 
 #### Optional (if you want to import the code into an editor)
 * [VS Code](https://code.visualstudio.com)
-* [Add CDS extension to VS](https://help.sap.com/viewer/65de2977205c403bbc107264b8eccf4b/Cloud/en-US/be944d6d51f343f6b3f53c29c44ff00a.html)
+* [Add CDS extension to VS](https://cap.cloud.sap/docs/get-started/in-vscode#add-cds-editor)
 
 ## Download and Installation
 
 #### Install `cds` development kit
 ```sh
-# sets the registry for `@sap` packages
+# `@sap`-scoped packages are set via .npmrc
-npm set @sap:registry=https://npm.sap.com
-
 npm install -g @sap/cds-dk
 cds  #> test-run it
 ```

package.json

@@ -11,6 +11,7 @@
     "bookshop": "cds watch packages/bookshop",
     "bookshop-enhanced": "cds watch packages/bookshop-enhanced",
     "reviews-service": "cds watch packages/reviews-service",
+
     "bookstore": "cds watch packages/bookstore",
     "media-server": "cds watch packages/media-server"
   },

packages/bookshop-enhanced/package.json

@@ -11,7 +11,9 @@
     "express": "*"
   },
   "scripts": {
-    "start": "npx cds run"
+    "reviews-service": "PORT=5005 cds run ../reviews-service --bind --in-memory?",
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   },
   "cds": {
     "requires": {

packages/bookshop/app/fiori.html

@@ -43,7 +43,7 @@
 	<script src="https://sapui5.hana.ondemand.com/resources/sap-ui-core.js"
     	data-sap-ui-libs="sap.m, sap.ushell, sap.collaboration, sap.ui.layout"
     	data-sap-ui-compatVersion="edge"
-    	data-sap-ui-theme="sap_belize"
+    	data-sap-ui-theme="sap_fiori_3"
     	data-sap-ui-frameOptions="allow"
 	></script>
 	<script>

packages/bookshop/package.json

@@ -8,6 +8,7 @@
     "express": "*"
   },
   "scripts": {
-    "start": "npx cds run"
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   }
 }

packages/bookstore/package.json

@@ -28,7 +28,8 @@
     "app", "srv", "db"
   ],
   "scripts": {
-    "start": "cds run"
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
   },
   "cds": {
     "requires": {

packages/reviews-service/package.json

@@ -8,6 +8,10 @@
     "@sap/cds": "latest",
     "express": "*"
   },
+  "scripts": {
+    "start": "cds run --in-memory?",
+    "watch": "cds watch"
+  },
   "files": [
     "db",
     "srv",