Finalize ToDo's

.eslintrc

@@ -1,15 +1,15 @@
 {
-    "extends": [
-        "eslint:recommended",
-        "plugin:@sap/cds/recommended"
-    ],
+    "extends": "eslint:recommended",
     "env": {
         "browser": true,
-        "es2022": true,
         "node": true,
+        "es6": true,
         "jest": true,
         "mocha": true
     },
+    "parserOptions": {
+        "ecmaVersion": 2020
+    },
     "globals": {
         "SELECT": true,
         "INSERT": true,

.github/workflows/node.js.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x, 14.x]
+        node-version: [16.x, 14.x, 12.x]
 
     steps:
     - uses: actions/checkout@v2
@@ -24,6 +24,5 @@ jobs:
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-    - run: npm i -g npm@8
     - run: npm ci
     - run: npm test

.gitignore

@@ -12,11 +12,8 @@ target/
 *.mtar
 connection.properties
 default-env.json
-.cdsrc-private.json
 packages/messageBox
 reviews/msg-box
 reviews/db/test.db
 
 *.openapi3.json
-*.sqlite
-*.db

.registry/server.js

@@ -1,34 +1,27 @@
-const { exec, execSync } = require ('child_process')
+const { exec } = require ('child_process')
 const isWin = process.platform === 'win32'
 const express = require ('express')
 const fs = require ('fs')
-const { dirname, relative } = require('path')
-const axios = require('axios')
 const app = express()
 
+const { PORT=4444 } = process.env
+const [,,port=PORT,scope='@capire'] = process.argv
 const cwd = __dirname
-const port=process.env.PORT || 4444
-let scopes = process.argv.filter(a => a.startsWith('@'))
-if (!scopes.length)  scopes = ['@capire']
 
 // clean up on start (exit handler might not complete on Windows)
 exec(isWin ? 'del *.tgz' : 'rm *.tgz', {cwd})
 
 
-app.use('/-/:tarball', async (req,res,next) => {
+app.use('/-/:tarball', (req,res,next) => {
   console.debug ('GET', req.params)
   try {
     const { tarball } = req.params
     const pkgFull = tarball.substring(0, tarball.lastIndexOf('-'))
-    const scope = '@'+pkgFull.substring(0, pkgFull.indexOf('-'))
-    const pkg = pkgFull.substring(pkgFull.indexOf('-')+1)
+    const [, pkg ] = /^\w+-(.+)/.exec(pkgFull)
     fs.lstat(tarball,(err => {
-      if (err) { // no tgz yet
-        const loc = dirname(require.resolve(`${scope}/${pkg}/package.json`))
-        console.debug (`npm pack ${relative(cwd, loc)}`)
-        exec(`npm pack ${loc}`,{cwd},next)
-      }
-      else next() //> express.static below
+      if (err) console.debug (`npm pack ../${pkg}`)
+      if (err) exec(`npm pack ../${pkg}`,{cwd},next)
+      else next()
     }))
   } catch (e) {
     console.error(e)
@@ -38,20 +31,14 @@ app.use('/-/:tarball', async (req,res,next) => {
 
 app.use('/-', express.static(__dirname))
 
-app.get('/*', async (req,res)=>{
+app.get('/*', (req,res)=>{
   const urlRegex = /^\/(@[\w-]+)\/(.+)/
   const url = decodeURIComponent(req.url)
   console.debug ('GET',url)
   try {
     if (!urlRegex.test(url))  return res.sendStatus(404)
     const [, scpe, pkg ] = urlRegex.exec(url)
-    const packageName = `${scpe}/${pkg}`
-
-    // delegate to default registry for @sap/non-cds packages
-    if (scpe === ('@sap') && !packageName.startsWith('@sap/cds')) {
-      return forward(req, res)
-    }
-    const package = require (`${packageName}/package.json`)
+    const package = require (`${scpe}/${pkg}/package.json`)
     const tarball = `${scpe.slice(1)}-${pkg}-${package.version}.tgz`
     // https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md
     res.json({
@@ -66,8 +53,6 @@ app.get('/*', async (req,res)=>{
           "dist": {
             "tarball": `${server.url}/-/${tarball}`
           },
-          dependencies: package.dependencies,
-          devDependencies: package.devDependencies
         }
       },
     })
@@ -79,32 +64,15 @@ app.get('/*', async (req,res)=>{
 
 const server = app.listen(port, ()=>{
   const url = server.url = `http://localhost:${server.address().port}`
-
-  for (const scope of scopes) {
-    console.log (`npm set ${scope}:registry=${url}`)
-    execSync(`npm set ${scope}:registry=${url}`)
-  }
-  console.log (`registry listening on ${url}`)
+  console.log (`npm set ${scope}:registry=${url}`)
+  exec(`npm set ${scope}:registry=${url}`)
+  console.log (`${scope} registry listening on ${url}`)
 })
 
 
 const _exit = ()=>{
   server.close()
-  for (const scope of scopes) {
-    execSync(`npm conf rm "${scope}:registry"`)
-  }
-  process.exit()
-}
-
-async function forward(req, res) {
-  try {
-    const url = `https://registry.npmjs.org${req.url}`
-    const resAxios = await axios.get(url)
-    console.debug('->', decodeURI(url), resAxios.status)
-    return res.json(resAxios.data)
-  } catch (e) {
-    return res.sendStatus(e.response.status)
-  }
+  exec(`npm conf rm "${scope}:registry"`, ()=> { process.exit() })
 }
 
 process.on ('SIGTERM',_exit)

.tours/samples.tour

@@ -104,7 +104,7 @@
     },
     {
       "file": "fiori/app/services.cds",
-      "description": "### Annotations for SAP Fiori Elements\n\nAdds an SAP Fiori elements application to bookstore, thereby introducing:\n- OData Annotations in `.cds` files\n- Support for Fiori Draft\n- Support for Value Helps\n- Serving SAP Fiori apps locally\n\nSee the [Serving Fiori UIs](https://cap.cloud.sap/docs/advanced/fiori) documentation for more information.",
+      "description": "### Annotations for SAP Fiori Elements\n\n- [Adds an SAP Fiori elements application](https://cap.cloud.sap/docs/guides/fiori/) to bookstore, thereby introducing to:\n- [OData Annotations](https://cap.cloud.sap/docs/guides/fiori#adding-odata-annotations) in `.cds` files\n- Support for [Fiori Draft](https://cap.cloud.sap/docs/guides/fiori#draft)\n- Support for [Value Helps](https://cap.cloud.sap/docs/guides/fiori#value-help)\n- Serving SAP Fiori apps locally\n",
       "line": 1,
       "selection": {
         "start": {
@@ -136,4 +136,4 @@
   ],
   "isPrimary": true,
   "description": "Overview of CAP Samples for Node.js"
-}
+}

.vscode/settings.json

@@ -14,13 +14,5 @@
       "**/odata-v4/okra/**"
     ]
   },
-  "mochaExplorer.parallel": true,
-  "eslint.validate": [
-    "cds",
-    "csn",
-    "csv",
-    "csv (semicolon)",
-    "tsv",
-    "tab"
-  ]
-}
+  "mochaExplorer.parallel": true
+}

LICENSES/Apache-2.0.txt

@@ -1,73 +0,0 @@
-Apache License
-Version 2.0, January 2004
-http://www.apache.org/licenses/
-
-TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
-
-1. Definitions.
-
-"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
-
-"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
-
-"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
-
-"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
-
-"Source" form shall mean the preferred form for making modifications, including but not limited to software source code, documentation source, and configuration files.
-
-"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including but not limited to compiled object code, generated documentation, and conversions to other media types.
-
-"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
-
-"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
-
-"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner. For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by the copyright owner as "Not a Contribution."
-
-"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been received by Licensor and subsequently incorporated within the Work.
-
-2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such Derivative Works in Source or Object form.
-
-3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is filed.
-
-4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:
-
-     (a) You must give any other recipients of the Work or Derivative Works a copy of this License; and
-
-     (b) You must cause any modified files to carry prominent notices stating that You changed the files; and
-
-     (c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and
-
-     (d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.
-
-     You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.
-
-5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.
-
-6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.
-
-7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.
-
-8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract, or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or consequential damages of any character arising as a result of this License or out of the use or inability to use the Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such damages.
-
-9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify, defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor by reason of your accepting any such warranty or additional liability.
-
-END OF TERMS AND CONDITIONS
-
-APPENDIX: How to apply the Apache License to your work.
-
-To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!)  The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives.
-
-Copyright [yyyy] [name of copyright owner]
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.

README.md

@@ -7,14 +7,13 @@ Find here a collection of samples for the [SAP Cloud Application Programming Mod
 
 ### Preliminaries
 
-1. Ensure you have the latest LTS version of Node.js installed (see [Getting Started](https://cap.cloud.sap/docs/get-started/))
-2. Install [**@sap/cds-dk**](https://cap.cloud.sap/docs/get-started/) globally:
+1. Install [**@sap/cds-dk**](https://cap.cloud.sap/docs/get-started/) globally:
 
    ```sh
    npm i -g @sap/cds-dk
    ```
 
-3. _Optional:_ [Use Visual Studio Code](https://cap.cloud.sap/docs/get-started/tools#vscode)
+2. _Optional:_ [Use Visual Studio Code](https://cap.cloud.sap/docs/get-started/tools#vscode)
 
 ### Download
 

bookshop/app/vue/app.js

@@ -10,7 +10,7 @@ const books = Vue.createApp ({
         list: [],
         book: undefined,
         order: { quantity:1, succeeded:'', failed:'' },
-        user: undefined
+        user: {}
       }
     },
 
@@ -42,48 +42,20 @@ const books = Vue.createApp ({
             }
         },
 
-        async login() {
+        async fetchUserInfo() {
             try {
-                const { data:user } = await axios.post('/user/login',{})
-                if (user.id !== 'anonymous') books.user = user
+                const { data } = await axios.get('/user/me')
+                books.user = data
             } catch (err) { books.user = { id: err.message } }
-        },
-
-        async getUserInfo() {
-            try {
-                const { data:user } = await axios.get('/user/me')
-                if (user.id !== 'anonymous') books.user = user
-            } catch (err) { books.user = { id: err.message } }
-        },
+        }
     }
-}).mount('#app')
+}).mount("#app")
 
-books.getUserInfo()
-books.fetch() // initially fill list of books
+// initially fill list of books
+books.fetch()
 
+books.fetchUserInfo()
 document.addEventListener('keydown', (event) => {
     // hide user info on request
     if (event.key === 'u')  books.user = undefined
 })
-
-axios.interceptors.request.use(csrfToken)
-function csrfToken (request) {
-    if (request.method === 'head' || request.method === 'get') return request
-    if ('csrfToken' in document) {
-        request.headers['x-csrf-token'] = document.csrfToken
-        return request
-    }
-    return fetchToken().then(token => {
-        document.csrfToken = token
-        request.headers['x-csrf-token'] = document.csrfToken
-        return request
-    }).catch(_ => {
-        document.csrfToken = null // set mark to not try again
-        return request
-    })
-
-    function fetchToken() {
-        return axios.get('/', { headers: { 'x-csrf-token': 'fetch' } })
-        .then(res => res.headers['x-csrf-token'])
-    }
-}

bookshop/app/vue/index.html

@@ -18,17 +18,11 @@
 <body class="small-container", style="margin-top: 70px;">
 <div id='app'>
 
-    <form class="user" @submit.prevent="login">
-        <div v-if="user">
-            <div v-if="user.tenant">Tenant: {{ user.tenant }}</div>
-            <div> User: {{ user.id }}</div>
-            <div>Locale: {{ user.locale }}</div>
-        </div>
-        <div v-else>
-            <input type="submit" value="Login" class="muted-button">
-            <!-- <a href="/user/login()">Login</a> -->
-        </div>
-    </form>
+    <div v-if="user" class="user">
+        <div>User: {{ user.id || 'anonymous' }}</div>
+        <div>Locale: {{ user.locale }}</div>
+        <div v-if="user.tenant">Tenant: {{ user.tenant }}</div>
+    </div>
 
     <h1> Capire Books </h1>
 

bookshop/db/handlers/sandbox.cds

@@ -0,0 +1,2 @@
+using from '..\..\schema';
+

bookshop/db/schema.cds

@@ -1,31 +1,56 @@
-using { Currency, managed, sap } from '@sap/cds/common';
+using {
+  Currency,
+  managed,
+  sap,
+  extensible
+} from '@sap/cds/common';
+
 namespace sap.capire.bookshop;
 
-entity Books : managed {
-  key ID : Integer;
-  title  : localized String(111);
-  descr  : localized String(1111);
-  author : Association to Authors;
-  genre  : Association to Genres;
-  stock  : Integer;
-  price  : Decimal;
-  currency : Currency;
-  image : LargeBinary @Core.MediaType : 'image/png';
+@Extensibility.Any.Enabled : true
+entity Books : managed, extensible {
+  key ID         : Integer;
+      title      : localized String(111);
+      descr      : localized String(1111);
+      author     : Association to Authors;
+      genre      : Association to Genres;
+      stock      : Integer;
+      price      : Decimal;
+      currency   : Currency;
+      image      : LargeBinary @Core.MediaType : 'image/png';
+      authorName : String;
 }
 
-entity Authors : managed {
-  key ID : Integer;
-  name   : String(111);
-  dateOfBirth  : Date;
-  dateOfDeath  : Date;
-  placeOfBirth : String;
-  placeOfDeath : String;
-  books  : Association to many Books on books.author = $self;
+
+entity Authors : managed, extensible {
+  key ID           : Integer;
+      name         : String(111);
+      dateOfBirth  : Date;
+      dateOfDeath  : Date;
+      placeOfBirth : String;
+      placeOfDeath : String;
+
+      books        : Association to many Books
+                       on books.author = $self;
 }
 
-/** Hierarchically organized Code List for Genres */
+extend Authors with {
+  virtual age : Integer;
+  virtual exampleBook: String;
+}
+
+/**
+ * Hierarchically organized Code List for Genres
+ */
 entity Genres : sap.common.CodeList {
-  key ID   : Integer;
-  parent   : Association to Genres;
-  children : Composition of many Genres on children.parent = $self;
+  key ID       : Integer;
+      parent   : Association to Genres;
+      children : Composition of many Genres
+                   on children.parent = $self;
 }
+
+entity Publishers: managed {
+  key ID: Integer;
+  name: String(111);
+
+}

bookshop/handlers/AdminService.Authors.CREATE.js

@@ -0,0 +1,17 @@
+async function run() {
+  //debugger
+  //while (true) {}
+  //process.exit()
+  //1.substring()
+  // let res = await specialselect
+  let res = await SELECT.one`title`.from(`Books`).where(`ID=201`)
+  let { title } = res
+  let Author = req.data
+  //await srv.read('Books')
+  
+  Author.modifiedBy = "Custom Event handler changed this!"
+  Author.placeOfDeath = " --- Somewhere over " + title + " --- create in Sandbox"
+  //await this.emit("createdAuthor", { Author })
+  return Author
+}
+run()

bookshop/handlers/AdminService.Authors.READ.js

@@ -0,0 +1,41 @@
+function getYear(v) {
+  return parseInt(v.substr(0, 4))
+}
+function getMonth(v) {
+  return parseInt(v.substr(5, 2))
+}
+function getDay(v) {
+  return parseInt(v.substr(8, 2))
+}
+
+function getAge(from, to) {
+  if (from === undefined || from == null) return 0
+  if (to === undefined || to == null) to = new Date().toISOString()
+  let year = getYear(to) - getYear(from) - 1
+  if (
+    getMonth(to) > getMonth(from) ||
+    (getMonth(to) === getMonth(from) && getDay(to) >= getDay(from))
+  ) {
+    year++
+  }
+  return year
+}
+
+async function run() {
+  const result_ = Array.isArray(result) ? result : [result]
+  for (const row of result_) {
+    row.age = getAge(row.dateOfBirth, row.dateOfDeath)
+    let res = await SELECT.one`title`.from(`Books`).where({ author_ID: row.ID })
+    if (!res) {
+      res = {}
+    }
+    let { title } = res
+    if (!title) {
+      title = "no Books yet"
+    }
+    row.exampleBook = title
+    //let pub = await SELECT.one`name`.from(`sap_capire_bookshop_Publishers`)
+  }
+}
+
+run()

bookshop/handlers/AdminService.Books.CREATE.js

@@ -0,0 +1,9 @@
+
+async function run() {
+  const {stock, price, author_ID} = req.data
+  if (stock<0) return req.reject('409', 'Stock must not be negative')
+  if (price<0) return req.reject('409', 'Price must not be negative')
+  let {name} = await SELECT.one`name`.from(`Authors`).where({ID: author_ID})
+  req.data.authorName=name
+}
+output = run()

bookshop/handlers/AdminService.Books.READ.js

@@ -0,0 +1,6 @@
+const result_ = Array.isArray(result) ? result : [result];
+for (const row of result_) {
+  if (row.stock > 50) {
+    row.title += " ---Order now for a 10% discount!";
+  }
+}

bookshop/handlers/AdminService.renameAuthor.ON.js

@@ -0,0 +1,9 @@
+async function run() {
+  const {author, newName} = req.data
+  let a = await SELECT `name`.from(`Authors`).where({ID: author})
+  if(!a) return req.error (404, `Can't rename a non-existing author`)
+  await UPDATE (`Authors`,author).with ({ name: newName })
+    //await this.emit ('renamedAuthor', { author, newName })
+  output.msg = 'Success' 
+}
+run()

bookshop/handlers/createdAuthor.ON.js

@@ -0,0 +1,5 @@
+async function run() {
+  let {Author} = req.data
+  Author.placeOfBirth += ' --- modified in custom event' 
+}
+run()

bookshop/index.cds

@@ -2,4 +2,3 @@ namespace sap.capire.bookshop; //> important for reflection
 using from './db/schema';
 using from './srv/cat-service';
 using from './srv/admin-service';
-using from './srv/user-service';

bookshop/notebook.md

@@ -0,0 +1,112 @@
+# Base assumption
+
+Event handlers will always use **publicly available application API's**(services)
+
+- already done in Sandbox API by overwriting **SELECT**, **UPDATE**, **READ** and **CREATE**
+
+## Inbound data for validations
+
+- req.target plus expand on related data
+  - lazy loading on expand
+- event facade could have an explicit publishing of specific services or documents (e.g. remote services)
+- CQN Protocol adapter for subsequent reads --> req.data plus application service calls
+- what is the CDS subset to put in?
+  - req.data + target-rec (proxy, unloaded)
+  - ORM type lazy loading (dereferenced)
+  - application developer could actually provide custom proxies for specific functions
+  - performance impact of multiple accesses to object graph and multiple DB roundtrips
+  - can static code checking or developer annotations influence what is loaded into a graph?
+  - alternative: Stripped-down SELECT limited to req.target and ID
+    - application service only
+    - access rights of user respected
+- What about to-many relationships? For compositions essential, for associations to be questioned
+- Application Service Reads
+- outbound data for changes
+- call remote services
+  - register new remote services dynamically
+  - CAP provides an API on remote services - connect doesn't need to be done by extension developer
+  - alternative: declarative remote services plumbing with CDS service facade
+    - model looks like static internal services, remote calls done transparently behind the scenes
+
+-Emit Events
+
+- choreography of extension points
+  - deep inserts vs. fine grained operations
+  - input validation may be suited for fine grained operations
+  - today not in scope for performance reasons
+  - two different use case: Insert new page to book vs. update order-header with items-constraints in place
+- reject request, return errors and warnings - suitable for UI, too
+
+*/
+
+/*
+Annotations available:
+
+Entity level
+  @expression.constraint : [{if: 'expression evaluates to bool'}, on: ['INSERT, UPDATE, DELETE'], error: 'Transaction Rollback and error message', warning: 'Transaction proceeds and warning message']
+  @expression.computed : [{expression: 'ability to access request payload and modify it', on: ['INSERT, UPDATE']}]
+  @event : [{if: 'expression evaluates to bool', on: ['INSERT, UPDATE, DELETE, READ'], when: 'before or after, default before', emit: 'Event Name', to: 'Messaging target, optional'}]
+  @expresion.code :[{file: 'file name', on:['insert', 'update'], when: 'before or after, default before'},
+                    {source: 'each => { if (each.stock > 111) {each.title += `-- 11% discount!`; each.price= each.price*0.9}', on:['insert', 'update'], when: 'before or after'}]  
+Atribute Level
+  @assert.constraint : {if: 'stock>=0 OR stock <1000', error: 'i18n/error102'};
+  @event : {if: 'expression evaluates to bool', on: ['INSERT, UPDATE, DELETE, READ'], when: 'before or after', emit: 'Event Name', to: 'Messaging target, optional' }
+
+Functions available:
+  EXISTS(association target)
+  COUNT,AVG,MIN,MAX,SUM: Composition items, arrays etc
+  OLD:  before image
+  EACH: loop over composition items
+
+Events covered:
+CRUD --> Longhand and Shorthand supported?
+Upsert as one event?
+Before and after:
+  Before can change change request payload and stop transaction
+  After should trigger only asynchronous messages
+Specific Events for status changes? I think expression based event emitter suffices
+*/
+
+//Entity level annotations
+@expression.constraint : [{if: 'stock>100 AND price>15)', on: ['INSERT', 'UPDATE'], error: 'No Book over price 15 should have more than 100 stock' }, // error, rollback transactions
+{if: 'stock>90 AND price>15)', on: ['I', 'U'], warning: 'No Book over price 15 should have more than 100 stock' }] //warning, proceed with transaction but report warning back to UI
+@expression.computed : {expression: 'if(stock>100) then price=price*0.9', on: ['INSERT']}  //ability to modify the payload of the request, but nothing beyond it
+@expresion.code :[{file: 'sap.capire.bookshop-Books-beforeInsert', on:['insert', 'update'], when: 'before'},  //naming can be arbitrary?
+{source: 'each => { if (each.stock > 111) {each.title += `-- 11% discount!`; each.price= each.price*0.9}', on:['insert', 'update'], when: 'before'}]  //alternative
+@event : { if:'price>200', emit: 'Expensive Book', to: 'RulesEngine'}
+entity Books : managed {
+key ID : Integer;
+title  : localized String(111); @event : {if: 'old.title="Hello"', emit: 'Hello changed' }  //old refers to before Image. No "to" clause means message is emitted to any subscriber interested
+descr  : localized String(1111);
+author : Association to Authors @assert.constraint: 'exists(author)';  //function calls need to evaluate to bool
+genre  : Association to Genres;
+stock  : Integer @assert.constraint : {if: 'stock>=0 OR stock <1000', error: 'Stock not within permitted parameters'}; //when operand is used, no auto-insert
+price  : Decimal(9,2) @assert.constraint : '>0'; //insert operand on left side by default
+currency : Currency;
+image : LargeBinary @Core.MediaType : 'image/png';
+stockWorth: Decimal(9,2) @expression.computed : 'stock*price'; //persisted on write. Overhead in runtime, but performance benefit on read. Payload ignored?
+// stockWorth2 = stock*price;  -- long term goal from compiler team, not persisted on write, but calculated on read
+stockWorth3 : Decimal @expression.computed: 'if (stock*price>1000) then stockWorth3=stock.price else stockworth3=1000';  //which altenative?
+stockWorth4 : Decimal @expression.computed: {if: '(stock*price>1000)', then: 'stockWorth3=stock.price', else: 'stockworth3=1000'};
+}
+//@assert.expression: 'dateOfBirth<dateOfDeath'
+entity Authors : managed {
+key ID : Integer;
+name   : String(111);
+dateOfBirth  : Date ;
+dateOfDeath  : Date @expression.constraint: '>dateOfBirth';
+placeOfBirth : String;
+placeOfDeath : String;
+books  : Association to many Books on books.author = $self;
+}
+
+/** Hierarchically organized Code List for Genres */
+entity Genres : sap.common.CodeList {
+key ID   : Integer;
+parent   : Association to Genres;
+children : Composition of many Genres on children.parent = $self;
+}
+
+```
+
+```

bookshop/package.json

@@ -12,7 +12,8 @@
   "dependencies": {
     "@sap/cds": ">=5.9",
     "express": "^4.17.1",
-    "passport": ">=0.4.1"
+    "passport": ">=0.4.1",
+    "vm2": ">=3.9.9"
   },
   "scripts": {
     "genres": "cds serve test/genres.cds",
@@ -21,7 +22,13 @@
   },
   "cds": {
     "requires": {
-      "db": "sql"
+      "code-extensibility" : true,
+      "db": {
+        "kind": "sqlite",
+        "credentials": {
+          "database": "sqlite.db"
+        }
+      }
     }
   }
-}
+}

bookshop/srv/admin-service.cds

@@ -1,5 +1,30 @@
-using { sap.capire.bookshop as my } from '../db/schema';
-service AdminService @(requires:'admin') {
-  entity Books as projection on my.Books;
-  entity Authors as projection on my.Authors;
+using {sap.capire.bookshop as my} from '../db/schema';
+
+service AdminService // @(requires : 'admin')
+{
+  entity Books   as projection on my.Books actions {
+    action   increaseStock(count : Integer);
+    function stock() returns Integer;
+  };
+
+@Extensibility : {
+  Fields.Enabled      : true,
+  Fields.Quota: 100,
+  Relations.Enabled   : false,
+  Annotations.Enabled : true,
+  Logic.Enabled : true,
+  Logic.constraints: true,
+  Logic.calculations: true,
+  Logic.Handler : [create, update, delete, read]
+}
+  entity Authors as projection on my.Authors;
+
+  action renameAuthor(author : Authors:ID, newName : String) returns {
+    msg : String
+  };
+  function getStock(book: Books:ID) returns Integer;
+  event newBook : {
+    book : Books:ID;
+    name : Books:title
+  };
 }

bookshop/srv/admin-service.js

@@ -1,13 +1,135 @@
-const cds = require('@sap/cds/lib')
+const cds = require("@sap/cds")
+//const cds_sandbox = require("sap/cds/sandbox")
+const { VM, VMScript } = require("vm2")
+const fs = require("fs")
+const path = require("path")
+const { nextTick } = require("process")
 
-module.exports = class AdminService extends cds.ApplicationService { init(){
-  this.before ('NEW','Authors', genid)
-  this.before ('NEW','Books', genid)
-  return super.init()
-}}
+class AdminService extends cds.ApplicationService {
+  init() {
+    this.after("READ", async (result, req) => {
+      if (!(result === undefined || result == null)) {
+        const code = getCode(req.target.name, "READ")
+        if (code) {
+          await executeCode.call(this, code, req, result)
+        }
+      }
+    })
 
-/** Generate primary keys for target entity in request */
-async function genid (req) {
-  const {ID} = await cds.tx(req).run (SELECT.one.from(req.target).columns('max(ID) as ID'))
-  req.data.ID = ID - ID % 100 + 100 + 1
+    this.before("CREATE", async (req) => {
+      const code = getCode(req.target.name, "CREATE")
+      if (code) {
+        await executeCode.call(this, code, req)
+      }
+    })
+
+    this.before("UPDATE", async (req) => {
+      const code = getCode(req.target.name, "CREATE")
+      if (code) {
+        await executeCode.call(this, code, req)
+      }
+    })
+
+    this.on("*", async (req, next) => {
+      if (!(req.target === undefined || req.target == null)) return next()
+      //ToDo: check whether action or event is part of an extension
+      // DO NOT OVERWRITE EXISTING Action Implementations!
+      // evaluate: Can we augment action implementation with super.next?
+      if (req.constructor.name === "EventMessage") {
+        const code = getCode(req.event, "ON")
+        if (code) {
+          await executeCode.call(this, code, req)
+        }
+      } else if (req.constructor.name === "ODataRequest") {
+        var output = {}
+        const code = getCode(this.name + "." + req.event, "ON")
+        if (code) {
+          await executeCode.call(this, code, req, {}, output)
+          return output
+        }
+      }
+    })
+
+    //ToDo: Prefix for Service not in event emitter
+    this.before("CREATE", "Authors", async (req) => {
+      let Author = req.data
+      await this.emit("createdAuthor", { Author })
+
+    })
+ 
+    return super.init()
+  }
 }
+
+var counter = 1;
+
+function newLabel() {return "VM2 - req: " + counter++}
+
+//should only work in local exection (cds watch)
+// alternative: Upon Bootstrapping, merge files into CSN
+function getCodeFromFile(name, operation) {
+  const filename = name + "." + operation + ".js"
+  const file = path.join(__dirname, "..", "handlers", filename)
+  try {
+    const code = fs.readFileSync(file, "utf8")
+    return code
+  } catch (error) {
+    return ""
+  }
+}
+
+//after push this should be the only thing that works
+function getCodeFromAnnotation(name, operation) {
+  return ""
+}
+
+function getCode(name, operation) {
+  let code=getCodeFromAnnotation(name, operation)
+  if (code==="") {code=getCodeFromFile(name, operation)}
+  return code
+}
+
+function scanCode(code) {
+  //ESLINT
+}
+
+async function executeCode(code, req, result, output) {
+  const srv = this
+  const label=newLabel()
+  console.time(label)
+  const vm = new VM({
+    console: "inherit",
+    timeout: 500,
+    allowAsync: true,
+    sandbox: { req, //todo: isolate req.data, req.reject, req.error, req.message
+      result, //important for READ
+      output, //used for Action Implementation
+      SELECT :  (class extends require('@sap/cds/lib/ql/SELECT')  {then(r,e) {return srv.run(this).then(r,e)}})._api(),  
+      INSERT :  (class extends require('@sap/cds/lib/ql/INSERT')  {then(r,e) {return srv.run(this).then(r,e)}})._api(), 
+      UPDATE :  (class extends require('@sap/cds/lib/ql/UPDATE')  {then(r,e) {return srv.run(this).then(r,e)}})._api(), 
+      CREATE :  (class extends require('@sap/cds/lib/ql/CREATE')  {then(r,e) {return srv.run(this).then(r,e)}})._api(), 
+      //srv: this,
+      JSON },
+  })
+
+  try {
+    await vm.run(code)
+    return output
+  } catch (error) {
+    console.log(error)
+    req.reject("409", "Error in VM")
+  }
+  finally {
+    console.timeEnd(label)
+  }
+  // console.log(req.data)
+}
+/** Generate primary keys for target entity in request */
+async function genid(req) {
+  const { ID } = await cds
+    .tx(req)
+    .run(SELECT.one.from(req.target).columns("max(ID) as ID"))
+  req.data.ID = ID - (ID % 100) + 100 + 1
+}
+
+module.exports = { AdminService }

bookshop/srv/cat-service.cds

@@ -10,6 +10,8 @@ service CatalogService @(path:'/browse') {
     author.name as author
   } excluding { createdBy, modifiedBy };
 
+@readonly entity Publishers as projection on my.Publishers;
+
   @requires: 'authenticated-user'
   action submitOrder ( book: Books:ID, quantity: Integer ) returns { stock: Integer };
   event OrderedBook : { book: Books:ID; quantity: Integer; buyer: String };

bookshop/srv/cat-service.js

@@ -3,7 +3,6 @@ const cds = require('@sap/cds')
 class CatalogService extends cds.ApplicationService { init(){
 
   const { Books } = cds.entities ('sap.capire.bookshop')
-  const { ListOfBooks } = this.entities
 
   // Reduce stock of ordered books if available stock suffices
   this.on ('submitOrder', async req => {
@@ -19,7 +18,7 @@ class CatalogService extends cds.ApplicationService { init(){
   })
 
   // Add some discount for overstocked books
-  this.after ('READ', ListOfBooks, each => {
+  this.after ('READ','ListOfBooks', each => {
     if (each.stock > 111) each.title += ` -- 11% discount!`
   })
 

bookshop/srv/code-extensions.cds

@@ -0,0 +1,11 @@
+//this file is machine-created during cds.build
+namespace sap.capire.bookshop; //> important for reflection
+using from '../db/schema';
+using from '../srv/cat-service';
+using from '../srv/admin-service';
+
+annotate AdminService.Authors with @extension.logic: [{when: 'CREATE', code: 'async function run() {\r\n  \/\/debugger\r\n  \/\/while (true) {}\r\n  \/\/process.exit()\r\n  \/\/1.substring()\r\n  \/\/ let res = await specialselect\r\n  let res = await SELECT.one`title`.from(`Books`).where(`ID=201`)\r\n  let { title } = res\r\n  let Author = req.data\r\n  Author.modifiedBy = \"Custom Event handler changed this!\"\r\n  Author.placeOfDeath = \" --- Somewhere over \" + title + \" --- create in Sandbox\"\r\n  \/\/await this.emit(\"createdAuthor\", { Author })\r\n  return Author\r\n}\r\nrun()\r\n'},
+{when: 'READ', code: 'function getYear(v) {\r\n  return parseInt(v.substr(0, 4))\r\n}\r\nfunction getMonth(v) {\r\n  return parseInt(v.substr(5, 2))\r\n}\r\nfunction getDay(v) {\r\n  return parseInt(v.substr(8, 2))\r\n}\r\n\r\nfunction getAge(from, to) {\r\n  if (from === undefined || from == null) return 0\r\n  if (to === undefined || to == null) to = new Date().toISOString()\r\n  let year = getYear(to) - getYear(from) - 1\r\n  if (\r\n    getMonth(to) > getMonth(from) ||\r\n    (getMonth(to) === getMonth(from) && getDay(to) >= getDay(from))\r\n  ) {\r\n    year++\r\n  }\r\n  return year\r\n}\r\n\r\nconst result_ = Array.isArray(result) ? result : [result]\r\nfor (const row of result_) {\r\n  row.modifiedBy += \" --- read in sandbox\"\r\n  row.age = getAge(row.dateOfBirth, row.dateOfDeath)\r\n}'}
+];
+annotate AdminService.Books with @extension.logic;
+annotate CatalogService.ListOfBooks with @extension.logic;

bookshop/srv/user-service.cds

@@ -1,15 +1,16 @@
 /**
  * Exposes user information
  */
+@requires: 'authenticated-user'
 service UserService {
+
   /**
    * The current user
    */
-  @odata.singleton entity me @cds.persistence.skip {
+  @odata.singleton entity me {
     id     : String; // user id
     locale : String;
     tenant : String;
   }
 
-  action login() returns me;
 }

bookshop/srv/user-service.js

@@ -1,9 +1,4 @@
 const cds = require('@sap/cds')
-module.exports = class UserService extends cds.Service { init(){
-  this.on('READ', 'me', ({ tenant, user, locale }) => ({ id: user.id, locale, tenant }))
-  this.on('login', (req) => {
-    if (req.user._is_anonymous)
-      req._.res.set('WWW-Authenticate','Basic realm="Users"').sendStatus(401)
-    else return this.read('me')
-  })
-}}
+module.exports = cds.service.impl((srv) => {
+  srv.on('READ', 'me', ({ tenant, user, locale }) => ({ id: user.id, locale, tenant }))
+})

bookshop/test/requests.http

@@ -1,10 +1,46 @@
 @server = http://localhost:4004
 @me = Authorization: Basic {{$processEnv USER}}:
+@id = 2000
+
+
+### ------------------------------------------------------------------------
+# Fetch Authors
+GET {{server}}/admin/Authors
+
+### ------------------------------------------------------------------------
+# Fetch one Author
+GET {{server}}/admin/Authors({{id}})
+
+### ------------------------------------------------------------------------
+# Create Author
+POST {{server}}/admin/Authors
+Content-Type: application/json;IEEE754Compatible=true
+
+{
+  "ID": {{id}},
+  "name": "Nick",
+  "placeOfBirth": "Somewhere",
+  "placeOfDeath": "over the Rainbox",
+  "dateOfBirth" : "1975-05-27"
+}
+
+### ------------------------------------------------------------------------
+# rename author via unbound action
+POST {{server}}/admin/renameAuthor
+Content-Type: application/json
+{{me}}
+
+{ "author":{{id}}, "newName":"Super Nick" }
 
 
 ### ------------------------------------------------------------------------
 # Get service info
-GET {{server}}/browse
+GET {{server}}/admin
+{{me}}
+
+### ------------------------------------------------------------------------
+# Get $metadata document
+GET {{server}}/admin/$metadata
 {{me}}
 
 
@@ -23,27 +59,12 @@ GET {{server}}/browse/ListOfBooks?
 {{me}}
 
 
-### ------------------------------------------------------------------------
-# Fetch Authors as admin
-GET {{server}}/admin/Authors?
-  # &$select=name,dateOfBirth,placeOfBirth
-  # &$expand=books($select=title;$expand=currency)
-  # &$filter=ID eq 101
-  # &sap-language=de
-Authorization: Basic alice:
+
+
 
 ### ------------------------------------------------------------------------
-# Create Author
-POST {{server}}/admin/Authors
-Content-Type: application/json;IEEE754Compatible=true
-Authorization: Basic alice:
-
-{
-  "ID": 112,
-  "name": "Shakespeeeeere",
-  "age": 22
-}
-
+# Fetch Books as admin
+GET {{server}}/admin/Books
 
 ### ------------------------------------------------------------------------
 # Create book
@@ -52,12 +73,12 @@ Content-Type: application/json;IEEE754Compatible=true
 Authorization: Basic alice:
 
 {
-  "ID": 2,
-  "title": "Poems : Pocket Poets",
+  "ID": 16,
+  "title": "Deh4",
   "descr": "The Everyman's Library Pocket Poets hardcover series is popular for its compact size and reasonable price which does not compromise content. Poems: Bronte contains poems that demonstrate a sensibility elemental in its force with an imaginative discipline and flexibility of the highest order. Also included are an Editor's Note and an index of first lines.",
   "author": { "ID": 101 },
   "genre": { "ID": 12 },
-  "stock": 5,
+  "stock": -100,
   "price": "12.05",
   "currency": { "code": "USD" }
 }

bookstore/server.js

@@ -19,4 +19,4 @@ module.exports = cds.server
 
 // For didactic reasons in capire
 const { ReviewsService, OrdersService } = cds.requires
-if (!ReviewsService?.credentials && !OrdersService?.credentials) cds.requires.messaging = false
+if (!ReviewsService.credentials && !OrdersService.credentials) cds.requires.messaging = false

data-viewer/srv/data-service.cds

@@ -2,12 +2,12 @@
  * Exposes data + entity metadata
  */
 @requires:'authenticated-user'
-@odata service DataService @( path:'-data' ) {
+service DataService @( path:'-data' ) {
 
   /**
    * Metadata like name and columns/elements
    */
-  entity Entities @cds.persistence.skip {
+  entity Entities {
     key name : String;
     columns: Composition of many {
       name :  String;
@@ -19,7 +19,7 @@
   /**
    * The actual data, organized by column name
    */
-  entity Data @cds.persistence.skip {
+  entity Data {
     record   : array of {
       column : String;
       data   : String;

fiori-ext/.vscode/settings.json

@@ -1,11 +0,0 @@
-{
-  "eslint.validate": [
-    "cds",
-    "csn",
-    "csv",
-    "csv",
-    "csv (semicolon)",
-    "tsv",
-    "tab"
-  ]
-}

fiori-ext/README.md

@@ -1,21 +0,0 @@
-# Welcome to your Extension Project for the CAP Bookshop Fiori App
-
-It contains these folders and files, following our recommended project layout:
-
-| File or Folder | Purpose                            |
-|----------------|------------------------------------|
-| `app/`         | content for UI frontends goes here |
-| `test/`        | contet for local tests             |
-| `package.json` | project metadata and configuration |
-| `readme.md`    | this getting started guide         |
-
-
-## Next Steps
-
-- Runs `cds login ...`
-- Runs `cds pull ...`
-
-
-## Learn More
-
-Learn more at https://cap.cloud.sap/docs/get-started/.

fiori-ext/app/extension.cds

@@ -1,25 +0,0 @@
-using { OrdersService, sap, sap.capire.orders.Orders } from '@capire/fiori';
-namespace x_bookshop.extension;
-
-// Adding 2 new fields for Orders
-extend Orders with {
-  x_priority    : String @assert.range enum {high; medium; low} default 'medium' ;
-  x_salesRegion : Association to SalesRegion;
-}
-
-/** Value Help for x_salesRegion */
-entity SalesRegion : sap.common.CodeList {
-  key code : String(11);
-}
-
-// --- UI ---
-
-annotate Orders:x_priority with @title : 'Priority';
-annotate SalesRegion:name with @title : 'Sales Region';
-
-annotate OrdersService.Orders with @UI.LineItem : [
-  ... up to { Value: OrderNo },
-  { Value : x_priority },
-  { Value : x_salesRegion.name },
-  ...
-];

fiori-ext/package.json

@@ -1,49 +0,0 @@
-{
-  "name": "@capire/fiori-ext",
-  "version": "1.0.0",
-  "description": "A simple CAP project.",
-  "repository": "<Add your repository here>",
-  "license": "UNLICENSED",
-  "private": true,
-  "dependencies": {
-    "@sap/cds": "^6"
-  },
-  "devDependencies": {
-    "sqlite3": "^5.0.4",
-    "@sap/eslint-plugin-cds": "^2.5.0"
-  },
-  "scripts": {
-    "start": "cds run"
-  },
-  "cds": {
-    "extends": "@capire/fiori"
-  },
-  "eslintConfig": {
-    "extends": [
-      "eslint:recommended",
-      "plugin:@sap/cds/recommended"
-    ],
-    "env": {
-      "es2020": true,
-      "node": true,
-      "jest": true,
-      "mocha": true
-    },
-    "globals": {
-      "SELECT": true,
-      "INSERT": true,
-      "UPDATE": true,
-      "DELETE": true,
-      "CREATE": true,
-      "DROP": true,
-      "CDL": true,
-      "CQL": true,
-      "CXL": true,
-      "cds": true
-    },
-    "rules": {
-      "no-console": "off",
-      "require-atomic-updates": "off"
-    }
-  }
-}

fiori-ext/test/data/sap.capire.orders-Orders.csv

@@ -1,3 +0,0 @@
-ID;createdAt;createdBy;buyer;OrderNo;currency_code;Z_priority;Z_SalesRegion_regionCode
-7e2f2640-6866-4dcf-8f4d-3027aa831cad;2019-01-31;john.doe@test.com;john.doe@test.com;1;EUR;high;AMER
-64e718c9-ff99-47f1-8ca3-950c850777d4;2019-01-30;jane.doe@test.com;jane.doe@test.com;2;EUR;low;APJ

fiori-ext/test/data/x_bookshop.extension-SalesRegion.csv

@@ -1,4 +0,0 @@
-code;name;descr
-AMER;Americas;North, Central and South America
-EMEA;Europe, the Middle East and Africa;Europe, the Middle East and Africa
-APJ;Asia Pacific and Japan;Asia Pacific and Japan

fiori/app/_router/package.json

@@ -1,12 +0,0 @@
-{
-  "name": "approuter",
-  "dependencies": {
-    "@sap/approuter": "^11.0.0"
-  },
-  "engines": {
-    "node": "^16"
-  },
-  "scripts": {
-    "start": "node node_modules/@sap/approuter/approuter.js"
-  }
-}

fiori/app/_router/xs-app.json

@@ -1,23 +0,0 @@
-{
-  "authenticationMethod": "route",
-  "routes": [
-    {
-      "source": "^/app/(.*)$",
-      "target": "$1",
-      "localDir": ".",
-      "authenticationType": "xsuaa",
-      "cacheControl": "no-cache, no-store, must-revalidate"
-    },
-    {
-      "source": "^/-/cds/.*",
-      "destination": "mtx-api",
-      "authenticationType": "none"
-    },
-    {
-      "source": "^/(.*)$",
-      "target": "$1",
-      "destination": "srv-api",
-      "authenticationType": "xsuaa"
-    }
-  ]
-}

fiori/app/admin-authors/fiori-service.cds

@@ -39,7 +39,7 @@ annotate AdminService.Authors with @(UI : {
 
 // Workaround to avoid errors for unknown db-specific calculated fields above
 extend sap.capire.bookshop.Authors with {
-  virtual age      : Integer;
+  //virtual age      : Integer;
   virtual lifetime : String;
 }
 

fiori/app/admin-authors/webapp/manifest.json

@@ -50,6 +50,10 @@
     }
   },
   "sap.ui5": {
+    "flexEnabled": true,
+    "config": {           
+      "experimentalCAPScenario": true
+      },
     "dependencies": {
       "minUI5Version": "1.81.0",
       "libs": {

fiori/app/admin-books/webapp/manifest.json

@@ -22,6 +22,10 @@
         }
     },
     "sap.ui5": {
+        "flexEnabled": true,
+    "config": {           
+      "experimentalCAPScenario": true
+      },
         "dependencies": {
             "libs": {
                 "sap.fe.templates": {}

fiori/app/appconfig/fioriSandboxConfig.json

@@ -19,14 +19,6 @@
                     "title": "Browse Books",
                     "targetURL": "#Books-display"
                   }
-                },
-                {
-                  "id": "BrowseGenres",
-                  "tileType": "sap.ushell.ui.tile.StaticTile",
-                  "properties": {
-                    "title": "Browse Genres (OData v2)",
-                    "targetURL": "#Genres-display"
-                  }
                 }
               ]
             },
@@ -115,24 +107,6 @@
                 "url": "/admin-authors/webapp"
               }
             },
-            "BrowseGenres": {
-              "semanticObject": "Genres",
-              "action": "display",
-              "title": "Browse Genres",
-              "signature": {
-                "parameters": {
-                  "Genre.ID": {
-                    "renameTo": "ID"
-                  }
-                },
-                "additionalParameters": "ignored"
-              },
-              "resolutionResult": {
-                "applicationType": "SAPUI5",
-                "additionalInformation": "SAPUI5.Component=genres",
-                "url": "/genres/webapp"
-              }
-            },
             "ManageBooks": {
               "semanticObject": "Books",
               "action": "manage",

fiori/app/browse/webapp/manifest.json

@@ -53,6 +53,10 @@
     }
   },
   "sap.ui5": {
+    "flexEnabled": true,
+    "config": {           
+      "experimentalCAPScenario": true
+      },
     "dependencies": {
       "minUI5Version": "1.81.0",
       "libs": {

fiori/app/fiori-apps.html

@@ -10,7 +10,21 @@
 	<script>
 		window["sap-ushell-config"] = {
 			defaultRenderer: "fiori2",
-			applications: {}
+			applications: {},
+			bootstrapPlugins: {
+          RuntimeAuthoringPlugin: {
+            component: "sap.ushell.plugins.rta",
+            config: {
+              validateAppVersion: false,
+            },
+          },
+          PersonalizePlugin: {
+            component: "sap.ushell.plugins.rta-personalize",
+            config: {
+              validateAppVersion: false,
+            },
+          },
+        }
 		};
 	</script>
 
@@ -22,7 +36,11 @@
 			data-sap-ui-frameOptions="allow"
 	></script>
 	<script>
-		sap.ui.getCore().attachInit(()=> sap.ushell.Container.createRenderer().placeAt("content"))
+		sap.ui.getCore().attachInit(()=> sap.ushell.Container.createRenderer().placeAt("content"));
+		sap.ui
+        .getCore()
+        .getConfiguration()
+        .setFlexibilityServices([{ connector: "SessionStorageConnector" }]);
 	</script>
 
 </head>

fiori/app/genres/fiori-service.cds

@@ -1,8 +0,0 @@
-using { sap.capire.bookshop } from '../../db/common';
-
-annotate bookshop.GenreHierarchy {
-  ID             @sap.hierarchy.node.for;
-  parent         @sap.hierarchy.parent.node.for;
-  hierarchyLevel @sap.hierarchy.level.for;
-  drillState     @sap.hierarchy.drill.state.for;
-}

fiori/app/genres/webapp/Component.js

@@ -1,7 +0,0 @@
-sap.ui.define(["sap/suite/ui/generic/template/lib/AppComponent"], (AppComponent) =>
-  AppComponent.extend("genres.Component", {
-    metadata: {
-      manifest: "json",
-    },
-  })
-);

fiori/app/genres/webapp/i18n/i18n.properties

@@ -1,4 +0,0 @@
-#XTIT
-appTitle=Genres
-#XTXT
-appDescription=Browse Genres

fiori/app/genres/webapp/manifest.json

@@ -1,155 +0,0 @@
-{
-  "_version": "1.8.0",
-  "sap.app": {
-    "id": "genres",
-    "type": "application",
-    "i18n": "i18n/i18n.properties",
-    "applicationVersion": {
-      "version": "1.0.0"
-    },
-    "title": "Browse Genres Hierarchy (OData v2)",
-    "description": "{{appDescription}}",
-    "tags": {
-      "keywords": []
-    },
-    "crossNavigation": {
-      "inbounds": {
-        "appShow": {
-          "title": "{{appTitle}}",
-          "semanticObject": "GenreHierarchy",
-          "action": "display",
-          "deviceTypes": {
-            "desktop": true,
-            "tablet": true,
-            "phone": true
-          },
-          "icon": "sap-icon://settings",
-          "size": "1x1"
-        }
-      },
-      "outbounds": {}
-    },
-    "ach": "",
-    "resources": "resources.json",
-    "dataSources": {
-      "main": {
-        "uri": "/v2/browse",
-        "type": "OData",
-        "settings": {
-          "annotations": ["localAnnotations"],
-          "localUri": "localService/metadata.xml"
-        }
-      },
-      "localAnnotations": {
-        "type": "ODataAnnotation",
-        "uri": "annotations/localAnnotations.xml",
-        "settings": {
-          "localUri": "annotations/localAnnotations.xml"
-        }
-      }
-    },
-    "offline": false,
-    "sourceTemplate": {
-      "id": "ui5template.smartTemplate",
-      "version": "1.40.12"
-    }
-  },
-  "sap.ui": {
-    "technology": "UI5",
-    "icons": {
-      "icon": "",
-      "favIcon": "",
-      "phone": "",
-      "phone@2": "",
-      "tablet": "",
-      "tablet@2": ""
-    },
-    "deviceTypes": {
-      "desktop": true,
-      "tablet": true,
-      "phone": true
-    },
-    "supportedThemes": ["sap_hcb", "sap_belize", "sap_belize_deep", "sap_fiori_3"]
-  },
-  "sap.ui5": {
-    "resources": {
-      "js": [],
-      "css": []
-    },
-    "dependencies": {
-      "minUI5Version": "1.65.6",
-      "libs": {},
-      "components": {}
-    },
-    "models": {
-      "i18n": {
-        "type": "sap.ui.model.resource.ResourceModel",
-        "uri": "i18n/i18n.properties"
-      },
-      "@i18n": {
-        "type": "sap.ui.model.resource.ResourceModel",
-        "uri": "i18n/i18n.properties"
-      },
-      "json": {
-        "type": "sap.ui.model.json.JSONModel"
-      },
-      "i18n|sap.suite.ui.generic.template.ListReport|Genres": {
-        "type": "sap.ui.model.resource.ResourceModel",
-        "uri": "i18n/ListReport/Genres/i18n.properties"
-      },
-      "": {
-        "dataSource": "main",
-        "preload": true,
-        "settings": {
-          "useBatch": true,
-          "defaultBindingMode": "TwoWay",
-          "defaultCountMode": "Inline",
-          "refreshAfterChange": true,
-          "metadataUrlParams": {
-            "sap-value-list": "none"
-          }
-        }
-      }
-    },
-    "contentDensities": {
-      "compact": true,
-      "cozy": true
-    }
-  },
-  "sap.ui.generic.app": {
-    "_version": "1.3.0",
-    "settings": {
-      "forceGlobalRefresh": false,
-      "useColumnLayoutForSmartForm": false,
-      "showBasicSearch": false
-    },
-    "pages": {
-      "ListReport|Genres": {
-        "entitySet": "GenreHierarchy",
-        "component": {
-          "name": "sap.suite.ui.generic.template.ListReport",
-          "list": true,
-          "settings": {
-            "condensedTableLayout": true,
-            "smartVariantManagement": true,
-            "tableType": "TreeTable",
-            "enableTableFilterInPageVariant": true,
-            "dataLoadSettings": {
-              "loadDataOnAppLaunch": "always"
-            }
-          }
-        }
-      }
-    }
-  },
-  "sap.fiori": {
-    "registrationIds": [],
-    "archeType": "transactional"
-  },
-  "sap.platform.hcp": {
-    "uri": ""
-  },
-  "sap.platform.cf": {
-    "oAuthScopes": []
-  }
-}

fiori/app/services.cds

@@ -5,6 +5,5 @@
 using from './admin-authors/fiori-service';
 using from './admin-books/fiori-service';
 using from './browse/fiori-service';
-using from './genres/fiori-service';
 using from './common';
 using from '@capire/bookstore/srv/mashup';

fiori/app/xs-app.json

@@ -1,24 +0,0 @@
-{
-  "authenticationMethod": "route",
-  "routes": [
-    {
-      "source": "^/-/cds/.*",
-      "destination": "mtx-api",
-      "authenticationType": "none"
-    },
-    {
-      "source": "^/app/(.*)$",
-      "target": "$1",
-      "localDir": ".",
-      "authenticationType": "xsuaa",
-      "cacheControl": "no-cache, no-store, must-revalidate"
-    },
-    {
-      "source": "^/(.*)$",
-      "target": "$1",
-      "destination": "srv-api",
-      "authenticationType": "xsuaa",
-      "csrfProtection": true
-    }
-  ]
-}

fiori/db/common.cds

@@ -1,14 +0,0 @@
-namespace sap.capire.bookshop;
-
-using { sap.capire.bookshop } from '@capire/bookstore/srv/mashup';
-
-entity GenreHierarchy : bookshop.Genres {
-  hierarchyLevel : Integer default 0;
-  drillState     : String default 'leaf';
-  parent         : Association to GenreHierarchy;
-  children       : Composition of many GenreHierarchy on children.parent = $self;
-}
-
-extend service CatalogService with {
-  @readonly entity GenreHierarchy as projection on bookshop.GenreHierarchy;
-}

fiori/db/data/sap.capire.bookshop-Books_texts.csv

@@ -1,5 +0,0 @@
-ID_texts;ID;locale;title;descr
-201_de;201;de;Sturmhöhe;Sturmhöhe (Originaltitel: Wuthering Heights) ist der einzige Roman der englischen Schriftstellerin Emily Brontë (1818–1848). Der 1847 unter dem Pseudonym Ellis Bell veröffentlichte Roman wurde vom viktorianischen Publikum weitgehend abgelehnt, heute gilt er als ein Klassiker der britischen Romanliteratur des 19. Jahrhunderts.
-201_fr;201;fr;Les Hauts de Hurlevent;Les Hauts de Hurlevent (titre original : Wuthering Heights), parfois orthographié Les Hauts de Hurle-Vent, est l'unique roman d'Emily Brontë, publié pour la première fois en 1847 sous le pseudonyme d’Ellis Bell. Loin d'être un récit moralisateur, Emily Brontë achève néanmoins le roman dans une atmosphère sereine, suggérant le triomphe de la paix et du Bien sur la vengeance et le Mal.
-207_de;207;de;Jane Eyre;Jane Eyre. Eine Autobiographie (Originaltitel: Jane Eyre. An Autobiography), erstmals erschienen im Jahr 1847 unter dem Pseudonym Currer Bell, ist der erste veröffentlichte Roman der britischen Autorin Charlotte Brontë und ein Klassiker der viktorianischen Romanliteratur des 19. Jahrhunderts. Der Roman erzählt in Form einer Ich-Erzählung die Lebensgeschichte von Jane Eyre (ausgesprochen /ˌdʒeɪn ˈɛə/), die nach einer schweren Kindheit eine Stelle als Gouvernante annimmt und sich in ihren Arbeitgeber verliebt, jedoch immer wieder um ihre Freiheit und Selbstbestimmung kämpfen muss. Als klein, dünn, blass, stets schlicht dunkel gekleidet und mit strengem Mittelscheitel beschrieben, gilt die Heldin des Romans Jane Eyre nicht zuletzt aufgrund der Kino- und Fernsehversionen der melodramatischen Romanvorlage als die bekannteste englische Gouvernante der Literaturgeschichte
-207_fr;252;de;Eleonora;“Eleonora” ist eine Erzählung von Edgar Allan Poe. Sie wurde 1841 erstveröffentlicht. In ihr geht es um das Paradox der Treue in der Treulosigkeit.

fiori/db/data/sap.capire.bookshop-GenreHierarchy.csv

@@ -1,16 +0,0 @@
-ID;parent_ID;name;hierarchyLevel;drillState
-10;;Fiction;0;expanded
-11;10;Drama;1;leaf
-12;10;Poetry;1;leaf
-13;10;Fantasy;1;leaf
-14;10;Science Fiction;1;leaf
-15;10;Romance;1;leaf
-16;10;Mystery;1;leaf
-17;10;Thriller;1;leaf
-18;10;Dystopia;1;leaf
-20;;Non-Fiction;0;expanded
-19;10;Fairy Tale;1;leaf
-21;20;Biography;1;expanded
-22;21;Autobiography;2;leaf
-23;20;Essay;1;leaf
-24;20;Speech;1;leaf

fiori/db/hana/index.cds

@@ -2,14 +2,9 @@
 //  Add Author.age and .lifetime with a DB-specific function
 //
 
-using { AdminService, sap.common } from '@capire/bookshop';
+using { AdminService } from '@capire/bookshop';
 
 extend projection AdminService.Authors with {
   YEARS_BETWEEN(dateOfBirth, dateOfDeath)         as age: Integer,
   YEAR(dateOfBirth) || ' – ' || YEAR(dateOfDeath) as lifetime : String
 }
-
-
-// Workaround: include Countries table because csv files point to it
-// TODO fix by ignoring hdbtabledata generation for unused entities
-annotate common.Countries with @cds.persistence.skip : false;

fiori/mta.yaml

@@ -1,97 +0,0 @@
-_schema-version: '3.1'
-ID: capire.fiori
-version: 1.0.0
-description: "fiori"
-parameters:
-  enable-parallel-deployments: true
-build-parameters:
-  before-all:
-    - builder: custom
-      commands:
-        - npx -p @sap/cds-dk cds build --production
-
-modules:
-  - name: fiori-srv
-    type: nodejs
-    path: gen/srv
-    parameters:
-      buildpack: nodejs_buildpack
-    build-parameters:
-      builder: npm
-    provides:
-      - name: srv-api # required by consumers of CAP services (e.g. approuter)
-        properties:
-          srv-url: ${default-url}
-      - name: mtx-api # potentially required by approuter
-        properties:
-          mtx-url: ${default-url}
-    requires:
-      - name: fiori-db
-      - name: fiori-registry
-      - name: fiori-auth
-      - name: app-api
-        properties:
-          SUBSCRIPTION_URL: ~{app-protocol}://\${tenant_subdomain}-~{app-uri}
-
-  - name: fiori
-    type: approuter.nodejs
-    path: app/_router # from cds.env.folders. Consider also cds.env.build.target -> gen/app
-    parameters:
-      keep-existing-routes: true
-      disk-quota: 256M
-      memory: 256M
-    properties:
-      TENANT_HOST_PATTERN: "^(.*)-${default-uri}"
-    requires:
-      - name: srv-api
-        group: destinations
-        properties:
-          name: srv-api # must be used in xs-app.json as well
-          url: ~{srv-url}
-          forwardAuthToken: true
-      - name: mtx-api
-        group: destinations
-        properties:
-          name: mtx-api # must be used in xs-app.json as well
-          url: ~{mtx-url}
-      - name: fiori-auth
-    provides:
-      - name: app-api
-        properties:
-          app-protocol: ${protocol}
-          app-uri: ${default-uri}
-
-resources:
-  - name: fiori-db
-    type: org.cloudfoundry.managed-service
-    parameters:
-      service: service-manager
-      service-plan: container
-  - name: fiori-registry
-    type: org.cloudfoundry.managed-service
-    requires:
-      - name: mtx-api
-    parameters:
-      service: saas-registry
-      service-plan: application
-      config:
-        xsappname: fiori-${org}-${space}
-        appName: fiori-${org}-${space}
-        displayName: fiori
-        description: A simple CAP project.
-        category: 'Category'
-        appUrls:
-          getDependencies: ~{mtx-api/mtx-url}/-/cds/saas-provisioning/dependencies
-          onSubscription: ~{mtx-api/mtx-url}/-/cds/saas-provisioning/tenant/{tenantId}
-          onSubscriptionAsync: false
-          onUnSubscriptionAsync: false
-          callbackTimeoutMillis: 300000
-  - name: fiori-auth
-    type: org.cloudfoundry.managed-service
-    parameters:
-      service: xsuaa
-      service-plan: application
-      path: ./xs-security.json
-      config:
-        xsappname: fiori-${org}-${space}
-        tenant-mode: shared

fiori/package.json

@@ -4,25 +4,18 @@
   "dependencies": {
     "@capire/bookstore": "*",
     "@sap/cds": ">=5",
-    "@sap/cds-mtxs": "^1",
-    "@sap/cds-odata-v2-adapter-proxy": "^1.9.0",
-    "@sap/xssec": "^3",
     "express": "^4.17.1",
-    "hdb": "^0.19.5",
     "passport": ">=0.4.1"
   },
   "scripts": {
     "start": "cds run --in-memory?",
     "watch": "cds watch"
   },
-  "engines": {
-    "node": "^16"
-  },
   "cds": {
-    "features": {
-      "deploy_data_onconflict": "replace"
-    },
     "requires": {
+      "auth": {
+        "kind": "dummy-auth"
+      },
       "ReviewsService": {
         "kind": "odata",
         "model": "@capire/reviews"
@@ -43,7 +36,10 @@
         }
       },
       "db": {
-        "kind": "sql-mt"
+        "kind": "sqlite",
+        "credentials": {
+          "database": "sqlite.db"
+        }
       },
       "db-ext": {
         "[development]": {
@@ -53,39 +49,8 @@
           "model": "db/hana"
         }
       },
-      "multitenancy": true,
-      "toggles": true,
-      "extensibility": true,
-      "cds.xt.ExtensibilityService": {
-        "element-prefix": [
-          "x_"
-        ],
-        "extension-allowlist": [
-          {
-            "for": [
-              "sap.capire.orders"
-            ],
-            "kind": "entity",
-            "new-fields": 3
-          },
-          {
-            "for": [
-              "OrdersService"
-            ],
-            "new-entities": 2
-          }
-        ]
-      },
-      "[production]": {
-        "auth": {
-          "kind": "xsuaa"
-        },
-        "db": {
-          "kind": "hana-mt"
-        }
-      },
-      "approuter": {
-        "kind": "cloudfoundry"
+      "hana": {
+        "deploy-format": "hdbtable"
       }
     }
   }

fiori/server.js

@@ -1,15 +1 @@
-const cds = require("@sap/cds")
-
-// install OData v2 adapter
-const proxy = require('@sap/cds-odata-v2-adapter-proxy')
-const proxyOpts = global.it ? { target:'auto' } : {} // for tests, set 'auto' to detect port dynamically
-cds.on('bootstrap', app => app.use(proxy(proxyOpts)))
-
 module.exports = require('@capire/bookstore/server.js')
-
-// For didactic reasons in capire, run below services embedded
-// TODO find a better way to switch this
-if (cds.requires.multitenancy) {
-  delete cds.env.requires.OrdersService
-  delete cds.env.requires.ReviewsService
-}

fiori/srv/index.cds

@@ -1 +0,0 @@
-using from '@capire/bookstore';

fiori/xs-security.json

@@ -1,51 +0,0 @@
-{
-  "scopes": [
-    {
-      "name": "$XSAPPNAME.admin",
-      "description": "admin"
-    },
-    {
-      "name": "$XSAPPNAME.mtcallback",
-      "description": "Subscription via SaaS Registry",
-      "grant-as-authority-to-apps": [
-        "$XSAPPNAME(application,sap-provisioning,tenant-onboarding)"
-      ]
-    },
-    {
-      "name": "$XSAPPNAME.cds.Subscriber",
-      "description": "Subscribe to applications"
-    },
-    {
-      "name": "$XSAPPNAME.cds.ExtensionDeveloper",
-      "description": "Extend CAP applications via extension projects"
-    },
-    {
-      "name": "$XSAPPNAME.cds.UIFlexDeveloper",
-      "description": "Extend CAP applications via UIFlex extensibility"
-    }
-  ],
-  "attributes": [],
-  "role-templates": [
-    {
-      "name": "admin",
-      "description": "admin",
-      "scope-references": [
-        "$XSAPPNAME.admin"
-      ]
-    },
-    {
-      "name": "ExtensionDeveloper",
-      "description": "Extension development including UIFlex extensibility",
-      "scope-references": [
-        "$XSAPPNAME.cds.ExtensionDeveloper",
-        "$XSAPPNAME.cds.UIFlexDeveloper"
-      ]
-    }
-  ],
-  "authorities-inheritance": false,
-  "authorities": [
-    "$XSAPPNAME.cds.Subscriber",
-    "$XSAPPNAME.cds.ExtensionDeveloper",
-    "$XSAPPNAME.cds.UIFlexDeveloper"
-  ]
-}

hello/package.json

@@ -12,8 +12,23 @@
   "devDependencies": {
     "@types/jest": "*",
     "@types/node": "*",
+    "ts-jest": "^27.0.2",
     "typescript": "^4.3.5"
   },
+  "jest": {
+    "testEnvironment": "node",
+    "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "diagnostics": {
+          "_comment": "see https://githubmemory.com/repo/kulshekhar/ts-jest/issues/2722",
+          "ignoreCodes": [
+            151001
+          ]
+        }
+      }
+    }
+  },
   "eslintConfig": {
     "extends": "eslint:recommended",
     "env": {

hello/test/hello-world-test.js

@@ -1,13 +0,0 @@
-const cds = require ('@sap/cds')
-describe('Hello world!', () => {
-
-    beforeAll (()=> process.env.CDS_TYPESCRIPT = true)
-    afterAll (()=> delete process.env.CDS_TYPESCRIPT)
-    const {GET} = cds.test.in(__dirname,'../srv').run('serve', 'world.cds')
-
-    it('should say hello with class impl', async () => {
-        const {data} = await GET`/say/hello(to='world')`
-        expect(data.value).toMatch(/Hello world.*typescript.*/i)
-    })
-
-})

hello/test/hello-world-ts.test.ts

@@ -0,0 +1,15 @@
+process.env.CDS_TYPESCRIPT = 'true';
+import * as cds from '@sap/cds';
+
+//@ts-ignore
+const {GET} = cds.test.in(__dirname,'../srv').run('serve', 'world.cds');
+
+describe('Hello world!', () => {
+    afterAll(() => { delete process.env.CDS_TYPESCRIPT; });
+
+    it('should say hello with class impl from a typescript file', async () => {
+        const {data} = await GET`/say/hello(to='world')`
+        expect(data.value).toMatch(/Hello world.*typescript.*/i)
+    })
+
+})

package.json

@@ -5,13 +5,18 @@
   "repository": "https://github.com/sap-samples/cloud-cap-samples.git",
   "author": "daniel.hutzel@sap.com",
   "dependencies": {
+    "@capire/bookstore": "./bookstore",
+    "@capire/bookshop": "./bookshop",
+    "@capire/common": "./common",
+    "@capire/data-viewer": "./data-viewer",
+    "@capire/fiori": "./fiori",
+    "@capire/hello": "./hello",
+    "@capire/media": "./media",
+    "@capire/orders": "./orders",
+    "@capire/reviews": "./reviews",
     "@sap/cds": ">=5.5.3"
   },
-  "workspaces": [
-    "./*/"
-  ],
   "devDependencies": {
-    "axios": "^0",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "chai-subset": "^1.6.0",
@@ -32,6 +37,7 @@
     "test:hello": "cd hello && npm test"
   },
   "jest": {
+    "testEnvironment": "node",
     "testTimeout": 20000,
     "testMatch": [
       "**/*.test.js"

reviews/db/data/sap.capire.reviews-Reviews.csv

@@ -1,5 +1,5 @@
-ID;subject;rating;reviewer;title;text
-5de47328-2ad2-4449-bb8c-e4000586b687;201;5;bob;Intriguing;Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
-f77ea7a8-01c8-469d-bf9e-80988758a2ee;201;4;bob;Fascinating;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Id diam maecenas ultricies mi eget mauris pharetra et. Risus at ultrices mi tempus imperdiet nulla malesuada pellentesque. Pulvinar mattis nunc sed blandit libero. Facilisis magna etiam tempor orci eu. Nec sagittis aliquam malesuada bibendum arcu. Eu consequat ac felis donec. Ultricies tristique nulla aliquet enim tortor at auctor urna nunc. Tortor posuere ac ut consequat semper viverra nam libero. Amet nisl suscipit adipiscing bibendum est ultricies integer quis auctor. Scelerisque purus semper eget duis at tellus. Elementum tempus egestas sed sed risus pretium. Arcu dictum varius duis at. Amet luctus venenatis lectus magna fringilla urna. Eget velit aliquet sagittis id consectetur purus ut faucibus. Vitae auctor eu augue ut lectus. Fermentum iaculis eu non diam phasellus vestibulum.
-6b7ee8c9-0a18-4716-b333-eb95b7570f4e;207;2;bob;What is this?;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Libero justo laoreet sit amet cursus sit amet dictum. Nunc faucibus a pellentesque sit. Dis parturient montes nascetur ridiculus mus mauris vitae ultricies. Enim nunc faucibus a pellentesque. Commodo quis imperdiet massa tincidunt nunc pulvinar sapien. Cras ornare arcu dui vivamus. Facilisi etiam dignissim diam quis enim lobortis. Et molestie ac feugiat sed. Urna neque viverra justo nec ultrices dui. Ullamcorper a lacus vestibulum sed arcu non. Volutpat ac tincidunt vitae semper quis. Dignissim sodales ut eu sem. Feugiat in fermentum posuere urna nec. At augue eget arcu dictum varius.
-10403669-7e56-4668-bfb0-2071bbc947f3;251;3;bob;It's dark...;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Suscipit tellus mauris a diam. Velit aliquet sagittis id consectetur purus ut. Viverra adipiscing at in tellus integer. Vitae elementum curabitur vitae nunc. Mattis ullamcorper velit sed ullamcorper morbi. Diam quis enim lobortis scelerisque. Auctor neque vitae tempus quam pellentesque nec nam aliquam. Semper auctor neque vitae tempus. Quis eleifend quam adipiscing vitae proin. Neque convallis a cras semper auctor neque vitae. Imperdiet massa tincidunt nunc pulvinar sapien et ligula. Sit amet consectetur adipiscing elit ut aliquam purus. Pretium quam vulputate dignissim suspendisse.
+subject;rating;reviewer;title;text
+201;5;bob;Intriguing;Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet.
+201;4;bob;Fascinating;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Id diam maecenas ultricies mi eget mauris pharetra et. Risus at ultrices mi tempus imperdiet nulla malesuada pellentesque. Pulvinar mattis nunc sed blandit libero. Facilisis magna etiam tempor orci eu. Nec sagittis aliquam malesuada bibendum arcu. Eu consequat ac felis donec. Ultricies tristique nulla aliquet enim tortor at auctor urna nunc. Tortor posuere ac ut consequat semper viverra nam libero. Amet nisl suscipit adipiscing bibendum est ultricies integer quis auctor. Scelerisque purus semper eget duis at tellus. Elementum tempus egestas sed sed risus pretium. Arcu dictum varius duis at. Amet luctus venenatis lectus magna fringilla urna. Eget velit aliquet sagittis id consectetur purus ut faucibus. Vitae auctor eu augue ut lectus. Fermentum iaculis eu non diam phasellus vestibulum.
+207;2;bob;What is this?;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Libero justo laoreet sit amet cursus sit amet dictum. Nunc faucibus a pellentesque sit. Dis parturient montes nascetur ridiculus mus mauris vitae ultricies. Enim nunc faucibus a pellentesque. Commodo quis imperdiet massa tincidunt nunc pulvinar sapien. Cras ornare arcu dui vivamus. Facilisi etiam dignissim diam quis enim lobortis. Et molestie ac feugiat sed. Urna neque viverra justo nec ultrices dui. Ullamcorper a lacus vestibulum sed arcu non. Volutpat ac tincidunt vitae semper quis. Dignissim sodales ut eu sem. Feugiat in fermentum posuere urna nec. At augue eget arcu dictum varius.
+251;3;bob;It's dark...;Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Suscipit tellus mauris a diam. Velit aliquet sagittis id consectetur purus ut. Viverra adipiscing at in tellus integer. Vitae elementum curabitur vitae nunc. Mattis ullamcorper velit sed ullamcorper morbi. Diam quis enim lobortis scelerisque. Auctor neque vitae tempus quam pellentesque nec nam aliquam. Semper auctor neque vitae tempus. Quis eleifend quam adipiscing vitae proin. Neque convallis a cras semper auctor neque vitae. Imperdiet massa tincidunt nunc pulvinar sapien et ligula. Sit amet consectetur adipiscing elit ut aliquam purus. Pretium quam vulputate dignissim suspendisse.

samples.md

@@ -69,20 +69,14 @@ Each sub directory essentially is an individual npm package arranged in an [all-
 
 ## [@capire/fiori](fiori)
 
-- Adds an SAP Fiori elements application to bookstore, thereby introducing:
-- OData Annotations in `.cds` files
-- Support for Fiori Draft
-- Support for Value Helps
+- [Adds an SAP Fiori elements application](https://cap.cloud.sap/docs/guides/fiori/) to bookstore, thereby introducing to:
+- [OData Annotations](https://cap.cloud.sap/docs/guides/fiori#adding-odata-annotations) in `.cds` files
+- Support for [Fiori Draft](https://cap.cloud.sap/docs/guides/fiori#draft)
+- Support for [Value Helps](https://cap.cloud.sap/docs/guides/fiori#value-help)
 - Serving SAP Fiori apps locally
-- Fiori Elements V2
-  - OData V2 using CDS OData V2 Adapter Proxy
-  - List Report (type `TreeTable`)
-  - `@sap.hierarchy` annotations
-
-See the [Serving Fiori UIs](https://cap.cloud.sap/docs/advanced/fiori) documentation for more information.
 
 <br>
 
 # All-in-one Monorepo
 
-Each sample sub directory essentially is a standard npm package, some with standard npm dependencies to other samples. The root folder's [package.json](package.json) has local links to the sub folders, such that an `npm install` populates a local `node_modules` folder and acts like a local npm registry to the individual sample packages.
+Each sample sub directory essentially is a standard npm package, some with standard npm dependencies to other samples. The root folder's [package.json](package.json) has local links to the sub folders, such that an `npm install` populates a local `node_modules` folder acts like a local npm registry to the individual sample packages.

test/cds.ql.test.js

@@ -1,18 +1,20 @@
+const cds = require('@sap/cds/lib')
+const { expect } = cds.test
+const { cdr } = cds.ql
+const Foo = { name: 'Foo' }
+const Books = { name: 'capire.bookshop.Books' }
+
+
+const STAR = cdr ? '*' : { ref: ['*'] }
+const skip = {to:{eql:()=>skip}}
+const srv = new cds.Service
+let cqn
+
+expect.plain = (cqn) => !cqn.SELECT.one && !cqn.SELECT.distinct ? expect(cqn) : skip
+expect.one = (cqn) => !cqn.SELECT.distinct ? expect(cqn) : skip
+
 describe('cds.ql → cqn', () => {
-
-  const cds = require('@sap/cds/lib')
-  const { expect } = cds.test
-  const { cdr } = cds.ql
-  const Foo = { name: 'Foo' }
-  const Books = { name: 'capire.bookshop.Books' }
-
-  const STAR = cdr ? '*' : { ref: ['*'] }
-  const skip = {to:{eql:()=>skip}}
-  const srv = new cds.Service
-  let cqn
-
-  expect.plain = (cqn) => !cqn.SELECT.one && !cqn.SELECT.distinct ? expect(cqn) : skip
-  expect.one = (cqn) => !cqn.SELECT.distinct ? expect(cqn) : skip
+  //
 
   describe.each(['SELECT', 'SELECT one', 'SELECT distinct'])(`%s...`, (each) => {
 
@@ -411,67 +413,18 @@ describe('cds.ql → cqn', () => {
         ]
       }})
 
-      const ql_with_groups_fix = !!cds.ql.Query.prototype.flat
-      if (ql_with_groups_fix) {
-
-        expect (
-          SELECT.from(Foo).where({x:1}).or({y:2}).and({z:3})
-        ).to.eql ({ SELECT: {
-          from: {ref:['Foo']},
-          where: [
-            {ref:['x']}, '=', {val:1},
-            'or',
-            {ref:['y']}, '=', {val:2},
-            'and',
-            {ref:['z']}, '=', {val:3},
-          ]
-        }})
-
-        expect (
-          SELECT.from(Foo).where({x:1,or:{y:2}}).and({z:3})
-        ).to.eql ({ SELECT: {
-          from: {ref:['Foo']},
-          where: [
-            {xpr:[
-              {ref:['x']}, '=', {val:1},
-              'or',
-              {ref:['y']}, '=', {val:2},
-            ]},
-            'and',
-            {ref:['z']}, '=', {val:3},
-          ]
-        }})
-
-        expect (
-          SELECT.from(Foo).where({a:1}).or({x:1,or:{y:2}}).and({z:3})
-        ).to.eql ({ SELECT: {
-          from: {ref:['Foo']},
-          where: [
-            {ref:['a']}, '=', {val:1},
-            'or',
-            {xpr:[
-              {ref:['x']}, '=', {val:1},
-              'or',
-              {ref:['y']}, '=', {val:2},
-            ]},
-            'and',
-            {ref:['z']}, '=', {val:3},
-          ]
-        }})
-
-        expect (
-          { SELECT: SELECT.from(Foo).where({x:1,or:{y:2}}).SELECT }
-        ).to.eql ({ SELECT: {
-          from: {ref:['Foo']},
-          where: [
-            {ref:['x']}, '=', {val:1},
-            'or',
-            {ref:['y']}, '=', {val:2},
-          ]
-        }})
-
-      }
-
+      expect (
+        SELECT.from(Foo).where({x:1,or:{y:2}})
+      ).to.eql (
+        CQL`SELECT from Foo where x=1 or y=2`
+      ).to.eql ({ SELECT: {
+        from: {ref:['Foo']},
+        where: [
+          {ref:['x']}, '=', {val:1},
+          'or',
+          {ref:['y']}, '=', {val:2}
+        ]
+      }})
 
       expect (
         SELECT.from(Foo).where({x:1,and:{y:2}}).or({z:3})

test/consuming-services.test.js

@@ -1,9 +1,8 @@
 const cds = require('@sap/cds/lib')
+const { expect } = cds.test ('@capire/bookshop')
 
 describe('cap/samples - Consuming Services locally', () => {
-
-  const { expect } = cds.test ('@capire/bookshop')
-
+  //
   it('bootstrapped the database successfully', ()=>{
     const { AdminService } = cds.services
     const { Authors } = AdminService.entities
@@ -15,7 +14,7 @@ describe('cap/samples - Consuming Services locally', () => {
     const AdminService = await cds.connect.to('AdminService')
     const { Authors } = AdminService.entities
     expect (await SELECT.from(Authors))
-    // .to.eql(await SELECT.from('Authors'))
+    .to.eql(await SELECT.from('Authors'))
     .to.eql(await AdminService.read(Authors))
     .to.eql(await AdminService.read('Authors'))
     .to.eql(await AdminService.run(SELECT.from(Authors)))

test/custom-handlers.test.js

@@ -1,11 +1,10 @@
 const cds = require('@sap/cds/lib')
+const { GET, POST, expect } = cds.test(__dirname+'/../bookshop')
+if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
+else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
 
 describe('cap/samples - Custom Handlers', () => {
 
-  const { GET, POST, expect } = cds.test(__dirname+'/../bookshop')
-  if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
-  else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
-
   it('should reject out-of-stock orders', async () => {
     await POST `/browse/submitOrder ${{ book: 201, quantity: 5 }}`
     await POST `/browse/submitOrder ${{ book: 201, quantity: 5 }}`

test/fiori.test.js

@@ -1,23 +0,0 @@
-const cds = require('@sap/cds/lib')
-
-describe('cap/samples - Fiori APIs - v2', () => {
-
-  const { GET, expect, axios } = cds.test ('@capire/fiori', '--with-mocks')
-  axios.defaults.auth = { username: 'alice', password: 'admin' }
-
-  it('serves $metadata documents in v2', async () => {
-    const { headers, data } = await GET `/v2/browse/$metadata`
-    expect(headers).to.contain({
-      'content-type': 'application/xml',
-      'dataserviceversion': '2.0',
-    })
-    expect(data).to.contain('<EntitySet Name="GenreHierarchy" EntityType="CatalogService.GenreHierarchy"/>')
-  })
-
-  it('serves Books in v2', async () => {
-    const { data } = await GET `/v2/browse/Books`
-    expect(data).to.containSubset({d:{results:[]}})
-    expect(data.d.results.length).to.be.greaterThanOrEqual(5)
-  })
-
-})

test/hello-world.test.js

@@ -1,9 +1,8 @@
 const cds = require('@sap/cds/lib')
+const { GET, expect } = cds.test (__dirname+'/../hello')
 
 describe('cap/samples - Hello world!', () => {
 
-  const { GET, expect } = cds.test (__dirname+'/../hello')
-
   it('should say hello with class impl', async () => {
     const {data} = await GET `/say/hello(to='world')`
     expect(data.value).to.eql('Hello world!')

test/hierarchical-data.test.js

@@ -1,18 +1,20 @@
 const cds = require('@sap/cds/lib')
+const {expect} = cds.test
+
+// should become cds.compile(...) when cds5 is released
+const model = cds.compile.to.csn (`
+  entity Categories {
+    key ID   : Integer;
+    name     : String;
+    children : Composition of many Categories on children.parent = $self;
+    parent   : Association to Categories;
+  }
+`)
+const {Categories:Cats} = model.definitions
+
 
 describe('cap/samples - Hierarchical Data', ()=>{
 
-	const model = CDL`
-		entity Categories {
-			key ID   : Integer;
-			name     : String;
-			children : Composition of many Categories on children.parent = $self;
-			parent   : Association to Categories;
-		}
-	`
-	const {Categories:Cats} = model.definitions
-	const {expect} = cds.test
-
 	before ('bootstrap sqlite in-memory db...', async()=>{
 		await cds.deploy (model) .to ('sqlite::memory:')
 		expect (cds.db) .to.exist

test/localized-data/services.test.js

@@ -1,14 +1,25 @@
+const { GET, expect, cds } = require('@sap/cds/lib').test (__dirname)
+if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
+else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
+
 describe('cap/samples - Localized Data', () => {
 
-  const { GET, expect, cds } = require('@sap/cds/lib').test (__dirname)
-  if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
-  else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
-
   it('serves localized $metadata documents', async () => {
-    const { data } = await GET(`/browse/$metadata?sap-language=de`, { headers: { 'accept-language': 'de' }})
+    const { data } = await GET`/browse/$metadata?sap-language=de`
     expect(data).to.contain('<Annotation Term="Common.Label" String="Währung"/>')
   })
 
+  it('supports sap-language param', async () => {
+    const { data } = await GET(`/browse/Books?$select=title,author` + '&sap-language=de')
+    expect(data.value).to.containSubset([
+      { title: 'Sturmhöhe', author: 'Emily Brontë' },
+      { title: 'Jane Eyre', author: 'Charlotte Brontë' },
+      { title: 'The Raven', author: 'Edgar Allen Poe' },
+      { title: 'Eleonora', author: 'Edgar Allen Poe' },
+      { title: 'Catweazle', author: 'Richard Carpenter' },
+    ])
+  })
+
   it('supports accept-language header', async () => {
     const { data } = await GET(`/browse/Books?$select=title,author`, {
       headers: { 'Accept-Language': 'de' },

test/messaging.test.js

@@ -1,20 +1,14 @@
 const cds = require('@sap/cds/lib')
-const {resolve} = require('path')
+const { expect } = cds.test
+const _model = '@capire/reviews'
+if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
+else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
 
 describe('cap/samples - Messaging', ()=>{
 
-    const { expect } = cds.test
-    const _model = '@capire/reviews'
-    const Reviews = 'sap.capire.reviews.Reviews'
-    if (cds.User.default) cds.User.default = cds.User.Privileged // hard core monkey patch
-    else cds.User = cds.User.Privileged // hard core monkey patch for older cds releases
-
-    beforeAll(() => { cds.root = resolve(__dirname, '..') })
-    afterAll(() => { cds.root = process.cwd() })
-
     it ('should bootstrap sqlite in-memory db', async()=>{
         const db = await cds.deploy (_model) .to ('sqlite::memory:')
-        await db.delete(Reviews)
+        await db.delete('Reviews')
         expect (db.model) .not.undefined
     })
 

test/odata.test.js

@@ -1,8 +1,8 @@
 const cds = require('@sap/cds/lib')
+const { GET, expect, axios } = cds.test ('@capire/bookshop')
+axios.defaults.auth = { username: 'alice', password: 'admin' }
 
 describe('cap/samples - Bookshop APIs', () => {
-  const { GET, expect, axios } = cds.test ('@capire/bookshop')
-  axios.defaults.auth = { username: 'alice', password: 'admin' }
 
   // Genres
   const Drama = {

test/registry.test.js

@@ -1,14 +1,12 @@
 
 const cds = require('@sap/cds/lib')
+const { expect } = cds.test
 const { fork } = require('child_process')
 const { resolve } = require('path')
 const verbose = process.env.CDS_TEST_VERBOSE
+// ||true
 
 describe('cap/samples - Local NPM registry', () => {
-
-  const { expect } = cds.test
-  // ||true
-
   let registry
   let axios
   const cwd = resolve(__dirname, '..')