Enforce eslint 9, fix config

.eslintrc

@@ -0,0 +1,31 @@
+{
+  "extends": [
+    "plugin:@sap/cds/recommended",
+    "eslint:recommended"
+  ],
+  "env": {
+    "browser": true,
+    "es2022": true,
+    "node": true,
+    "jest": true,
+    "mocha": true
+  },
+  "globals": {
+    "SELECT": true,
+    "INSERT": true,
+    "UPSERT": true,
+    "UPDATE": true,
+    "DELETE": true,
+    "CREATE": true,
+    "DROP": true,
+    "CDL": true,
+    "CQL": true,
+    "cds": true
+  },
+  "rules": {
+    "no-console": "off",
+    "require-atomic-updates": "off",
+        "require-await":"warn",
+        "no-unused-vars": ["warn", { "argsIgnorePattern": "_" }]
+  }
+}

.github/workflows/node.js.yml

@@ -11,6 +11,7 @@ on:
 
 jobs:
   build:
+
     runs-on: ubuntu-latest
 
     strategy:
@@ -18,21 +19,10 @@ jobs:
         node-version: [20.x, 18.x]
 
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
     - run: npm ci
     - run: npm test
-
-  lint:
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v4
-    - uses: actions/setup-node@v4
-      with:
-        node-version: 20.x
-    - run: npm ci
-    - run: npm run lint

bookshop/package.json

@@ -13,7 +13,7 @@
     "@cap-js/sqlite": "*"
   },
   "dependencies": {
-    "@sap/cds": ">=7",
+    "@sap/cds": "^7",
     "express": "^4.17.1"
   },
   "scripts": {

eslint.config.js

@@ -1,27 +1,27 @@
-const eslintCds = require('@sap/eslint-plugin-cds')
-const eslintJs = require('@eslint/js')
-const globals = require('globals')
+const globals = require("globals");
+const js = require('@eslint/js');
+const cds = require('@sap/eslint-plugin-cds');
 
 module.exports = [
-  eslintJs.configs.recommended,
-  eslintCds.configs.recommended,
+  cds.configs.recommended,
   {
-    languageOptions: {
-      globals: {
-        sap: true,
-        ...globals.es2022,
+    "files": ["**/*.js"],
+    ...js.configs.recommended,
+    "languageOptions": {
+      "globals": {
         ...globals.browser,
         ...globals.node,
         ...globals.jest,
         ...globals.mocha,
-        ...eslintCds.configs.recommended.languageOptions.globals
-      }
+        "es2022": true
+      },
     },
-    rules: {
-      'no-console': 'off',
-      'no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
-      'require-atomic-updates': 'off',
-      'require-await': 'warn'
+    "rules": {
+      ...js.configs.recommended.rules,
+      "no-console": "off",
+      "require-atomic-updates": "off",
+      "require-await": "warn",
+      "no-unused-vars": ["warn", { "argsIgnorePattern": "_" }]
     }
   }
 ]

package.json

@@ -1,58 +1,57 @@
 {
-    "name": "@capire/samples",
-    "version": "2.0.0",
-    "description": "A monorepo with several samples for CAP.",
-    "repository": "https://github.com/sap-samples/cloud-cap-samples.git",
-    "author": "daniel.hutzel@sap.com",
-    "dependencies": {
-      "@sap/cds": ">=7"
-    },
-    "workspaces": [
-      "./bookshop",
-      "./bookstore",
-      "./common",
-      "./data-viewer",
-      "./fiori",
-      "./hello",
-      "./media",
-      "./orders",
-      "./loggers",
-      "./reviews"
-    ],
-    "devDependencies": {
-      "@cap-js/sqlite": "^1",
-      "@sap/eslint-plugin-cds": "^3",
-      "axios": "^1",
-      "chai": "^4.3.4",
-      "chai-as-promised": "^7.1.1",
-      "chai-subset": "^1.6.0",
-      "eslint": "^9",
-      "semver": "^7"
-    },
-    "scripts": {
-      "cleanup": "rm -rf node_modules && rm -rf */node_modules && rm -rf */*/node_modules",
-      "bookshop": "cds watch bookshop",
-      "fiori": "cds watch fiori",
-      "hello": "cds watch hello",
-      "media": "cds watch media",
-      "mocha": "CDS_TEST_SILENT=y npx mocha",
-      "jest": "npx jest --silent",
-      "start": "cds watch fiori",
-      "test": "npm run jest -- --silent",
-      "test:hello": "cd hello && npm test",
-      "lint": "eslint ."
-    },
-    "jest": {
-      "testTimeout": 20000,
-      "testMatch": [
-        "**/*.test.js"
-      ]
-    },
-    "mocha": {
-      "recursive": true,
-      "parallel": true,
-      "timeout": 6666
-    },
-    "license": "SEE LICENSE IN LICENSE",
-    "private": true
-  }
+  "name": "@capire/samples",
+  "version": "2.0.0",
+  "description": "A monorepo with several samples for CAP.",
+  "repository": "https://github.com/sap-samples/cloud-cap-samples.git",
+  "author": "daniel.hutzel@sap.com",
+  "dependencies": {
+    "@sap/cds": ">=7"
+  },
+  "workspaces": [
+    "./bookshop",
+    "./bookstore",
+    "./common",
+    "./data-viewer",
+    "./fiori",
+    "./hello",
+    "./media",
+    "./orders",
+    "./loggers",
+    "./reviews"
+  ],
+  "devDependencies": {
+    "@cap-js/sqlite": "^1",
+    "@sap/eslint-plugin-cds": "^3",
+    "axios": "^1",
+    "chai": "^4.3.4",
+    "chai-as-promised": "^7.1.1",
+    "chai-subset": "^1.6.0",
+    "eslint": "^9",
+    "semver": "^7"
+  },
+  "scripts": {
+    "cleanup": "rm -rf node_modules && rm -rf */node_modules && rm -rf */*/node_modules",
+    "bookshop": "cds watch bookshop",
+    "fiori": "cds watch fiori",
+    "hello": "cds watch hello",
+    "media": "cds watch media",
+    "mocha": "CDS_TEST_SILENT=y npx mocha",
+    "jest": "npx jest --silent",
+    "start": "cds watch fiori",
+    "test": "npm run jest -- --silent",
+    "test:hello": "cd hello && npm test"
+  },
+  "jest": {
+    "testTimeout": 20000,
+    "testMatch": [
+      "**/*.test.js"
+    ]
+  },
+  "mocha": {
+    "recursive": true,
+    "parallel": true,
+    "timeout": 6666
+  },
+  "license": "SEE LICENSE IN LICENSE",
+  "private": true
+}